From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 15/20] ARM: LPAE: use phys_addr_t instead of unsigned long for physical addresses
Date: Tue, 16 Nov 2010 11:14:25 -0800 [thread overview]
Message-ID: <4CE2D811.50701@codeaurora.org> (raw)
In-Reply-To: <1289842829-3027-16-git-send-email-catalin.marinas@arm.com>
On 11/15/2010 09:40 AM, Catalin Marinas wrote:
> @@ -188,21 +189,21 @@
> * translation for translating DMA addresses. Use the driver
> * DMA support - see dma-mapping.h.
> */
> -static inline unsigned long virt_to_phys(void *x)
> +static inline phys_addr_t virt_to_phys(void *x)
> {
> return __virt_to_phys((unsigned long)(x));
> }
As you're already in the area can you mark the argument to
virt_to_phys() as const? I ran into a compiler warning due to that the
other day.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH v3 15/20] ARM: LPAE: use phys_addr_t instead of unsigned long for physical addresses
Date: Tue, 16 Nov 2010 11:14:25 -0800 [thread overview]
Message-ID: <4CE2D811.50701@codeaurora.org> (raw)
In-Reply-To: <1289842829-3027-16-git-send-email-catalin.marinas@arm.com>
On 11/15/2010 09:40 AM, Catalin Marinas wrote:
> @@ -188,21 +189,21 @@
> * translation for translating DMA addresses. Use the driver
> * DMA support - see dma-mapping.h.
> */
> -static inline unsigned long virt_to_phys(void *x)
> +static inline phys_addr_t virt_to_phys(void *x)
> {
> return __virt_to_phys((unsigned long)(x));
> }
As you're already in the area can you mark the argument to
virt_to_phys() as const? I ran into a compiler warning due to that the
other day.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2010-11-16 19:14 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 17:40 [PATCH v3 00/20] ARM: Add support for the Large Physical Address Extensions Catalin Marinas
2010-11-15 17:40 ` Catalin Marinas
2010-11-15 17:40 ` [PATCH v3 01/20] ARM: LPAE: Use PMD_(SHIFT|SIZE|MASK) instead of PGDIR_* Catalin Marinas
2010-11-15 17:40 ` Catalin Marinas
2010-11-15 17:40 ` [PATCH v3 02/20] ARM: LPAE: Factor out 2-level page table definitions into separate files Catalin Marinas
2010-11-15 17:40 ` Catalin Marinas
2010-11-15 17:40 ` [PATCH v3 03/20] ARM: LPAE: use long long format when printing physical addresses and ptes Catalin Marinas
2010-11-15 17:40 ` Catalin Marinas
2010-11-15 17:40 ` [PATCH v3 04/20] ARM: LPAE: use u32 instead of unsigned long for 32-bit ptes Catalin Marinas
2010-11-15 17:40 ` Catalin Marinas
2010-11-15 17:40 ` [PATCH v3 05/20] ARM: LPAE: Do not assume Linux PTEs are always at PTRS_PER_PTE offset Catalin Marinas
2010-11-15 17:40 ` Catalin Marinas
2010-11-15 17:40 ` [PATCH v3 06/20] ARM: LPAE: Introduce L_PTE_NOEXEC and L_PTE_NOWRITE Catalin Marinas
2010-11-15 17:40 ` Catalin Marinas
2010-11-15 17:40 ` [PATCH v3 07/20] ARM: LPAE: Introduce the 3-level page table format definitions Catalin Marinas
2010-11-15 17:40 ` Catalin Marinas
2010-11-15 17:40 ` [PATCH v3 08/20] ARM: LPAE: Page table maintenance for the 3-level format Catalin Marinas
2010-11-15 17:40 ` Catalin Marinas
2010-11-15 17:40 ` [PATCH v3 09/20] ARM: LPAE: MMU setup for the 3-level page table format Catalin Marinas
2010-11-15 17:40 ` Catalin Marinas
2010-11-15 17:40 ` [PATCH v3 10/20] ARM: LPAE: Change setup_mm_for_reboot() to work with LPAE Catalin Marinas
2010-11-15 17:40 ` Catalin Marinas
2010-11-15 17:40 ` [PATCH v3 11/20] ARM: LPAE: Remove the FIRST_USER_PGD_NR and USER_PTRS_PER_PGD definitions Catalin Marinas
2010-11-15 17:40 ` Catalin Marinas
2010-11-15 17:40 ` [PATCH v3 12/20] ARM: LPAE: Add fault handling support Catalin Marinas
2010-11-15 17:40 ` Catalin Marinas
2010-11-15 17:40 ` [PATCH v3 13/20] ARM: LPAE: Add context switching support Catalin Marinas
2010-11-15 17:40 ` Catalin Marinas
2010-11-15 17:40 ` [PATCH v3 14/20] ARM: LPAE: Add SMP support for the 3-level page table format Catalin Marinas
2010-11-15 17:40 ` Catalin Marinas
2010-11-15 17:40 ` [PATCH v3 15/20] ARM: LPAE: use phys_addr_t instead of unsigned long for physical addresses Catalin Marinas
2010-11-15 17:40 ` Catalin Marinas
2010-11-16 19:14 ` Stephen Boyd [this message]
2010-11-16 19:14 ` Stephen Boyd
2010-11-16 19:33 ` Russell King - ARM Linux
2010-11-16 19:33 ` Russell King - ARM Linux
2010-11-17 10:47 ` Catalin Marinas
2010-11-17 10:47 ` Catalin Marinas
2010-11-17 11:18 ` Arnd Bergmann
2010-11-17 11:18 ` Arnd Bergmann
2010-11-17 15:28 ` Catalin Marinas
2010-11-17 15:28 ` Catalin Marinas
2010-11-17 15:40 ` Arnd Bergmann
2010-11-17 15:40 ` Arnd Bergmann
2010-11-15 17:40 ` [PATCH v3 16/20] ARM: LPAE: Use generic dma_addr_t type definition Catalin Marinas
2010-11-15 17:40 ` Catalin Marinas
2010-11-15 17:40 ` [PATCH v3 17/20] ARM: LPAE: mark memory banks with start > ULONG_MAX as highmem Catalin Marinas
2010-11-15 17:40 ` Catalin Marinas
2010-11-15 17:40 ` [PATCH v3 18/20] ARM: LPAE: use phys_addr_t for physical start address in early_mem Catalin Marinas
2010-11-15 17:40 ` Catalin Marinas
2010-11-15 17:40 ` [PATCH v3 19/20] ARM: LPAE: add support for ATAG_MEM64 Catalin Marinas
2010-11-15 17:40 ` Catalin Marinas
2010-11-15 17:40 ` [PATCH v3 20/20] ARM: LPAE: Add the Kconfig entries Catalin Marinas
2010-11-15 17:40 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE2D811.50701@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.