All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Christoph Lameter <cl@linux.com>,
	linux-mm@kvack.org
Subject: Re: [patch 2/3] mm: remove gfp mask from pcpu_get_vm_areas
Date: Wed, 17 Nov 2010 10:08:25 +0100	[thread overview]
Message-ID: <4CE39B89.8010908@kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1011161937380.19230@chino.kir.corp.google.com>

On 11/17/2010 04:41 AM, David Rientjes wrote:
> pcpu_get_vm_areas() only uses GFP_KERNEL allocations, so remove the gfp_t
> formal and use the mask internally.
> 
> Signed-off-by: David Rientjes <rientjes@google.com>

Patch itself looks okay to me but why do you want to drop the
argument?

Thanks.

-- 
tejun

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2010-11-17  9:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17  3:41 [patch 1/3] mm: remove unused get_vm_area_node David Rientjes
2010-11-17  3:41 ` [patch 2/3] mm: remove gfp mask from pcpu_get_vm_areas David Rientjes
2010-11-17  9:08   ` Tejun Heo [this message]
2010-11-17 20:32     ` David Rientjes
2010-11-18  6:29       ` Tejun Heo
2010-11-17  3:41 ` [patch 3/3] mm: unify module_alloc code for vmalloc David Rientjes
2010-11-17  3:41   ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CE39B89.8010908@kernel.org \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=linux-mm@kvack.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.