From: David Daney <ddaney@caviumnetworks.com>
To: Grant Likely <grant.likely@secretlab.ca>,
David Miller <davem@davemloft.net>
Cc: devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] phylib: Add support for Marvell 88E1149R devices.
Date: Thu, 18 Nov 2010 13:06:53 -0800 [thread overview]
Message-ID: <4CE5956D.5020507@caviumnetworks.com> (raw)
In-Reply-To: <20101118204410.GB16908@angua.secretlab.ca>
On 11/18/2010 12:44 PM, Grant Likely wrote:
> On Thu, Nov 18, 2010 at 11:46:16AM -0800, David Miller wrote:
>> From: David Daney<ddaney@caviumnetworks.com>
>> Date: Wed, 17 Nov 2010 15:54:31 -0800
>>
>>> The 88E1149R is 10/100/1000 quad-gigabit Ethernet PHY. The
>>> .config_aneg function can be shared with 88E1118, but it needs its own
>>> .config_init.
>>>
>>> Signed-off-by: David Daney<ddaney@caviumnetworks.com>
>>
>> Please resend this when you've respun patch #1 based upon the feedback
>> you've been given.
>
> It looks to me that this patch has no dependencies on the first patch.
> ddaney; what say you?
>
It calls the marvell_of_reg_init() function introduced in the first
patch. Reordering the patches would be possible, but since nobody else
has cared enough to add 88E1149R support, it shouldn't affect anyone be
me.
I arbitrarily ordered it this way. If davem wishes, I could re-order
the patches and 88E1149R could be merged before the device tree part.
David Daney
WARNING: multiple messages have this Message-ID (diff)
From: David Daney <ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
To: Grant Likely
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] phylib: Add support for Marvell 88E1149R devices.
Date: Thu, 18 Nov 2010 13:06:53 -0800 [thread overview]
Message-ID: <4CE5956D.5020507@caviumnetworks.com> (raw)
In-Reply-To: <20101118204410.GB16908-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
On 11/18/2010 12:44 PM, Grant Likely wrote:
> On Thu, Nov 18, 2010 at 11:46:16AM -0800, David Miller wrote:
>> From: David Daney<ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
>> Date: Wed, 17 Nov 2010 15:54:31 -0800
>>
>>> The 88E1149R is 10/100/1000 quad-gigabit Ethernet PHY. The
>>> .config_aneg function can be shared with 88E1118, but it needs its own
>>> .config_init.
>>>
>>> Signed-off-by: David Daney<ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
>>
>> Please resend this when you've respun patch #1 based upon the feedback
>> you've been given.
>
> It looks to me that this patch has no dependencies on the first patch.
> ddaney; what say you?
>
It calls the marvell_of_reg_init() function introduced in the first
patch. Reordering the patches would be possible, but since nobody else
has cared enough to add 88E1149R support, it shouldn't affect anyone be
me.
I arbitrarily ordered it this way. If davem wishes, I could re-order
the patches and 88E1149R could be merged before the device tree part.
David Daney
next prev parent reply other threads:[~2010-11-18 21:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 23:54 [PATCH 0/2] of/phylib: Use device tree properties for PHY configuration David Daney
2010-11-17 23:54 ` David Daney
2010-11-17 23:54 ` [PATCH 1/2] of/phylib: Use device tree properties to initialize Marvell PHYs David Daney
2010-11-17 23:54 ` David Daney
2010-11-18 0:01 ` David Daney
2010-11-18 0:01 ` David Daney
[not found] ` <1290038071-13296-2-git-send-email-ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2010-11-18 5:38 ` [1/2] " Milton Miller
2010-11-18 17:40 ` David Daney
2010-11-18 17:40 ` David Daney
2010-11-18 19:32 ` [PATCH 1/2] " Cyril Chemparathy
2010-11-18 20:40 ` Grant Likely
2010-11-18 20:40 ` Grant Likely
2010-11-18 23:48 ` David Daney
2010-11-18 23:48 ` David Daney
2010-11-19 0:39 ` Grant Likely
2010-11-19 0:39 ` Grant Likely
2010-11-17 23:54 ` [PATCH 2/2] phylib: Add support for Marvell 88E1149R devices David Daney
2010-11-17 23:54 ` David Daney
2010-11-18 19:46 ` David Miller
2010-11-18 19:46 ` David Miller
2010-11-18 20:44 ` Grant Likely
2010-11-18 20:44 ` Grant Likely
2010-11-18 20:57 ` David Miller
2010-11-18 20:57 ` David Miller
2010-11-18 21:06 ` David Daney [this message]
2010-11-18 21:06 ` David Daney
-- strict thread matches above, loose matches on Subject: below --
2010-11-19 21:58 [PATCH 0/2] phylib: Cleanup marvell.c and add 88E1149R support David Daney
2010-11-19 21:58 ` [PATCH 2/2] phylib: Add support for Marvell 88E1149R devices David Daney
2010-11-19 21:58 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE5956D.5020507@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.