* Re: [oe-commits] Andreas Oberritter : pkgconfig.bbclass: don't blindly install every . pc file
[not found] <E1PJA5d-0001qe-R1@melo.openembedded.org>
@ 2010-11-19 8:46 ` Andrea Adami
2010-11-19 11:51 ` Andreas Oberritter
0 siblings, 1 reply; 3+ messages in thread
From: Andrea Adami @ 2010-11-19 8:46 UTC (permalink / raw)
To: openembedded-devel
Hello, I suspect this commit broke two packages of x11-gpe-image
(do_configure fails, libcontactsdb and libtododb).
http://tinderbox.openembedded.net/packages/994709/
http://tinderbox.openembedded.net/packages/994704/
For the rest, console-image, opie-image and x11-image built just fine.
I'll investigate later today.
Regards
Andrea
On Thu, Nov 18, 2010 at 8:24 PM, git version control
<git@git.openembedded.org> wrote:
> Module: openembedded.git
> Branch: master
> Commit: c2c8fe4c5629add94bd0b922f5b3446624a9f4d8
> URL: http://gitweb.openembedded.net/?p=openembedded.git&a=commit;h=c2c8fe4c5629add94bd0b922f5b3446624a9f4d8
>
> Author: Andreas Oberritter <obi@opendreambox.org>
> Date: Mon Oct 25 04:20:59 2010 +0000
>
> pkgconfig.bbclass: don't blindly install every .pc file
>
> * Instead of installing the file, print a log message. Later,
> this function could be removed.
> * .pc files must be installed explicitly to avoid causing
> build problems. E.g. libsoup-2.4-gnome.pc must not be
> installed if libsoup-2.4 is built without gnome support,
> because gstreamer would try to link against libsoup-2.4-gnome.
> * Fixes for lua5.1 and libid3tag, which install their own .pc
> files from OE, have been submitted.
>
> Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>
> ---
>
> classes/pkgconfig.bbclass | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/classes/pkgconfig.bbclass b/classes/pkgconfig.bbclass
> index 23ab453..d96b708 100644
> --- a/classes/pkgconfig.bbclass
> +++ b/classes/pkgconfig.bbclass
> @@ -16,6 +16,8 @@ pkgconfig_sysroot_preprocess () {
> install -d ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR}
> for pc in `find ${S} -name '*.pc' -type f | grep -v -- '-uninstalled.pc$'`; do
> pcname=`basename $pc`
> - cat $pc > ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR}/$pcname
> + if [ ! -f ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR}/$pcname ]; then
> + oenote "$pcname was not installed."
> + fi
> done
> }
>
>
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits
>
^ permalink raw reply [flat|nested] 3+ messages in thread