Re: [PATCH 08/13] OMAP3: PM: Deny MPU idle while saving secure RAM

[Nishanth Menon <nm@ti.com>]

Santosh Shilimkar had written, on 11/19/2010 11:28 AM, the following:
>> -----Original Message-----
>> From: Nishanth Menon [mailto:nm@ti.com]
>> Sent: Friday, November 19, 2010 10:55 PM
>> To: Santosh Shilimkar
>> Cc: Kevin Hilman; linux-omap; Jean Pihet; Vishwanath Sripathy; Tony
>> Subject: Re: [PATCH 08/13] OMAP3: PM: Deny MPU idle while saving secure
>> RAM
>>
>> Santosh Shilimkar had written, on 11/19/2010 11:18 AM, the following:
>> [..]
>>>> I guess we need some more details on which secure mode calls can
>> trigger
>>>> this problem.  If this is an isolated case, I'm OK with this fix.  If
>>>> it's more general, I'd like to see a more general fix.
>>>>
>>> On the related topic I posted a patch some time back.
>>> http://www.spinics.net/lists/linux-omap/msg37907.html
>>> I guess Kevin is referring to the above patch.
>> I believe the fix we are attempting here is for a specific scenario
>> which IMHO is different from the issue solved in the link above.
> 
> It will also solve the above issue indirectly.
just my dumb brains :) agreed, good one that takes care of the power 
domain, agreed that pwrdm_set_next_pwrst(which is currently present in 
the omap3_save_secure_ram_context) would no longer be necessary - so [1] 
should also have removed that - This specific patch controls the clock 
domain from auto idling around the secure ram save. Apologies on the 
confusion - but if the [1] patch is fixing it, you can help me 
understand how it does it.

[1]http://www.spinics.net/lists/linux-omap/msg37907.html

-- 
Regards,
Nishanth Menon