From: "Cousson, Benoit" <b-cousson@ti.com>
To: "Balbi, Felipe" <balbi@ti.com>
Cc: "Kanigeri, Hari" <h-kanigeri2@ti.com>,
Hiroshi Doyu <Hiroshi.DOYU@nokia.com>,
linux omap <linux-omap@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 2/5] OMAP: mailbox: fix rx interrupt disable in omap4
Date: Mon, 22 Nov 2010 15:57:18 +0100 [thread overview]
Message-ID: <4CEA84CE.5010708@ti.com> (raw)
In-Reply-To: <20101122115153.GE2446@legolas.emea.dhcp.ti.com>
On 11/22/2010 12:51 PM, Felipe Balbi wrote:
> Hi,
>
> On Mon, Nov 22, 2010 at 05:46:53AM -0600, Kanigeri, Hari wrote:
>> > From the dmtimer stuff, it looks like the driver defines the version
>> types, which hwmod uses to define the rev field.
>>
>> /* timer ip constants */
>> #define OMAP_TIMER_IP_LEGACY 0x1
>> #define OMAP_TIMER_IP_VERSION_2 0x2
>
> in that case, it's the same as if you pass in a flag via platform_data.
> You might as well call it rev, then the diff when converting to hwmod
> will be smaller maybe :-p
Yes, this is exactly what I was proposing to Hari.
For the moment create the pdata field that will be populated at init
time using the cpu_is.
During the hwmod migration, the value will be extracted from the hwmod
rev field.
Benoit
WARNING: multiple messages have this Message-ID (diff)
From: b-cousson@ti.com (Cousson, Benoit)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/5] OMAP: mailbox: fix rx interrupt disable in omap4
Date: Mon, 22 Nov 2010 15:57:18 +0100 [thread overview]
Message-ID: <4CEA84CE.5010708@ti.com> (raw)
In-Reply-To: <20101122115153.GE2446@legolas.emea.dhcp.ti.com>
On 11/22/2010 12:51 PM, Felipe Balbi wrote:
> Hi,
>
> On Mon, Nov 22, 2010 at 05:46:53AM -0600, Kanigeri, Hari wrote:
>> > From the dmtimer stuff, it looks like the driver defines the version
>> types, which hwmod uses to define the rev field.
>>
>> /* timer ip constants */
>> #define OMAP_TIMER_IP_LEGACY 0x1
>> #define OMAP_TIMER_IP_VERSION_2 0x2
>
> in that case, it's the same as if you pass in a flag via platform_data.
> You might as well call it rev, then the diff when converting to hwmod
> will be smaller maybe :-p
Yes, this is exactly what I was proposing to Hari.
For the moment create the pdata field that will be populated at init
time using the cpu_is.
During the hwmod migration, the value will be extracted from the hwmod
rev field.
Benoit
next prev parent reply other threads:[~2010-11-22 14:57 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 19:15 [PATCH v3 0/5] OMAP: mailbox: enhancements and fixes Hari Kanigeri
2010-11-18 19:15 ` Hari Kanigeri
2010-11-18 19:15 ` [PATCH v3 1/5] OMAP: mailbox: change full flag per mailbox queue instead of global Hari Kanigeri
2010-11-18 19:15 ` Hari Kanigeri
2010-11-18 23:22 ` Cousson, Benoit
2010-11-18 23:22 ` Cousson, Benoit
2010-11-18 19:15 ` [PATCH v3 2/5] OMAP: mailbox: fix rx interrupt disable in omap4 Hari Kanigeri
2010-11-18 19:15 ` Hari Kanigeri
2010-11-18 23:28 ` Cousson, Benoit
2010-11-18 23:28 ` Cousson, Benoit
2010-11-19 0:07 ` Kanigeri, Hari
2010-11-19 0:07 ` Kanigeri, Hari
2010-11-19 8:32 ` Felipe Balbi
2010-11-19 8:32 ` Felipe Balbi
2010-11-19 14:22 ` Kanigeri, Hari
2010-11-19 14:22 ` Kanigeri, Hari
2010-11-19 14:50 ` Cousson, Benoit
2010-11-19 14:50 ` Cousson, Benoit
2010-11-22 10:08 ` Felipe Balbi
2010-11-22 10:08 ` Felipe Balbi
2010-11-22 11:46 ` Kanigeri, Hari
2010-11-22 11:46 ` Kanigeri, Hari
2010-11-22 11:51 ` Felipe Balbi
2010-11-22 11:51 ` Felipe Balbi
2010-11-22 11:58 ` Kanigeri, Hari
2010-11-22 11:58 ` Kanigeri, Hari
2010-11-22 14:57 ` Cousson, Benoit [this message]
2010-11-22 14:57 ` Cousson, Benoit
2010-11-22 14:55 ` Cousson, Benoit
2010-11-22 14:55 ` Cousson, Benoit
2010-11-23 8:10 ` Felipe Balbi
2010-11-23 8:10 ` Felipe Balbi
2010-11-19 8:32 ` Felipe Balbi
2010-11-19 8:32 ` Felipe Balbi
2010-11-18 19:15 ` [PATCH v3 3/5] OMAP: mailbox: fix checkpatch warnings Hari Kanigeri
2010-11-18 19:15 ` Hari Kanigeri
2010-11-19 8:33 ` Felipe Balbi
2010-11-19 8:33 ` Felipe Balbi
2010-11-19 11:52 ` Kanigeri, Hari
2010-11-19 11:52 ` Kanigeri, Hari
2010-11-18 19:15 ` [PATCH v3 4/5] OMAP: mailbox: send message in process context Hari Kanigeri
2010-11-18 19:15 ` Hari Kanigeri
2010-11-19 8:34 ` Felipe Balbi
2010-11-19 8:34 ` Felipe Balbi
2010-11-18 19:15 ` [PATCH v3 5/5] OMAP: mailbox: add notification support for multiple readers Hari Kanigeri
2010-11-18 19:15 ` Hari Kanigeri
2010-11-19 8:50 ` Felipe Balbi
2010-11-19 8:50 ` Felipe Balbi
2010-11-19 11:50 ` Kanigeri, Hari
2010-11-19 11:50 ` Kanigeri, Hari
2010-11-19 12:09 ` Felipe Balbi
2010-11-19 12:09 ` Felipe Balbi
2010-11-19 12:29 ` Kanigeri, Hari
2010-11-19 12:29 ` Kanigeri, Hari
2010-11-19 12:53 ` Felipe Balbi
2010-11-19 12:53 ` Felipe Balbi
2010-11-19 13:57 ` Kanigeri, Hari
2010-11-19 13:57 ` Kanigeri, Hari
2010-11-19 14:25 ` Felipe Balbi
2010-11-19 14:25 ` Felipe Balbi
2010-11-19 14:44 ` Kanigeri, Hari
2010-11-19 14:44 ` Kanigeri, Hari
2010-11-19 23:07 ` Felipe Balbi
2010-11-19 23:07 ` Felipe Balbi
2010-11-20 4:01 ` Kanigeri, Hari
2010-11-20 4:01 ` Kanigeri, Hari
2010-11-20 11:31 ` Felipe Balbi
2010-11-20 11:31 ` Felipe Balbi
2010-11-20 13:26 ` Kanigeri, Hari
2010-11-20 13:26 ` Kanigeri, Hari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEA84CE.5010708@ti.com \
--to=b-cousson@ti.com \
--cc=Hiroshi.DOYU@nokia.com \
--cc=balbi@ti.com \
--cc=h-kanigeri2@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.