Re: [PATCH -v3 3/3] modem: add support to restore state when resetting the modem

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 892 bytes --]

Hi Gustavo,

On 11/19/2010 03:36 PM, Gustavo F. Padovan wrote:
> ---
>  src/modem.c |   74 ++++++++++++++++++++++++++++++++--------------------------
>  1 files changed, 41 insertions(+), 33 deletions(-)
> 

Ah ok, you implement the getting back to online process in this patch.
Ignore my previous comment.

> diff --git a/src/modem.c b/src/modem.c
> index e57f8fc..704de29 100644
> --- a/src/modem.c
> +++ b/src/modem.c
> @@ -61,6 +61,7 @@ enum modem_state {
>  struct ofono_modem {
>  	char			*path;
>  	enum modem_state	modem_state;
> +	enum modem_state	old_state;

Can we simply use a boolean like 'get_online' that is FALSE by default,
but gets set to TRUE (assuming we're online) during a silent reset?
This can then get re-used for implementing of the Lockdown property as well.

It also seems that the 'reset' value is not really needed.

Regards,
-Denis