From: "Cousson, Benoit" <b-cousson@ti.com>
To: "Varadarajan, Charulatha" <charu@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"khilman@deeprootsystems.com" <khilman@deeprootsystems.com>,
"paul@pwsan.com" <paul@pwsan.com>,
"tony@atomide.com" <tony@atomide.com>,
"Basak, Partha" <p-basak2@ti.com>
Subject: Re: [PATCH v7 09/11] OMAP2+: GPIO: device registration
Date: Thu, 25 Nov 2010 00:00:47 +0100 [thread overview]
Message-ID: <4CED991F.6050701@ti.com> (raw)
In-Reply-To: <1290524213-395-10-git-send-email-charu@ti.com>
On 11/23/2010 3:56 PM, Varadarajan, Charulatha wrote:
> Use omap_device_build() API to do platform_device_register of
> GPIO devices. For OMAP2+ chips, the device specific data defined
> in the centralized hwmod database will be used.
>
> gpio_init needs to be done before machine_init functions access
> gpio APIs. Hence gpio_init is made as a postcore_initcall.
>
> Signed-off-by: Charulatha V<charu@ti.com>
> Reviewed-by: Basak, Partha<p-basak2@ti.com>
Acked-by: Benoit Cousson <b-cousson@ti.com>
> ---
> arch/arm/mach-omap2/gpio.c | 103 ++++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 103 insertions(+), 0 deletions(-)
> create mode 100644 arch/arm/mach-omap2/gpio.c
>
> diff --git a/arch/arm/mach-omap2/gpio.c b/arch/arm/mach-omap2/gpio.c
> new file mode 100644
> index 0000000..e5c9b6a
> --- /dev/null
> +++ b/arch/arm/mach-omap2/gpio.c
> @@ -0,0 +1,104 @@
> +/*
> + * OMAP2+ specific gpio initialization
> + *
> + * Copyright (C) 2010 Texas Instruments Incorporated - http://www.ti.com/
> + *
> + * Author:
> + * Charulatha V<charu@ti.com>
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation version 2.
> + *
> + * This program is distributed "as is" WITHOUT ANY WARRANTY of any
> + * kind, whether express or implied; without even the implied warranty
> + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */
> +
> +#include<linux/gpio.h>
> +#include<linux/err.h>
> +#include<linux/slab.h>
> +#include<linux/interrupt.h>
> +
> +#include<plat/omap_hwmod.h>
> +#include<plat/omap_device.h>
> +
> +static struct omap_device_pm_latency omap_gpio_latency[] = {
> + [0] = {
> + .deactivate_func = omap_device_idle_hwmods,
> + .activate_func = omap_device_enable_hwmods,
> + .flags = OMAP_DEVICE_LATENCY_AUTO_ADJUST,
> + },
> +};
> +
> +static int omap2_gpio_dev_init(struct omap_hwmod *oh, void *unused)
> +{
> + struct omap_device *od;
> + struct omap_gpio_platform_data *pdata;
> + struct omap_gpio_dev_attr *dev_attr;
> + char *name = "omap_gpio";
> + int id;
> +
> + /*
> + * extract the device id from name field available in the
> + * hwmod database and use the same for constructing ids for
> + * gpio devices.
> + * CAUTION: Make sure the name in the hwmod database does
> + * not change. If changed, make corresponding change here
> + * or make use of static variable mechanism to handle this.
> + */
> + sscanf(oh->name, "gpio%d",&id);
> +
> + pdata = kzalloc(sizeof(struct omap_gpio_platform_data), GFP_KERNEL);
> + if (!pdata) {
> + pr_err("gpio%d: Memory allocation failed\n", id);
> + return -ENOMEM;
> + }
> +
> + dev_attr = (struct omap_gpio_dev_attr *)oh->dev_attr;
> + pdata->bank_width = dev_attr->bank_width;
> + pdata->dbck_flag = dev_attr->dbck_flag;
> + pdata->virtual_irq_start = IH_GPIO_BASE + 32 * (id - 1);
> +
> + switch (oh->class->rev) {
> + case 0:
> + case 1:
> + pdata->bank_type = METHOD_GPIO_24XX;
> + break;
> + case 2:
> + pdata->bank_type = METHOD_GPIO_44XX;
> + break;
> + default:
> + WARN(1, "Invalid gpio bank_type\n");
> + kfree(pdata);
> + return -EINVAL;
> + }
> +
> + od = omap_device_build(name, id - 1, oh, pdata,
> + sizeof(*pdata), omap_gpio_latency,
> + ARRAY_SIZE(omap_gpio_latency),
> + false);
> + kfree(pdata);
> +
> + if (IS_ERR(od)) {
> + WARN(1, "Cant build omap_device for %s:%s.\n",
> + name, oh->name);
> + return PTR_ERR(od);
> + }
> +
> + gpio_bank_count++;
> + return 0;
> +}
> +
> +/*
> + * gpio_init needs to be done before
> + * machine_init functions access gpio APIs.
> + * Hence gpio_init is a postcore_initcall.
> + */
> +static int __init omap2_gpio_init(void)
> +{
> + return omap_hwmod_for_each_by_class("gpio", omap2_gpio_dev_init,
> + NULL);
> +}
> +postcore_initcall(omap2_gpio_init);
WARNING: multiple messages have this Message-ID (diff)
From: b-cousson@ti.com (Cousson, Benoit)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 09/11] OMAP2+: GPIO: device registration
Date: Thu, 25 Nov 2010 00:00:47 +0100 [thread overview]
Message-ID: <4CED991F.6050701@ti.com> (raw)
In-Reply-To: <1290524213-395-10-git-send-email-charu@ti.com>
On 11/23/2010 3:56 PM, Varadarajan, Charulatha wrote:
> Use omap_device_build() API to do platform_device_register of
> GPIO devices. For OMAP2+ chips, the device specific data defined
> in the centralized hwmod database will be used.
>
> gpio_init needs to be done before machine_init functions access
> gpio APIs. Hence gpio_init is made as a postcore_initcall.
>
> Signed-off-by: Charulatha V<charu@ti.com>
> Reviewed-by: Basak, Partha<p-basak2@ti.com>
Acked-by: Benoit Cousson <b-cousson@ti.com>
> ---
> arch/arm/mach-omap2/gpio.c | 103 ++++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 103 insertions(+), 0 deletions(-)
> create mode 100644 arch/arm/mach-omap2/gpio.c
>
> diff --git a/arch/arm/mach-omap2/gpio.c b/arch/arm/mach-omap2/gpio.c
> new file mode 100644
> index 0000000..e5c9b6a
> --- /dev/null
> +++ b/arch/arm/mach-omap2/gpio.c
> @@ -0,0 +1,104 @@
> +/*
> + * OMAP2+ specific gpio initialization
> + *
> + * Copyright (C) 2010 Texas Instruments Incorporated - http://www.ti.com/
> + *
> + * Author:
> + * Charulatha V<charu@ti.com>
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation version 2.
> + *
> + * This program is distributed "as is" WITHOUT ANY WARRANTY of any
> + * kind, whether express or implied; without even the implied warranty
> + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */
> +
> +#include<linux/gpio.h>
> +#include<linux/err.h>
> +#include<linux/slab.h>
> +#include<linux/interrupt.h>
> +
> +#include<plat/omap_hwmod.h>
> +#include<plat/omap_device.h>
> +
> +static struct omap_device_pm_latency omap_gpio_latency[] = {
> + [0] = {
> + .deactivate_func = omap_device_idle_hwmods,
> + .activate_func = omap_device_enable_hwmods,
> + .flags = OMAP_DEVICE_LATENCY_AUTO_ADJUST,
> + },
> +};
> +
> +static int omap2_gpio_dev_init(struct omap_hwmod *oh, void *unused)
> +{
> + struct omap_device *od;
> + struct omap_gpio_platform_data *pdata;
> + struct omap_gpio_dev_attr *dev_attr;
> + char *name = "omap_gpio";
> + int id;
> +
> + /*
> + * extract the device id from name field available in the
> + * hwmod database and use the same for constructing ids for
> + * gpio devices.
> + * CAUTION: Make sure the name in the hwmod database does
> + * not change. If changed, make corresponding change here
> + * or make use of static variable mechanism to handle this.
> + */
> + sscanf(oh->name, "gpio%d",&id);
> +
> + pdata = kzalloc(sizeof(struct omap_gpio_platform_data), GFP_KERNEL);
> + if (!pdata) {
> + pr_err("gpio%d: Memory allocation failed\n", id);
> + return -ENOMEM;
> + }
> +
> + dev_attr = (struct omap_gpio_dev_attr *)oh->dev_attr;
> + pdata->bank_width = dev_attr->bank_width;
> + pdata->dbck_flag = dev_attr->dbck_flag;
> + pdata->virtual_irq_start = IH_GPIO_BASE + 32 * (id - 1);
> +
> + switch (oh->class->rev) {
> + case 0:
> + case 1:
> + pdata->bank_type = METHOD_GPIO_24XX;
> + break;
> + case 2:
> + pdata->bank_type = METHOD_GPIO_44XX;
> + break;
> + default:
> + WARN(1, "Invalid gpio bank_type\n");
> + kfree(pdata);
> + return -EINVAL;
> + }
> +
> + od = omap_device_build(name, id - 1, oh, pdata,
> + sizeof(*pdata), omap_gpio_latency,
> + ARRAY_SIZE(omap_gpio_latency),
> + false);
> + kfree(pdata);
> +
> + if (IS_ERR(od)) {
> + WARN(1, "Cant build omap_device for %s:%s.\n",
> + name, oh->name);
> + return PTR_ERR(od);
> + }
> +
> + gpio_bank_count++;
> + return 0;
> +}
> +
> +/*
> + * gpio_init needs to be done before
> + * machine_init functions access gpio APIs.
> + * Hence gpio_init is a postcore_initcall.
> + */
> +static int __init omap2_gpio_init(void)
> +{
> + return omap_hwmod_for_each_by_class("gpio", omap2_gpio_dev_init,
> + NULL);
> +}
> +postcore_initcall(omap2_gpio_init);
next prev parent reply other threads:[~2010-11-24 23:00 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 14:56 [PATCH v7 00/11] OMAP: GPIO: Implement GPIO as a platform device Varadarajan, Charulatha
2010-11-23 14:56 ` Varadarajan, Charulatha
2010-11-23 14:56 ` [PATCH v7 01/11] OMAP: GPIO: prepare for platform driver Varadarajan, Charulatha
2010-11-23 14:56 ` Varadarajan, Charulatha
2010-11-26 4:38 ` Olof Johansson
2010-11-26 4:38 ` Olof Johansson
2010-11-26 5:03 ` Varadarajan, Charulatha
2010-11-26 5:03 ` Varadarajan, Charulatha
2010-11-26 6:47 ` [Query]McSPI testing help on N800 Datta, Shubhrajyoti
2010-11-28 20:15 ` Paul Walmsley
2010-11-23 14:56 ` [PATCH v7 02/11] OMAP15xx: GPIO: Introduce support for GPIO init Varadarajan, Charulatha
2010-11-23 14:56 ` Varadarajan, Charulatha
2010-11-23 14:56 ` [PATCH v7 03/11] OMAP16xx: " Varadarajan, Charulatha
2010-11-23 14:56 ` Varadarajan, Charulatha
2010-11-23 14:56 ` [PATCH v7 04/11] OMAP7xx: " Varadarajan, Charulatha
2010-11-23 14:56 ` Varadarajan, Charulatha
2010-11-23 14:56 ` [PATCH v7 05/11] OMAP2420: hwmod data: Add GPIO Varadarajan, Charulatha
2010-11-23 14:56 ` Varadarajan, Charulatha
2010-11-24 22:13 ` Cousson, Benoit
2010-11-24 22:13 ` Cousson, Benoit
2010-11-25 4:36 ` Varadarajan, Charulatha
2010-11-25 4:36 ` Varadarajan, Charulatha
2010-11-25 7:55 ` Cousson, Benoit
2010-11-25 7:55 ` Cousson, Benoit
2010-11-25 8:02 ` Cousson, Benoit
2010-11-25 8:02 ` Cousson, Benoit
2010-11-25 8:31 ` Varadarajan, Charulatha
2010-11-25 8:31 ` Varadarajan, Charulatha
2010-11-25 9:33 ` Varadarajan, Charulatha
2010-11-25 9:33 ` Varadarajan, Charulatha
2010-11-23 14:56 ` [PATCH v7 06/11] OMAP2430: " Varadarajan, Charulatha
2010-11-23 14:56 ` Varadarajan, Charulatha
2010-11-24 22:42 ` Cousson, Benoit
2010-11-24 22:42 ` Cousson, Benoit
2010-11-23 14:56 ` [PATCH v7 07/11] OMAP3: " Varadarajan, Charulatha
2010-11-23 14:56 ` Varadarajan, Charulatha
2010-11-24 22:51 ` Cousson, Benoit
2010-11-24 22:51 ` Cousson, Benoit
2010-11-25 4:37 ` Varadarajan, Charulatha
2010-11-25 4:37 ` Varadarajan, Charulatha
2010-11-23 14:56 ` [PATCH v7 08/11] OMAP4: " Varadarajan, Charulatha
2010-11-23 14:56 ` Varadarajan, Charulatha
2010-11-23 14:56 ` [PATCH v7 09/11] OMAP2+: GPIO: device registration Varadarajan, Charulatha
2010-11-23 14:56 ` Varadarajan, Charulatha
2010-11-24 23:00 ` Cousson, Benoit [this message]
2010-11-24 23:00 ` Cousson, Benoit
2010-11-23 14:56 ` [PATCH v7 10/11] OMAP: GPIO: Implement GPIO as a platform device Varadarajan, Charulatha
2010-11-23 14:56 ` Varadarajan, Charulatha
2010-11-23 14:56 ` [PATCH v7 11/11] OMAP: GPIO: Remove omap_gpio_init() Varadarajan, Charulatha
2010-11-23 14:56 ` Varadarajan, Charulatha
2010-11-24 23:28 ` Tony Lindgren
2010-11-24 23:28 ` Tony Lindgren
2010-11-24 20:58 ` [PATCH v7 00/11] OMAP: GPIO: Implement GPIO as a platform device Cousson, Benoit
2010-11-25 4:27 ` Varadarajan, Charulatha
2010-11-25 1:40 ` Kevin Hilman
2010-11-25 1:40 ` Kevin Hilman
2010-11-25 4:31 ` Varadarajan, Charulatha
2010-11-25 4:31 ` Varadarajan, Charulatha
2010-11-25 6:19 ` Kevin Hilman
2010-11-25 6:19 ` Kevin Hilman
2010-11-25 6:20 ` Varadarajan, Charulatha
2010-11-25 6:20 ` Varadarajan, Charulatha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CED991F.6050701@ti.com \
--to=b-cousson@ti.com \
--cc=charu@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=p-basak2@ti.com \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.