From: Li Zefan <lizf@cn.fujitsu.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Christoph Lameter <cl@linux-foundation.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Matt Mackall <mpm@selenic.com>,
linux-mm@kvack.org,
Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
Richard Kennedy <richard@rsk.demon.co.uk>
Subject: Re: [RFC][PATCH 2/2] [PATCH 2/2] tracing/slub: Move kmalloc tracepoint out of inline code
Date: Thu, 25 Nov 2010 09:00:46 +0800 [thread overview]
Message-ID: <4CEDB53E.5000203@cn.fujitsu.com> (raw)
In-Reply-To: <20101124212717.468748477@goodmis.org>
Cc: Richard Kennedy <richard@rsk.demon.co.uk>
Steven Rostedt wrote:
> From: Steven Rostedt <srostedt@redhat.com>
>
> The tracepoint for kmalloc is in the slub inlined code which causes
> every instance of kmalloc to have the tracepoint.
>
> This patch moves the tracepoint out of the inline code to the
> slub C file (and to page_alloc), which removes a large number of
> inlined trace points.
>
> objdump -dr vmlinux.slub| grep 'jmpq.*<trace_kmalloc' |wc -l
> 375
> objdump -dr vmlinux.slub.patched| grep 'jmpq.*<trace_kmalloc' |wc -l
> 2
>
> This also has a nice impact on size.
> text data bss dec hex filename
> 7050424 1961068 2482688 11494180 af6324 vmlinux.slub
> 6979599 1944620 2482688 11406907 ae0e3b vmlinux.slub.patched
>
> Siged-off-by: Steven Rostedt <rostedt@goodmis.org>
See this patch from Richard: :)
http://marc.info/?l=linux-kernel&m=128765337729262&w=2
But he only touched slub.
WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizf@cn.fujitsu.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Christoph Lameter <cl@linux-foundation.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Matt Mackall <mpm@selenic.com>,
linux-mm@kvack.org,
Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
Richard Kennedy <richard@rsk.demon.co.uk>
Subject: Re: [RFC][PATCH 2/2] [PATCH 2/2] tracing/slub: Move kmalloc tracepoint out of inline code
Date: Thu, 25 Nov 2010 09:00:46 +0800 [thread overview]
Message-ID: <4CEDB53E.5000203@cn.fujitsu.com> (raw)
In-Reply-To: <20101124212717.468748477@goodmis.org>
Cc: Richard Kennedy <richard@rsk.demon.co.uk>
Steven Rostedt wrote:
> From: Steven Rostedt <srostedt@redhat.com>
>
> The tracepoint for kmalloc is in the slub inlined code which causes
> every instance of kmalloc to have the tracepoint.
>
> This patch moves the tracepoint out of the inline code to the
> slub C file (and to page_alloc), which removes a large number of
> inlined trace points.
>
> objdump -dr vmlinux.slub| grep 'jmpq.*<trace_kmalloc' |wc -l
> 375
> objdump -dr vmlinux.slub.patched| grep 'jmpq.*<trace_kmalloc' |wc -l
> 2
>
> This also has a nice impact on size.
> text data bss dec hex filename
> 7050424 1961068 2482688 11494180 af6324 vmlinux.slub
> 6979599 1944620 2482688 11406907 ae0e3b vmlinux.slub.patched
>
> Siged-off-by: Steven Rostedt <rostedt@goodmis.org>
See this patch from Richard: :)
http://marc.info/?l=linux-kernel&m=128765337729262&w=2
But he only touched slub.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-11-25 1:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 21:23 [RFC][PATCH 0/2] Move kmalloc tracepoints out of inlined code Steven Rostedt
2010-11-24 21:23 ` Steven Rostedt
2010-11-24 21:23 ` [RFC][PATCH 1/2] [PATCH 1/2] tracing/slab: Move kmalloc tracepoint out of inline code Steven Rostedt
2010-11-24 21:23 ` Steven Rostedt
2010-11-24 21:23 ` [RFC][PATCH 2/2] [PATCH 2/2] tracing/slub: " Steven Rostedt
2010-11-24 21:23 ` Steven Rostedt
2010-11-25 1:00 ` Li Zefan [this message]
2010-11-25 1:00 ` Li Zefan
2010-11-25 1:17 ` Steven Rostedt
2010-11-25 1:17 ` Steven Rostedt
2010-11-25 6:46 ` Pekka Enberg
2010-11-25 6:46 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEDB53E.5000203@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=eduard.munteanu@linux360.ro \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
--cc=peterz@infradead.org \
--cc=richard@rsk.demon.co.uk \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.