* [PATCH] workqueue: check the allocation of system_unbound_wq
@ 2010-11-26 2:19 Hitoshi Mitake
2010-11-26 11:07 ` Tejun Heo
0 siblings, 1 reply; 3+ messages in thread
From: Hitoshi Mitake @ 2010-11-26 2:19 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-kernel, mitake, h.mitake, Arjan van de Ven, David Howells
I found a trivial bug on initialization of workqueue.
Current init_workqueues doesn't check the result of
allocation of system_unbound_wq, this should be checked
like other queues.
Signed-off-by: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: David Howells <dhowells@redhat.com>
---
kernel/workqueue.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 90db1bd..b60374d 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -3692,7 +3692,8 @@ static int __init init_workqueues(void)
system_nrt_wq = alloc_workqueue("events_nrt", WQ_NON_REENTRANT, 0);
system_unbound_wq = alloc_workqueue("events_unbound", WQ_UNBOUND,
WQ_UNBOUND_MAX_ACTIVE);
- BUG_ON(!system_wq || !system_long_wq || !system_nrt_wq);
+ BUG_ON(!system_wq || !system_long_wq ||
+ !system_nrt_wq || !system_unbound_wq);
return 0;
}
early_initcall(init_workqueues);
--
1.6.5.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] workqueue: check the allocation of system_unbound_wq
2010-11-26 2:19 [PATCH] workqueue: check the allocation of system_unbound_wq Hitoshi Mitake
@ 2010-11-26 11:07 ` Tejun Heo
2010-11-29 13:32 ` Hitoshi Mitake
0 siblings, 1 reply; 3+ messages in thread
From: Tejun Heo @ 2010-11-26 11:07 UTC (permalink / raw)
To: Hitoshi Mitake; +Cc: linux-kernel, h.mitake, Arjan van de Ven, David Howells
Hello,
On 11/26/2010 03:19 AM, Hitoshi Mitake wrote:
> I found a trivial bug on initialization of workqueue.
> Current init_workqueues doesn't check the result of
> allocation of system_unbound_wq, this should be checked
> like other queues.
>
> Signed-off-by: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
> Cc: Arjan van de Ven <arjan@linux.intel.com>
> Cc: David Howells <dhowells@redhat.com>
Queued to wq#for-linus with new line adjustment.
Thanks a lot. :-)
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] workqueue: check the allocation of system_unbound_wq
2010-11-26 11:07 ` Tejun Heo
@ 2010-11-29 13:32 ` Hitoshi Mitake
0 siblings, 0 replies; 3+ messages in thread
From: Hitoshi Mitake @ 2010-11-29 13:32 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-kernel, h.mitake, Arjan van de Ven, David Howells
On 2010年11月26日 20:07, Tejun Heo wrote:
> Hello,
>
> On 11/26/2010 03:19 AM, Hitoshi Mitake wrote:
>> I found a trivial bug on initialization of workqueue.
>> Current init_workqueues doesn't check the result of
>> allocation of system_unbound_wq, this should be checked
>> like other queues.
>>
>> Signed-off-by: Hitoshi Mitake<mitake@dcl.info.waseda.ac.jp>
>> Cc: Arjan van de Ven<arjan@linux.intel.com>
>> Cc: David Howells<dhowells@redhat.com>
>
> Queued to wq#for-linus with new line adjustment.
>
> Thanks a lot. :-)
>
Hi Tejun,
Thanks for your adjustment and applying :)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-29 13:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-26 2:19 [PATCH] workqueue: check the allocation of system_unbound_wq Hitoshi Mitake
2010-11-26 11:07 ` Tejun Heo
2010-11-29 13:32 ` Hitoshi Mitake
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.