* [PATCH] call-volume: Fix dbus error message type
@ 2010-11-26 14:59 Jeevaka Badrappan
2010-11-26 19:44 ` Denis Kenzior
0 siblings, 1 reply; 2+ messages in thread
From: Jeevaka Badrappan @ 2010-11-26 14:59 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 1343 bytes --]
---
src/call-volume.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/call-volume.c b/src/call-volume.c
index dd1be92..3c172ce 100644
--- a/src/call-volume.c
+++ b/src/call-volume.c
@@ -238,7 +238,7 @@ static DBusMessage *cv_set_property(DBusConnection *conn, DBusMessage *msg,
unsigned char percent;
if (!cv->driver->speaker_volume)
- return __ofono_error_not_supported(msg);
+ return __ofono_error_not_implemented(msg);
if (dbus_message_iter_get_arg_type(&var) != DBUS_TYPE_BYTE)
return __ofono_error_invalid_args(msg);
@@ -260,7 +260,7 @@ static DBusMessage *cv_set_property(DBusConnection *conn, DBusMessage *msg,
unsigned char percent;
if (!cv->driver->microphone_volume)
- return __ofono_error_not_supported(msg);
+ return __ofono_error_not_implemented(msg);
if (dbus_message_iter_get_arg_type(&var) != DBUS_TYPE_BYTE)
return __ofono_error_invalid_args(msg);
@@ -282,7 +282,7 @@ static DBusMessage *cv_set_property(DBusConnection *conn, DBusMessage *msg,
dbus_bool_t muted;
if (!cv->driver->mute)
- return __ofono_error_not_supported(msg);
+ return __ofono_error_not_implemented(msg);
if (dbus_message_iter_get_arg_type(&var) != DBUS_TYPE_BOOLEAN)
return __ofono_error_invalid_args(msg);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] call-volume: Fix dbus error message type
2010-11-26 14:59 [PATCH] call-volume: Fix dbus error message type Jeevaka Badrappan
@ 2010-11-26 19:44 ` Denis Kenzior
0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2010-11-26 19:44 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 220 bytes --]
Hi Jeevaka,
On 11/26/2010 08:59 AM, Jeevaka Badrappan wrote:
> ---
> src/call-volume.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
Patch has been applied, thanks.
Regards,
-Denis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-26 19:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-26 14:59 [PATCH] call-volume: Fix dbus error message type Jeevaka Badrappan
2010-11-26 19:44 ` Denis Kenzior
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.