doc: cdma-voicecall-manager-api.txt

doc: cdma-voicecall-manager-api.txt

[ext-arun.1.ravindran]

[-- Attachment #1: Type: text/plain, Size: 2330 bytes --]


Hi,

The CDMA voice call manager interface is missing the line identification and start time property.
The MO and MT calls will have LineIdentification, which should be set to empty when the call loses the LineIdentification. We will emit the property change whenever there is a flash sent.

Example cases:
1) Outgoing call to number "123"
    LineIdentification  = "123"
2) Incoming Call from Number "234"
    LineIdentification = "234"
3) a) Outgoing call to number "123"
    LineIdentification  = "123"
   b) Flash to number "345"
    LineIdentification  = ""
4) a) Incoming call from number "234"
    LineIdentification  = "234"
   b) Flash to number "345"
    LineIdentification  = ""
5) a) Outgoing call to number "123"
    LineIdentification  = "123"
   b) Flash with empty string
    LineIdentification  = ""
6) a) Incoming call from number "123"
    LineIdentification  = "123"
   b) Flash with empty string
    LineIdentification  = ""

Similarly for StartTime, for a normal outgoing and Incoming call, we have StartTime values. But the issue is with Flash with String, where we cannot have the Call start time for the number which is sent as flash string. 
If a UI needs to show the call time for the flashed number, it cannot be decided by oFono.

Example cases:
1) Outgoing call to number "123"
    StartTime  = xxxxx
2) Incoming call from number "123"
    StartTime  = xxxxx
3) a) Outgoing call to number "123"
    StartTime  = xxxxx
   b) Flash to number "234"
    No separate StartTime for "234" , and no property change emitted.
4) a) Incoming call from number "123"
    StartTime  = xxxxx
   b)  Flash to number "234"
    No separate StartTime for "234"  and no property change emitted.

We also need a SetProperty() API.

void SetProperty(string property, variant value)

                         Changes the value of the specified property. Only
                         properties that are listed as readwrite are
                         changeable. On success a PropertyChanged signal
                         will be emitted.

                         Possible Errors: [service].Error.InvalidArguments
                                          [service].Error.DoesNotExist

The following patch adds the above changes to document.

Regards
Arun

[PATCH] doc: cdma-voicecall-manager-api.txt

[ext-arun.1.ravindran]

[-- Attachment #1: Type: text/plain, Size: 1860 bytes --]

From: Arun Ravindran <ext-arun.1.ravindran@nokia.com>

---
 doc/cdma-voicecall-manager-api.txt |   30 ++++++++++++++++++++++++++++++
 1 files changed, 30 insertions(+), 0 deletions(-)

diff --git a/doc/cdma-voicecall-manager-api.txt b/doc/cdma-voicecall-manager-api.txt
index b457af7..958402f 100644
--- a/doc/cdma-voicecall-manager-api.txt
+++ b/doc/cdma-voicecall-manager-api.txt
@@ -35,6 +35,16 @@ Methods		dict GetProperties()
 			'*', '#', 'A', 'B', 'C', 'D'.  The last four are
 			typically not used in normal circumstances.
 
+		void SetProperty(string property, variant value)
+
+			Changes the value of the specified property. Only
+			properties that are listed as readwrite are
+			changeable. On success a PropertyChanged signal
+			will be emitted.
+
+			Possible Errors: [service].Error.InvalidArguments
+					 [service].Error.DoesNotExist
+
 Signals		PropertyChanged(string property, variant value)
 
 			Signal is emitted whenever a property has changed.
@@ -81,3 +91,23 @@ Properties	string State [readonly]
 			currently supported values are:
 				"short",
 				"long"
+
+		string LineIdentification [readonly]
+
+			Contains the Line Identification information returned
+			by the network, if present. For incoming calls this is
+			effectively the CLIP. For outgoing calls this attribute
+			will hold the dialed number.
+
+			Please note that after sending flash this property
+			will be empty.
+
+		string StartTime [readonly, optional]
+
+			Contains the starting time of the call.  The time is
+			stamped when the call enters the "active" state.
+			Client applications can use this to infer somewhat
+			reliable call duration information.
+
+			Please note that after sending Flash, there will not be
+			any StartTime property change for the Flash string/number.
-- 
1.7.0.4

Re: [PATCH] doc: cdma-voicecall-manager-api.txt

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]

Hi Arun,

On 11/26/2010 03:54 AM, ext-arun.1.ravindran(a)nokia.com wrote:
> From: Arun Ravindran <ext-arun.1.ravindran@nokia.com>
> 
> ---
>  doc/cdma-voicecall-manager-api.txt |   30 ++++++++++++++++++++++++++++++
>  1 files changed, 30 insertions(+), 0 deletions(-)
> 

Seems reasonable to me.  Patch has been applied, thanks.

Regards,
-Denis