From: Rik van Riel <riel@redhat.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Ben Gamari <bgamari.foss@gmail.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Nick Piggin <npiggin@kernel.dk>, Mel Gorman <mel@csn.ul.ie>,
Wu Fengguang <fengguang.wu@intel.com>
Subject: Re: [PATCH v2 3/3] Prevent promotion of page in madvise_dontneed
Date: Sun, 28 Nov 2010 23:28:05 -0500 [thread overview]
Message-ID: <4CF32BD5.8050006@redhat.com> (raw)
In-Reply-To: <48315b5fe54efa08982aa7df77e8abe793889e3a.1290956059.git.minchan.kim@gmail.com>
On 11/28/2010 10:02 AM, Minchan Kim wrote:
> Now zap_pte_range alwayas promotes pages which are pte_young&&
> !VM_SequentialReadHint(vma). But in case of calling MADV_DONTNEED,
> it's unnecessary since the page wouldn't use any more.
>
> If the page is sharred by other processes and it's real working set
This line seems to be superfluous, I don't see any special
treatment for this case in the code.
> Signed-off-by: Minchan Kim<minchan.kim@gmail.com>
> Cc: Rik van Riel<riel@redhat.com>
> Cc: KOSAKI Motohiro<kosaki.motohiro@jp.fujitsu.com>
> Cc: Johannes Weiner<hannes@cmpxchg.org>
> Cc: Nick Piggin<npiggin@kernel.dk>
> Cc: Mel Gorman<mel@csn.ul.ie>
> Cc: Wu Fengguang<fengguang.wu@intel.com>
The patch itself looks good to me.
Acked-by: Rik van Riel <riel@redhat.com>
--
All rights reversed
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Ben Gamari <bgamari.foss@gmail.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Nick Piggin <npiggin@kernel.dk>, Mel Gorman <mel@csn.ul.ie>,
Wu Fengguang <fengguang.wu@intel.com>
Subject: Re: [PATCH v2 3/3] Prevent promotion of page in madvise_dontneed
Date: Sun, 28 Nov 2010 23:28:05 -0500 [thread overview]
Message-ID: <4CF32BD5.8050006@redhat.com> (raw)
In-Reply-To: <48315b5fe54efa08982aa7df77e8abe793889e3a.1290956059.git.minchan.kim@gmail.com>
On 11/28/2010 10:02 AM, Minchan Kim wrote:
> Now zap_pte_range alwayas promotes pages which are pte_young&&
> !VM_SequentialReadHint(vma). But in case of calling MADV_DONTNEED,
> it's unnecessary since the page wouldn't use any more.
>
> If the page is sharred by other processes and it's real working set
This line seems to be superfluous, I don't see any special
treatment for this case in the code.
> Signed-off-by: Minchan Kim<minchan.kim@gmail.com>
> Cc: Rik van Riel<riel@redhat.com>
> Cc: KOSAKI Motohiro<kosaki.motohiro@jp.fujitsu.com>
> Cc: Johannes Weiner<hannes@cmpxchg.org>
> Cc: Nick Piggin<npiggin@kernel.dk>
> Cc: Mel Gorman<mel@csn.ul.ie>
> Cc: Wu Fengguang<fengguang.wu@intel.com>
The patch itself looks good to me.
Acked-by: Rik van Riel <riel@redhat.com>
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-11-29 4:28 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-28 15:02 [PATCH v2 1/3] deactivate invalidated pages Minchan Kim
2010-11-28 15:02 ` Minchan Kim
2010-11-28 15:02 ` [PATCH v2 2/3] move ClearPageReclaim Minchan Kim
2010-11-28 15:02 ` Minchan Kim
2010-11-29 4:25 ` Rik van Riel
2010-11-29 4:25 ` Rik van Riel
2010-11-29 7:29 ` Wu Fengguang
2010-11-29 7:29 ` Wu Fengguang
2010-11-29 8:16 ` Minchan Kim
2010-11-29 8:16 ` Minchan Kim
2010-11-29 8:26 ` Wu Fengguang
2010-11-29 8:26 ` Wu Fengguang
2010-11-28 15:02 ` [PATCH v2 3/3] Prevent promotion of page in madvise_dontneed Minchan Kim
2010-11-28 15:02 ` Minchan Kim
2010-11-29 4:28 ` Rik van Riel [this message]
2010-11-29 4:28 ` Rik van Riel
2010-11-29 4:30 ` Minchan Kim
2010-11-29 4:30 ` Minchan Kim
2010-11-28 15:13 ` [PATCH v2 1/3] deactivate invalidated pages Minchan Kim
2010-11-28 15:13 ` Minchan Kim
2010-11-28 19:02 ` Rik van Riel
2010-11-28 19:02 ` Rik van Riel
2010-11-29 0:33 ` KOSAKI Motohiro
2010-11-29 0:33 ` KOSAKI Motohiro
2010-11-29 1:58 ` Ben Gamari
2010-11-29 1:58 ` Ben Gamari
2010-11-29 2:13 ` KOSAKI Motohiro
2010-11-29 2:13 ` KOSAKI Motohiro
2010-11-29 2:26 ` Ben Gamari
2010-11-29 2:26 ` Ben Gamari
2010-11-29 2:13 ` Minchan Kim
2010-11-29 2:13 ` Minchan Kim
2010-11-29 2:35 ` KOSAKI Motohiro
2010-11-29 2:35 ` KOSAKI Motohiro
2010-11-29 7:49 ` Wu Fengguang
2010-11-29 7:49 ` Wu Fengguang
2010-11-29 8:09 ` Minchan Kim
2010-11-29 8:09 ` Minchan Kim
2010-11-29 12:07 ` Mel Gorman
2010-11-29 12:07 ` Mel Gorman
2010-11-29 15:28 ` Minchan Kim
2010-11-29 15:28 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF32BD5.8050006@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bgamari.foss@gmail.com \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=npiggin@kernel.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.