[PATCH] module-init-tools: fix multiple runtime providers

[PATCH] module-init-tools: fix multiple runtime providers

[Martin Jansa]

* NOTE: multiple providers are available for runtime module-init-tools-depmod (module-init-tools, module-init-tools-cross)
  NOTE: consider defining a PREFERRED_PROVIDER entry to match module-init-tools-depmod
---
 recipes/module-init-tools/module-init-tools.inc |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/recipes/module-init-tools/module-init-tools.inc b/recipes/module-init-tools/module-init-tools.inc
index 3cfaf11..247b39a 100644
--- a/recipes/module-init-tools/module-init-tools.inc
+++ b/recipes/module-init-tools/module-init-tools.inc
@@ -3,13 +3,13 @@ removing kernel modules for Linux (versions 2.5.48 and above). It serves \
 the same function that the modutils package serves for Linux 2.4."
 LICENSE = "GPLv2"
 SECTION = "base"
-PR = "r5"
+PR = "r6"
 
-PACKAGES =+ "module-init-tools-insmod-static module-init-tools-depmod"
-RDEPENDS_${PN} += "module-init-tools-depmod"
+PACKAGES =+ "${PN}-insmod-static ${PN}-depmod"
+RDEPENDS_${PN} += "${PN}-depmod"
 
-FILES_module-init-tools-depmod = "${sbindir}/depmod.26"
-FILES_module-init-tools-insmod-static = "${sbindir}/insmod.static"
+FILES_${PN}-depmod = "${sbindir}/depmod.26"
+FILES_${PN}-insmod-static = "${sbindir}/insmod.static"
 
 SRC_URI = "${KERNELORG_MIRROR}/pub/linux/utils/kernel/module-init-tools/module-init-tools-${PV}.tar.bz2 \
 	   file://ignore_arch_directory;apply=yes \
-- 
1.7.3.2

Re: [PATCH] module-init-tools: fix multiple runtime providers

[Frans Meulenbroeks]

2010/12/1 Martin Jansa <martin.jansa@gmail.com>:
> * NOTE: multiple providers are available for runtime module-init-tools-depmod (module-init-tools, module-init-tools-cross)
>  NOTE: consider defining a PREFERRED_PROVIDER entry to match module-init-tools-depmod
> ---
>  recipes/module-init-tools/module-init-tools.inc |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/recipes/module-init-tools/module-init-tools.inc b/recipes/module-init-tools/module-init-tools.inc
> index 3cfaf11..247b39a 100644
> --- a/recipes/module-init-tools/module-init-tools.inc
> +++ b/recipes/module-init-tools/module-init-tools.inc
> @@ -3,13 +3,13 @@ removing kernel modules for Linux (versions 2.5.48 and above). It serves \
>  the same function that the modutils package serves for Linux 2.4."
>  LICENSE = "GPLv2"
>  SECTION = "base"
> -PR = "r5"
> +PR = "r6"
>
> -PACKAGES =+ "module-init-tools-insmod-static module-init-tools-depmod"
> -RDEPENDS_${PN} += "module-init-tools-depmod"
> +PACKAGES =+ "${PN}-insmod-static ${PN}-depmod"
> +RDEPENDS_${PN} += "${PN}-depmod"
>
> -FILES_module-init-tools-depmod = "${sbindir}/depmod.26"
> -FILES_module-init-tools-insmod-static = "${sbindir}/insmod.static"
> +FILES_${PN}-depmod = "${sbindir}/depmod.26"
> +FILES_${PN}-insmod-static = "${sbindir}/insmod.static"
>
>  SRC_URI = "${KERNELORG_MIRROR}/pub/linux/utils/kernel/module-init-tools/module-init-tools-${PV}.tar.bz2 \
>           file://ignore_arch_directory;apply=yes \
> --

Thanks for the patch!
Acked-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>

still not really sure why we have module-init-tools-cross though.
A quick search did not give me a user (but maybe the search was too quick)
And still unsure why a cross recipe should produce a  package.
And maybe it should be module-init-tools-native ?

Frans (puzzled)

Re: [PATCH] module-init-tools: fix multiple runtime providers

[Tom Rini]

On 12/01/2010 07:11 AM, Frans Meulenbroeks wrote:
> 2010/12/1 Martin Jansa<martin.jansa@gmail.com>:
>> * NOTE: multiple providers are available for runtime module-init-tools-depmod (module-init-tools, module-init-tools-cross)
>>   NOTE: consider defining a PREFERRED_PROVIDER entry to match module-init-tools-depmod
>> ---
>>   recipes/module-init-tools/module-init-tools.inc |   10 +++++-----
>>   1 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/recipes/module-init-tools/module-init-tools.inc b/recipes/module-init-tools/module-init-tools.inc
>> index 3cfaf11..247b39a 100644
>> --- a/recipes/module-init-tools/module-init-tools.inc
>> +++ b/recipes/module-init-tools/module-init-tools.inc
>> @@ -3,13 +3,13 @@ removing kernel modules for Linux (versions 2.5.48 and above). It serves \
>>   the same function that the modutils package serves for Linux 2.4."
>>   LICENSE = "GPLv2"
>>   SECTION = "base"
>> -PR = "r5"
>> +PR = "r6"
>>
>> -PACKAGES =+ "module-init-tools-insmod-static module-init-tools-depmod"
>> -RDEPENDS_${PN} += "module-init-tools-depmod"
>> +PACKAGES =+ "${PN}-insmod-static ${PN}-depmod"
>> +RDEPENDS_${PN} += "${PN}-depmod"
>>
>> -FILES_module-init-tools-depmod = "${sbindir}/depmod.26"
>> -FILES_module-init-tools-insmod-static = "${sbindir}/insmod.static"
>> +FILES_${PN}-depmod = "${sbindir}/depmod.26"
>> +FILES_${PN}-insmod-static = "${sbindir}/insmod.static"
>>
>>   SRC_URI = "${KERNELORG_MIRROR}/pub/linux/utils/kernel/module-init-tools/module-init-tools-${PV}.tar.bz2 \
>>            file://ignore_arch_directory;apply=yes \
>> --
>
> Thanks for the patch!
> Acked-by: Frans Meulenbroeks<fransmeulenbroeks@gmail.com>
>
> still not really sure why we have module-init-tools-cross though.
> A quick search did not give me a user (but maybe the search was too quick)
> And still unsure why a cross recipe should produce a  package.
> And maybe it should be module-init-tools-native ?

It's used for running depmod on images during creation, iirc.

-- 
Tom Rini
Mentor Graphics Corporation

Re: [PATCH] module-init-tools: fix multiple runtime providers

[Frans Meulenbroeks]

2010/12/1 Tom Rini <tom_rini@mentor.com>:
> On 12/01/2010 07:11 AM, Frans Meulenbroeks wrote:
>>

>> still not really sure why we have module-init-tools-cross though.
>> A quick search did not give me a user (but maybe the search was too quick)
>> And still unsure why a cross recipe should produce a  package.
>> And maybe it should be module-init-tools-native ?
>
> It's used for running depmod on images during creation, iirc.

Do these produce packages (apart from packaged staging).
I would expect it to install its stuff in cross or sysroots or so and be done.

Frans