From: Gerd Hoffmann <kraxel@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Paul Brook <paul@codesourcery.com>,
qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: [Qemu-devel] Re: [patch 2/3] support for UHCI suspend / remote wake up
Date: Wed, 01 Dec 2010 18:12:57 +0100 [thread overview]
Message-ID: <4CF68219.8030302@redhat.com> (raw)
In-Reply-To: <20101201164743.038562673@redhat.com>
Hi,
> port->ctrl = (port->ctrl& 0x01fb) | (val& ~0x01fb);
> /* some bits are reset when a '1' is written to them */
> port->ctrl&= ~(val& 0x000a);
> + port->ctrl&= ~(port->ctrl& 0x0040); /* clear port resume detected */
Removing the port resume bit from the readonly mask works better than
the clear-on-any-write hack ;)
cheers,
Gerd
next prev parent reply other threads:[~2010-12-01 17:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 15:34 PATCH: QEMU support for UHCI suspend / remote wake up Marcelo Tosatti
2010-11-25 15:34 ` [Qemu-devel] " Marcelo Tosatti
2010-11-25 16:15 ` Gerd Hoffmann
2010-11-25 16:15 ` [Qemu-devel] " Gerd Hoffmann
2010-11-25 17:04 ` [patch 0/2] USB UHCI global suspend / remote wakeup Marcelo Tosatti
2010-11-25 17:04 ` [Qemu-devel] " Marcelo Tosatti
2010-11-25 17:04 ` [patch 1/2] add USBBusOps to USBBus Marcelo Tosatti
2010-11-25 17:04 ` [Qemu-devel] " Marcelo Tosatti
2010-11-25 17:04 ` [patch 2/2] support for UHCI suspend / remote wake up Marcelo Tosatti
2010-11-25 17:04 ` [Qemu-devel] " Marcelo Tosatti
2010-12-01 15:12 ` Gerd Hoffmann
2010-12-01 15:12 ` [Qemu-devel] " Gerd Hoffmann
2010-12-01 16:58 ` Marcelo Tosatti
2010-12-01 16:58 ` [Qemu-devel] " Marcelo Tosatti
2010-12-01 17:17 ` Gerd Hoffmann
2010-12-01 17:17 ` [Qemu-devel] " Gerd Hoffmann
2010-11-26 0:38 ` [patch 0/2] USB UHCI global suspend / remote wakeup Paul Brook
2010-11-26 0:38 ` [Qemu-devel] " Paul Brook
2010-11-26 2:15 ` Marcelo Tosatti
2010-11-26 2:15 ` Marcelo Tosatti
2010-11-26 8:49 ` Gerd Hoffmann
2010-11-26 8:49 ` Gerd Hoffmann
2010-11-26 12:09 ` Paul Brook
2010-11-26 12:09 ` Paul Brook
2010-12-01 16:47 ` [Qemu-devel] [patch 0/3] QEMU support for UHCI suspend / remote wake up (v3) Marcelo Tosatti
2010-12-01 16:47 ` [Qemu-devel] [patch 1/3] add USBPortOps to USBPort Marcelo Tosatti
2010-12-01 17:10 ` [Qemu-devel] " Gerd Hoffmann
2010-12-01 16:47 ` [Qemu-devel] [patch 2/3] support for UHCI suspend / remote wake up Marcelo Tosatti
2010-12-01 17:12 ` Gerd Hoffmann [this message]
2010-12-01 16:47 ` [Qemu-devel] [patch 3/3] UHCI: Substate section for migration of remote wakeup feature Marcelo Tosatti
2010-12-01 17:16 ` [Qemu-devel] " Gerd Hoffmann
2010-12-01 19:14 ` Juan Quintela
2010-12-01 20:56 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF68219.8030302@redhat.com \
--to=kraxel@redhat.com \
--cc=mtosatti@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.