From: Martyn Welch <martyn.welch@ge.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linux-watchdog@vger.kernel.org, Wim Van Sebroeck <wim@iguana.be>
Subject: Re: [PATCH] watchdog: gef_wdt: include fs.h
Date: Thu, 02 Dec 2010 09:04:09 +0000 [thread overview]
Message-ID: <4CF76109.3060300@ge.com> (raw)
In-Reply-To: <1291245076-23790-1-git-send-email-w.sang@pengutronix.de>
On 01/12/10 23:11, Wolfram Sang wrote:
> Do like all the others do. Spotted because another watchdog driver in arch/
> missed it, too, and caused build failures with randconfigs.
>
Oddly, I sent an almost identical patch yesterday!
https://lkml.org/lkml/2010/12/1/217
Though I've just noticed that I messed up with the subject (rtc instead
of watchdog) and managed to introduce a vi-ism into the commit message.
Happy with either to be applied:
Acked-by: Martyn Welch <martyn.welch@ge.com>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> Cc: Martyn Welch <martyn.welch@ge.com>
> Cc: Wim Van Sebroeck <wim@iguana.be>
> ---
> drivers/watchdog/gef_wdt.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/watchdog/gef_wdt.c b/drivers/watchdog/gef_wdt.c
> index 9c21d19..f6bd6f1 100644
> --- a/drivers/watchdog/gef_wdt.c
> +++ b/drivers/watchdog/gef_wdt.c
> @@ -30,6 +30,7 @@
> #include <linux/module.h>
> #include <linux/miscdevice.h>
> #include <linux/watchdog.h>
> +#include <linux/fs.h>
> #include <linux/of.h>
> #include <linux/of_platform.h>
> #include <linux/io.h>
--
Martyn Welch (Principal Software Engineer) | Registered in England and
GE Intelligent Platforms | Wales (3828642) at 100
T +44(0)127322748 | Barbirolli Square,
Manchester,
E martyn.welch@ge.com | M2 3AB VAT:GB 927559189
next prev parent reply other threads:[~2010-12-02 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 23:11 [PATCH] watchdog: gef_wdt: include fs.h Wolfram Sang
2010-12-02 9:04 ` Martyn Welch [this message]
2010-12-02 14:00 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF76109.3060300@ge.com \
--to=martyn.welch@ge.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=w.sang@pengutronix.de \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.