All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] watchdog: gef_wdt: include fs.h
@ 2010-12-01 23:11 Wolfram Sang
  2010-12-02  9:04 ` Martyn Welch
  0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2010-12-01 23:11 UTC (permalink / raw)
  To: linux-watchdog; +Cc: Wolfram Sang, Martyn Welch, Wim Van Sebroeck

Do like all the others do. Spotted because another watchdog driver in arch/
missed it, too, and caused build failures with randconfigs.

Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Cc: Martyn Welch <martyn.welch@ge.com>
Cc: Wim Van Sebroeck <wim@iguana.be>
---
 drivers/watchdog/gef_wdt.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/watchdog/gef_wdt.c b/drivers/watchdog/gef_wdt.c
index 9c21d19..f6bd6f1 100644
--- a/drivers/watchdog/gef_wdt.c
+++ b/drivers/watchdog/gef_wdt.c
@@ -30,6 +30,7 @@
 #include <linux/module.h>
 #include <linux/miscdevice.h>
 #include <linux/watchdog.h>
+#include <linux/fs.h>
 #include <linux/of.h>
 #include <linux/of_platform.h>
 #include <linux/io.h>
-- 
1.7.2.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] watchdog: gef_wdt: include fs.h
  2010-12-01 23:11 [PATCH] watchdog: gef_wdt: include fs.h Wolfram Sang
@ 2010-12-02  9:04 ` Martyn Welch
  2010-12-02 14:00   ` Wim Van Sebroeck
  0 siblings, 1 reply; 3+ messages in thread
From: Martyn Welch @ 2010-12-02  9:04 UTC (permalink / raw)
  To: Wolfram Sang; +Cc: linux-watchdog, Wim Van Sebroeck

On 01/12/10 23:11, Wolfram Sang wrote:
> Do like all the others do. Spotted because another watchdog driver in arch/
> missed it, too, and caused build failures with randconfigs.
> 

Oddly, I sent an almost identical patch yesterday!

https://lkml.org/lkml/2010/12/1/217

Though I've just noticed that I messed up with the subject (rtc instead
of watchdog) and managed to introduce a vi-ism into the commit message.

Happy with either to be applied:

Acked-by: Martyn Welch <martyn.welch@ge.com>

> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> Cc: Martyn Welch <martyn.welch@ge.com>
> Cc: Wim Van Sebroeck <wim@iguana.be>
> ---
>  drivers/watchdog/gef_wdt.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/watchdog/gef_wdt.c b/drivers/watchdog/gef_wdt.c
> index 9c21d19..f6bd6f1 100644
> --- a/drivers/watchdog/gef_wdt.c
> +++ b/drivers/watchdog/gef_wdt.c
> @@ -30,6 +30,7 @@
>  #include <linux/module.h>
>  #include <linux/miscdevice.h>
>  #include <linux/watchdog.h>
> +#include <linux/fs.h>
>  #include <linux/of.h>
>  #include <linux/of_platform.h>
>  #include <linux/io.h>


-- 
Martyn Welch (Principal Software Engineer)   |   Registered in England and
GE Intelligent Platforms                     |   Wales (3828642) at 100
T +44(0)127322748                            |   Barbirolli Square,
Manchester,
E martyn.welch@ge.com                        |   M2 3AB  VAT:GB 927559189

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] watchdog: gef_wdt: include fs.h
  2010-12-02  9:04 ` Martyn Welch
@ 2010-12-02 14:00   ` Wim Van Sebroeck
  0 siblings, 0 replies; 3+ messages in thread
From: Wim Van Sebroeck @ 2010-12-02 14:00 UTC (permalink / raw)
  To: Martyn Welch; +Cc: Wolfram Sang, linux-watchdog

I'm adding the fix.

Kind regards,
Wim.


> On 01/12/10 23:11, Wolfram Sang wrote:
> > Do like all the others do. Spotted because another watchdog driver in arch/
> > missed it, too, and caused build failures with randconfigs.
> > 
> 
> Oddly, I sent an almost identical patch yesterday!
> 
> https://lkml.org/lkml/2010/12/1/217
> 
> Though I've just noticed that I messed up with the subject (rtc instead
> of watchdog) and managed to introduce a vi-ism into the commit message.
> 
> Happy with either to be applied:
> 
> Acked-by: Martyn Welch <martyn.welch@ge.com>
> 
> > Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> > Cc: Martyn Welch <martyn.welch@ge.com>
> > Cc: Wim Van Sebroeck <wim@iguana.be>
> > ---
> >  drivers/watchdog/gef_wdt.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/watchdog/gef_wdt.c b/drivers/watchdog/gef_wdt.c
> > index 9c21d19..f6bd6f1 100644
> > --- a/drivers/watchdog/gef_wdt.c
> > +++ b/drivers/watchdog/gef_wdt.c
> > @@ -30,6 +30,7 @@
> >  #include <linux/module.h>
> >  #include <linux/miscdevice.h>
> >  #include <linux/watchdog.h>
> > +#include <linux/fs.h>
> >  #include <linux/of.h>
> >  #include <linux/of_platform.h>
> >  #include <linux/io.h>
> 
> 
> -- 
> Martyn Welch (Principal Software Engineer)   |   Registered in England and
> GE Intelligent Platforms                     |   Wales (3828642) at 100
> T +44(0)127322748                            |   Barbirolli Square,
> Manchester,
> E martyn.welch@ge.com                        |   M2 3AB  VAT:GB 927559189

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-12-02 14:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-01 23:11 [PATCH] watchdog: gef_wdt: include fs.h Wolfram Sang
2010-12-02  9:04 ` Martyn Welch
2010-12-02 14:00   ` Wim Van Sebroeck

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.