* [PATCH] smsutil: Fix issue in mwi dcs decoding
@ 2010-12-02 9:43 Jeevaka Badrappan
2010-12-02 14:09 ` Denis Kenzior
0 siblings, 1 reply; 2+ messages in thread
From: Jeevaka Badrappan @ 2010-12-02 9:43 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 612 bytes --]
---
src/smsutil.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/src/smsutil.c b/src/smsutil.c
index b06e9bf..ccd30f6 100644
--- a/src/smsutil.c
+++ b/src/smsutil.c
@@ -219,7 +219,12 @@ gboolean sms_mwi_dcs_decode(guint8 dcs, enum sms_mwi_type *type,
else
dis = FALSE;
- if (upper == 3)
+ /*
+ * As per 3GPP TS 23.038 specification, if bits 7..4 set to 1110,
+ * text included in the user data is coded in the uncompresssed
+ * UCS2 character set.
+ */
+ if (upper == 2)
ch = SMS_CHARSET_UCS2;
else
ch = SMS_CHARSET_7BIT;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] smsutil: Fix issue in mwi dcs decoding
2010-12-02 9:43 [PATCH] smsutil: Fix issue in mwi dcs decoding Jeevaka Badrappan
@ 2010-12-02 14:09 ` Denis Kenzior
0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2010-12-02 14:09 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 235 bytes --]
Hi Jeevaka,
On 12/02/2010 03:43 AM, Jeevaka Badrappan wrote:
> ---
> src/smsutil.c | 7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
Yes, good catch. Patch has been applied, thanks.
Regards,
-Denis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-02 14:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-02 9:43 [PATCH] smsutil: Fix issue in mwi dcs decoding Jeevaka Badrappan
2010-12-02 14:09 ` Denis Kenzior
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.