From: Timur Tabi <timur@freescale.com>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: <linux-watchdog@vger.kernel.org>, <kumar.gala@freescale.com>,
<linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] watchdog: add CONFIG_WATCHDOG_NOWAYOUT support to PowerPC Book-E watchdog driver
Date: Fri, 3 Dec 2010 13:43:37 -0600 [thread overview]
Message-ID: <4CF94869.4020705@freescale.com> (raw)
In-Reply-To: <20101203193900.GC1903@zod.rchland.ibm.com>
Josh Boyer wrote:
> Just the moving of the clear_bit inside the #ifndef
> CONFIG_WATCHDOG_NOWAYOUT.
If I move the clear_bit() call inside the #ifndef, then when
CONFIG_WATCHDOG_NOWAYOUT is defined, after a process closes /dev/watchdog, no
process will ever be able to open it again. Are you saying that once
wd_keepalive exits, you don't want anyone to be able to open /dev/watchdog and
ping the timer again?
--
Timur Tabi
Linux kernel developer at Freescale
WARNING: multiple messages have this Message-ID (diff)
From: Timur Tabi <timur@freescale.com>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, kumar.gala@freescale.com,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] watchdog: add CONFIG_WATCHDOG_NOWAYOUT support to PowerPC Book-E watchdog driver
Date: Fri, 3 Dec 2010 13:43:37 -0600 [thread overview]
Message-ID: <4CF94869.4020705@freescale.com> (raw)
In-Reply-To: <20101203193900.GC1903@zod.rchland.ibm.com>
Josh Boyer wrote:
> Just the moving of the clear_bit inside the #ifndef
> CONFIG_WATCHDOG_NOWAYOUT.
If I move the clear_bit() call inside the #ifndef, then when
CONFIG_WATCHDOG_NOWAYOUT is defined, after a process closes /dev/watchdog, no
process will ever be able to open it again. Are you saying that once
wd_keepalive exits, you don't want anyone to be able to open /dev/watchdog and
ping the timer again?
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2010-12-03 19:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 16:51 [PATCH] watchdog: add CONFIG_WATCHDOG_NOWAYOUT support to PowerPC Book-E watchdog driver Timur Tabi
2010-12-03 18:07 ` Josh Boyer
2010-12-03 18:07 ` Josh Boyer
2010-12-03 18:22 ` Timur Tabi
2010-12-03 18:22 ` Timur Tabi
2010-12-03 19:05 ` Josh Boyer
2010-12-03 19:05 ` Josh Boyer
2010-12-03 19:10 ` Timur Tabi
2010-12-03 19:10 ` Timur Tabi
2010-12-03 19:39 ` Josh Boyer
2010-12-03 19:39 ` Josh Boyer
2010-12-03 19:43 ` Timur Tabi [this message]
2010-12-03 19:43 ` Timur Tabi
2010-12-03 19:50 ` Josh Boyer
2010-12-03 19:50 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF94869.4020705@freescale.com \
--to=timur@freescale.com \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=kumar.gala@freescale.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.