From: Dimitris Michailidis <dm@chelsio.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: David Miller <davem@davemloft.net>,
Olof Johansson <olof@lixom.net>,
Ben Hutchings <bhutchings@solarflare.com>,
Divy Le Ray <divy@chelsio.com>,
netdev@vger.kernel.org
Subject: Re: Misuse of LRO, how widespread
Date: Mon, 06 Dec 2010 15:05:15 -0800 [thread overview]
Message-ID: <4CFD6C2B.9020201@chelsio.com> (raw)
In-Reply-To: <20101206142715.0d296b25@nehalam>
Stephen Hemminger wrote:
> On Mon, 06 Dec 2010 13:15:42 -0800
> Dimitris Michailidis <dm@chelsio.com> wrote:
>
>> Stephen Hemminger wrote:
>>> I inspected all drivers in net-next to see which drivers are using
>>> LRO and which ones are broken. Most concerning is that Chelsio
>>> and Solarflare drivers ignore ETH_FLAG_LRO.
>>>
>>> The ones that are using LRO but allow disabling it:
>>> qlcnic, netxen, mv643, s2io, myi10ge, bnx2x, ixgbe, vmxnet3
>>>
>>> One driver seems confused about LRO vs GRO:
>>> mlx4 - comments about LRO and depends on LRO but driver is using GRO
>>>
>>> Drivers with not using ethtool interface to disable LRO:
>>> pasemi_mac, sfc, ehea, cxgb3, cxgb4
>> cxgb4 uses GRO, not LRO.
>
> Ok. but cxgb3 still uses LRO (or it least calls it lro).
>
cxgb3 was the driver Herbert implemented GRO on I think, and he converted it
to GRO. It possibly has leftover LRO references as it was using LRO before.
next prev parent reply other threads:[~2010-12-06 23:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 20:18 Misuse of LRO, how widespread Stephen Hemminger
2010-12-06 20:30 ` Ben Hutchings
2010-12-06 22:33 ` Stephen Hemminger
2010-12-06 22:35 ` Ben Hutchings
2010-12-10 23:03 ` David Miller
2010-12-06 21:15 ` Dimitris Michailidis
2010-12-06 22:27 ` Stephen Hemminger
2010-12-06 23:05 ` Dimitris Michailidis [this message]
2010-12-06 23:22 ` Ben Hutchings
2010-12-06 23:36 ` Dimitris Michailidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFD6C2B.9020201@chelsio.com \
--to=dm@chelsio.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=divy@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=olof@lixom.net \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.