From: Avi Kivity <avi@redhat.com>
To: Andre Przywara <andre.przywara@amd.com>
Cc: kvm@vger.kernel.org, mtosatti@redhat.com
Subject: Re: [PATCH 4/5] kvm/svm: implement enhanced INVLPG intercept
Date: Tue, 07 Dec 2010 15:27:28 +0200 [thread overview]
Message-ID: <4CFE3640.4070009@redhat.com> (raw)
In-Reply-To: <1291719586-22533-5-git-send-email-andre.przywara@amd.com>
On 12/07/2010 12:59 PM, Andre Przywara wrote:
> When the DecodeAssist feature is available, the linear address
> is provided in the VMCB on INVLPG intercepts. Use it directly to
> avoid any decoding and emulation.
> This is only useful for shadow paging, though.
>
> Signed-off-by: Andre Przywara<andre.przywara@amd.com>
> ---
> arch/x86/kvm/svm.c | 7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
> index 369bd85..3cf2cef 100644
> --- a/arch/x86/kvm/svm.c
> +++ b/arch/x86/kvm/svm.c
> @@ -2586,7 +2586,12 @@ static int iret_interception(struct vcpu_svm *svm)
>
> static int invlpg_interception(struct vcpu_svm *svm)
> {
> - return emulate_instruction(&svm->vcpu, 0, 0, 0) == EMULATE_DONE;
> + if (!boot_cpu_has(SVM_FEATURE_DECODE_ASSIST))
> + return emulate_instruction(&svm->vcpu, 0, 0, 0) == EMULATE_DONE;
static_cpu_has()
> +
> + kvm_mmu_invlpg(&svm->vcpu, svm->vmcb->control.exit_info_1);
> + skip_emulated_instruction(&svm->vcpu);
> + return 1;
> }
>
> static int emulate_on_interception(struct vcpu_svm *svm)
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-12-07 13:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 10:59 [PATCH 0/5] kvm/svm: implement new DecodeAssist features Andre Przywara
2010-12-07 10:59 ` [PATCH 1/5] kvm/svm: add new SVM feature bit names Andre Przywara
2010-12-07 10:59 ` [PATCH 2/5] kvm/svm: enhance MOV CR intercept handler Andre Przywara
2010-12-07 13:24 ` Avi Kivity
2010-12-07 14:30 ` Andre Przywara
2010-12-07 14:41 ` Avi Kivity
2010-12-07 10:59 ` [PATCH 3/5] kvm/svm: enhance mov DR " Andre Przywara
2010-12-07 11:02 ` Alexander Graf
2010-12-07 13:14 ` Avi Kivity
2010-12-07 13:25 ` Avi Kivity
2010-12-07 10:59 ` [PATCH 4/5] kvm/svm: implement enhanced INVLPG intercept Andre Przywara
2010-12-07 13:27 ` Avi Kivity [this message]
2010-12-07 10:59 ` [PATCH 5/5] kvm/svm: copy instruction bytes from VMCB Andre Przywara
2010-12-07 13:33 ` Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2010-12-10 13:51 [PATCH -v2 0/5] kvm/svm: implement new DecodeAssist features Andre Przywara
2010-12-10 13:51 ` [PATCH 4/5] kvm/svm: implement enhanced INVLPG intercept Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFE3640.4070009@redhat.com \
--to=avi@redhat.com \
--cc=andre.przywara@amd.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.