From: "Cousson, Benoit" <b-cousson@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: MING ZHOU <a17711@motorola.com>,
"Shilimkar, Santosh" <santosh.shilimkar@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH] Correct definition of register of OMAP4_RM_RSTST and OMAP4_RM_RSTTIME
Date: Tue, 7 Dec 2010 17:16:15 +0100 [thread overview]
Message-ID: <4CFE5DCF.1090903@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1012070902540.13430@utopia.booyaka.com>
Hi Paul,
On 12/7/2010 5:04 PM, Paul Walmsley wrote:
> Hello,
>
> On Tue, 7 Dec 2010, MING ZHOU wrote:
>
>> Since we need to reconfigure Reset time for OMAP4, we found the OMAP4
>> register definition for reset time is wrong according to spec of
>> OMAP4. And we verified this by reading default value of register. We
>> found the offset definition of Reset time and Reset Test register
>> should be switched. After correcting this bug, we verified by changing
>> the value of reset time register, the pulse generated for reset is
>> also changed as expected on scope.
>
> Thanks, will queue this for 2.6.38 since it looks like there are no
> in-tree users in 2.6.37.
These defines are not needed anymore, it is legacy stuff done before we
generated the whole prm44xx.h.
Here are the entries in the prm44xx.h, line 574.
/* PRM.DEVICE_PRM register offsets */
#define OMAP4_PRM_RSTCTRL_OFFSET 0x0000
#define OMAP4_PRM_RSTST_OFFSET 0x0004
#define OMAP4_PRM_RSTTIME_OFFSET 0x0008
We'd better get rid of these old entries in prm.h
Regards,
Benoit
prev parent reply other threads:[~2010-12-07 16:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 7:34 [PATCH] Correct definition of register of OMAP4_RM_RSTST and OMAP4_RM_RSTTIME MING ZHOU
2010-12-07 8:52 ` Santosh Shilimkar
2010-12-07 16:04 ` Paul Walmsley
2010-12-07 16:16 ` Cousson, Benoit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFE5DCF.1090903@ti.com \
--to=b-cousson@ti.com \
--cc=a17711@motorola.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.