From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: MING ZHOU <a17711@motorola.com>, linux-omap@vger.kernel.org
Cc: Tony Lindgren <tony@atomide.com>, Paul Walmsley <paul@pwsan.com>
Subject: RE: [PATCH] Correct definition of register of OMAP4_RM_RSTST and OMAP4_RM_RSTTIME
Date: Tue, 7 Dec 2010 14:22:19 +0530 [thread overview]
Message-ID: <58280319cf695f280ceefe82109d6f39@mail.gmail.com> (raw)
In-Reply-To: <AANLkTi=OdG2j2o+uZ+L_EpGKPTE8=fRBN8U60sJkqAhK@mail.gmail.com>
> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of MING ZHOU
> Sent: Tuesday, December 07, 2010 1:04 PM
> To: linux-omap@vger.kernel.org
> Cc: Tony Lindgren; Paul Walmsley
> Subject: [PATCH] Correct definition of register of OMAP4_RM_RSTST and
> OMAP4_RM_RSTTIME
>
> Since we need to reconfigure Reset time for OMAP4, we found the OMAP4
> register definition for reset time is wrong according to spec of
> OMAP4. And we verified this by reading default value of register. We
> found the offset definition of Reset time and Reset Test register
> should be switched. After correcting this bug, we verified by changing
> the value of reset time register, the pulse generated for reset is
> also changed as expected on scope.
>
> From 9a9c98c2f4008e5d8f2f5da1101e3bfe222a48ed Mon Sep 17 00:00:00 2001
> From: Zhou Ming <a17711@motorola.com>
> Date: Tue, 7 Dec 2010 10:00:59 -0500
> Subject: [PATCH] Correct definition of register of OMAP4_RM_RSTST and
> OMAP4_RM_RSTTIME
>
> According to test result, we found the offset definition of
OMAP4_RM_RSTST
> and OMAP4_RM_RSTIME should be switched.
> ---
> arch/arm/mach-omap2/prm.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/prm.h b/arch/arm/mach-omap2/prm.h
> index 7be040b..23b4be2 100644
> --- a/arch/arm/mach-omap2/prm.h
> +++ b/arch/arm/mach-omap2/prm.h
> @@ -222,8 +222,8 @@
>
> /* Omap4 specific registers */
> #define OMAP4_RM_RSTCTRL 0x0000
> -#define OMAP4_RM_RSTTIME 0x0004
> -#define OMAP4_RM_RSTST 0x0008
> +#define OMAP4_RM_RSTTIME 0x0008
> +#define OMAP4_RM_RSTST 0x0004
Yep. This is indeed correct offsets.
> #define OMAP4_PM_PWSTCTRL 0x0000
> #define OMAP4_PM_PWSTST 0x0004
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-12-07 8:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 7:34 [PATCH] Correct definition of register of OMAP4_RM_RSTST and OMAP4_RM_RSTTIME MING ZHOU
2010-12-07 8:52 ` Santosh Shilimkar [this message]
2010-12-07 16:04 ` Paul Walmsley
2010-12-07 16:16 ` Cousson, Benoit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58280319cf695f280ceefe82109d6f39@mail.gmail.com \
--to=santosh.shilimkar@ti.com \
--cc=a17711@motorola.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.