From: Jarek Poplawski <jarkao2@gmail.com>
To: Dan Carpenter <error27@gmail.com>
Cc: netdev@vger.kernel.org, Phil Blundell <philb@gnu.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] econet: unlock on -EPERM path
Date: Tue, 07 Dec 2010 22:09:41 +0000 [thread overview]
Message-ID: <4CFEB0A5.8040506@gmail.com> (raw)
In-Reply-To: <4CFEAEC2.7080506@gmail.com>
Jarek Poplawski wrote:
> Dan Carpenter wrote:
>> We need to do a mutex_unlock() and a put_dev() before returning.
>
> Good catch! Btw, isn't this put_dev() below, in case SIOCGIFADDR,
> superfluous?
Hmm... put_dev() a.k.a. dev_put() ;-)
Jarek P.
WARNING: multiple messages have this Message-ID (diff)
From: Jarek Poplawski <jarkao2@gmail.com>
To: Dan Carpenter <error27@gmail.com>
Cc: netdev@vger.kernel.org, Phil Blundell <philb@gnu.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] econet: unlock on -EPERM path
Date: Tue, 07 Dec 2010 23:09:41 +0100 [thread overview]
Message-ID: <4CFEB0A5.8040506@gmail.com> (raw)
In-Reply-To: <4CFEAEC2.7080506@gmail.com>
Jarek Poplawski wrote:
> Dan Carpenter wrote:
>> We need to do a mutex_unlock() and a put_dev() before returning.
>
> Good catch! Btw, isn't this put_dev() below, in case SIOCGIFADDR,
> superfluous?
Hmm... put_dev() a.k.a. dev_put() ;-)
Jarek P.
next prev parent reply other threads:[~2010-12-07 22:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 11:01 [patch] econet: unlock on -EPERM path Dan Carpenter
2010-12-07 11:01 ` Dan Carpenter
2010-12-07 22:01 ` Jarek Poplawski
2010-12-07 22:01 ` Jarek Poplawski
2010-12-07 22:09 ` Jarek Poplawski [this message]
2010-12-07 22:09 ` Jarek Poplawski
2010-12-08 18:14 ` David Miller
2010-12-08 18:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFEB0A5.8040506@gmail.com \
--to=jarkao2@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=philb@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.