All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robbert Kouprie <robbert-C1IQQP51G3M@public.gmane.org>
To: Shirish Pargaonkar
	<shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
	smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] cifs: Support NTLM2 session security during NTLMSSP authentication
Date: Wed, 08 Dec 2010 19:16:01 +0100	[thread overview]
Message-ID: <4CFFCB61.4090807@exx.nl> (raw)
In-Reply-To: <AANLkTinehfVNbrC2gNnDEi5OHDtgjYYimUqYO=+y4Dy6-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Also,

Op 8-12-2010 18:28, Shirish Pargaonkar schreef:
> On Wed, Dec 8, 2010 at 10:33 AM, Shirish Pargaonkar

>>>> diff --git a/fs/cifs/sess.c b/fs/cifs/sess.c
>>>> index 7b01d3f..122ad31 100644
>>>> --- a/fs/cifs/sess.c
>>>> +++ b/fs/cifs/sess.c
>>>> @@ -437,7 +437,7 @@ static void build_ntlmssp_negotiate_blob(unsigned char *pbuffer,

(...)

>>>> @@ -544,8 +544,9 @@ static int build_ntlmssp_auth_blob(unsigned char *pbuffer,

The patch you sent me (and which I tested successfully) had an extra
hunk in it:

@@ -477,7 +477,7 @@ static int build_ntlmssp_auth_blob(unsigned char
*pbuffer,
        flags = NTLMSSP_NEGOTIATE_56 |
                NTLMSSP_REQUEST_TARGET | NTLMSSP_NEGOTIATE_TARGET_INFO |
                NTLMSSP_NEGOTIATE_128 | NTLMSSP_NEGOTIATE_UNICODE |
-               NTLMSSP_NEGOTIATE_NTLM;
+               NTLMSSP_NEGOTIATE_NTLM | NTLMSSP_NEGOTIATE_EXTENDED_SEC;
        if (ses->server->secMode &
           (SECMODE_SIGN_REQUIRED | SECMODE_SIGN_ENABLED))
                flags |= NTLMSSP_NEGOTIATE_SIGN;

Is it your intent to leave out this hunk?

Regards,
Robbert

  parent reply	other threads:[~2010-12-08 18:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-08 15:41 [PATCH] cifs: Support NTLM2 session security during NTLMSSP authentication shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w
     [not found] ` <1291822865-26472-1-git-send-email-shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-12-08 16:06   ` Jeff Layton
     [not found]     ` <20101208110608.607a23e2-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2010-12-08 16:33       ` Shirish Pargaonkar
     [not found]         ` <AANLkTi=WVaCDRHf5=DgnZr7crJByhH5r6F6S+_PVGY0F-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-12-08 17:28           ` Shirish Pargaonkar
     [not found]             ` <AANLkTinehfVNbrC2gNnDEi5OHDtgjYYimUqYO=+y4Dy6-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-12-08 18:16               ` Robbert Kouprie [this message]
     [not found]                 ` <4CFFCB61.4090807-C1IQQP51G3M@public.gmane.org>
2010-12-08 18:53                   ` Shirish Pargaonkar
     [not found]                     ` <AANLkTikU1OhcT8FmyrOZfrLtgK-8NKnRnFNnczFvz2C_-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-12-08 21:07                       ` Robbert Kouprie
     [not found]                         ` <4CFFF37D.5010004-C1IQQP51G3M@public.gmane.org>
2010-12-09 12:56                           ` Robbert Kouprie
     [not found]                             ` <alpine.DEB.2.00.1012091351180.9919-56sTcPfcKMhJlCS1zhbguEjk2N/pv5CcZkel5v8DVj8@public.gmane.org>
2010-12-09 14:35                               ` Shirish Pargaonkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CFFCB61.4090807@exx.nl \
    --to=robbert-c1iqqp51g3m@public.gmane.org \
    --cc=jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
    --cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.