* [PATCH] x86: Dell Precision WorkStation 690 reboot quirk
@ 2010-12-08 15:37 Edouard Gomez
2010-12-08 16:27 ` Thomas Gleixner
2010-12-09 15:16 ` Matthew Garrett
0 siblings, 2 replies; 6+ messages in thread
From: Edouard Gomez @ 2010-12-08 15:37 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86,
Thomas Backlund, Leann Ogasawara, linux-kernel
Cc: ed.gomez
# HG changeset patch
# User Edouard Gomez <ed.gomez@free.fr>
# Date 1291821505 -3600
# Node ID 4d8b4b3a1d3c6034b86889fac38dd53e6579bb42
# Parent 53e51000d59963c8ca408db4db619d2c82374c5e
x86: Dell Precision WorkStation 690 reboot quirk
This Dell workstation gets stuck on reboot unless booted with
the paremeter reboot=bios.
This patch has been submitted 3 times already to X86 ARCHITECTURE
maintainers w/o any feedback so far. Trying my chance on the LKML.
Patch is against 2.6.36.1
Signed-off-by: Edouard Gomez <ed.gomez@free.fr>
diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -236,6 +236,15 @@
DMI_MATCH(DMI_PRODUCT_NAME, "Precision WorkStation T7400"),
},
},
+ { /* Handle problems with rebooting on Dell 690's */
+ .callback = set_bios_reboot,
+ .ident = "Dell Precision 690",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Precision WorkStation 690"),
+ DMI_MATCH(DMI_BOARD_NAME, "0MY171"),
+ },
+ },
{ /* Handle problems with rebooting on HP laptops */
.callback = set_bios_reboot,
.ident = "HP Compaq Laptop",
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] x86: Dell Precision WorkStation 690 reboot quirk
2010-12-08 15:37 [PATCH] x86: Dell Precision WorkStation 690 reboot quirk Edouard Gomez
@ 2010-12-08 16:27 ` Thomas Gleixner
2010-12-09 15:16 ` Matthew Garrett
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Gleixner @ 2010-12-08 16:27 UTC (permalink / raw)
To: Edouard Gomez
Cc: Ingo Molnar, H. Peter Anvin, x86, Thomas Backlund,
Leann Ogasawara, linux-kernel
On Wed, 8 Dec 2010, Edouard Gomez wrote:
> # HG changeset patch
> # User Edouard Gomez <ed.gomez@free.fr>
> # Date 1291821505 -3600
> # Node ID 4d8b4b3a1d3c6034b86889fac38dd53e6579bb42
> # Parent 53e51000d59963c8ca408db4db619d2c82374c5e
> x86: Dell Precision WorkStation 690 reboot quirk
>
> This Dell workstation gets stuck on reboot unless booted with
> the paremeter reboot=bios.
>
> This patch has been submitted 3 times already to X86 ARCHITECTURE
> maintainers w/o any feedback so far. Trying my chance on the LKML.
Sorry, but I haven't seen this patch in my inbox and my mail server
log has only a single connection attempt to deliver mail from you on
Dec. 8 which ended up in one of my spam traps.
Cc'ing LKML (or some other relevant mailinglist) is recommended for
sending patches anyway. Documentation/SubmittingPatches says:
Unless you have a reason NOT to do so, CC linux-kernel@vger.kernel.org.
Thanks,
tglx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86: Dell Precision WorkStation 690 reboot quirk
2010-12-08 15:37 [PATCH] x86: Dell Precision WorkStation 690 reboot quirk Edouard Gomez
2010-12-08 16:27 ` Thomas Gleixner
@ 2010-12-09 15:16 ` Matthew Garrett
2010-12-09 15:19 ` H. Peter Anvin
1 sibling, 1 reply; 6+ messages in thread
From: Matthew Garrett @ 2010-12-09 15:16 UTC (permalink / raw)
To: Edouard Gomez
Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86,
Thomas Backlund, Leann Ogasawara, linux-kernel
My testing suggests that Windows never uses the BIOS-style reboot
approach, so this seems wrong. Does reboot=acpi work for you?
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86: Dell Precision WorkStation 690 reboot quirk
2010-12-09 15:16 ` Matthew Garrett
@ 2010-12-09 15:19 ` H. Peter Anvin
2010-12-09 15:27 ` Matthew Garrett
0 siblings, 1 reply; 6+ messages in thread
From: H. Peter Anvin @ 2010-12-09 15:19 UTC (permalink / raw)
To: Matthew Garrett
Cc: Edouard Gomez, Thomas Gleixner, Ingo Molnar, x86, Thomas Backlund,
Leann Ogasawara, linux-kernel
On 12/09/2010 07:16 AM, Matthew Garrett wrote:
> My testing suggests that Windows never uses the BIOS-style reboot
> approach, so this seems wrong. Does reboot=acpi work for you?
We have talked about switching to reboot=acpi by default for machines
newer than <some date>... this would be good to do.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86: Dell Precision WorkStation 690 reboot quirk
2010-12-09 15:19 ` H. Peter Anvin
@ 2010-12-09 15:27 ` Matthew Garrett
0 siblings, 0 replies; 6+ messages in thread
From: Matthew Garrett @ 2010-12-09 15:27 UTC (permalink / raw)
To: H. Peter Anvin
Cc: Edouard Gomez, Thomas Gleixner, Ingo Molnar, x86, Thomas Backlund,
Leann Ogasawara, linux-kernel
On Thu, Dec 09, 2010 at 07:19:44AM -0800, H. Peter Anvin wrote:
> On 12/09/2010 07:16 AM, Matthew Garrett wrote:
> > My testing suggests that Windows never uses the BIOS-style reboot
> > approach, so this seems wrong. Does reboot=acpi work for you?
>
> We have talked about switching to reboot=acpi by default for machines
> newer than <some date>... this would be good to do.
The majority of systems with valid ACPI reboot vectors appear to just be
pointing at the PCI reset port, which makes sense. My testing suggests
that Windows calls the ACPI reboot vector, then tries to use the i8042,
then tries the ACPI reboot vector again and finally tries the i8042
again before giving up and spinning. I'll recheck this behaviour today
and then send a patch.
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] x86: Dell Precision WorkStation 690 reboot quirk
@ 2010-03-05 15:55 Edouard Gomez
0 siblings, 0 replies; 6+ messages in thread
From: Edouard Gomez @ 2010-03-05 15:55 UTC (permalink / raw)
To: linux-kernel; +Cc: Edouard Gomez
# HG changeset patch
# User Edouard Gomez <ed.gomez@free.fr>
# Date 1267783903 -3600
# Node ID aec3aca0d290e7000e179a1f4908b3b475d98846
# Parent c242cee8e9bd4ef993871546912bc17b0605c7d0
x86: Dell Precision WorkStation 690 reboot quirk
This Dell workstation gets stuck on reboot unless booted with
the paremeter reboot=bios.
This patch has been submitted 2 times already to X86 ARCHITECTURE
maintainers w/o any feedback so far. Trying my chance on the LKML.
Signed-off-by: Edouard Gomez <ed.gomez@free.fr>
diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -228,6 +228,15 @@
DMI_MATCH(DMI_PRODUCT_NAME, "Precision WorkStation T5400"),
},
},
+ { /* Handle problems with rebooting on Dell 690's */
+ .callback = set_bios_reboot,
+ .ident = "Dell Precision 690",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Precision WorkStation 690"),
+ DMI_MATCH(DMI_BOARD_NAME, "0MY171"),
+ },
+ },
{ /* Handle problems with rebooting on HP laptops */
.callback = set_bios_reboot,
.ident = "HP Compaq Laptop",
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-12-09 15:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-08 15:37 [PATCH] x86: Dell Precision WorkStation 690 reboot quirk Edouard Gomez
2010-12-08 16:27 ` Thomas Gleixner
2010-12-09 15:16 ` Matthew Garrett
2010-12-09 15:19 ` H. Peter Anvin
2010-12-09 15:27 ` Matthew Garrett
-- strict thread matches above, loose matches on Subject: below --
2010-03-05 15:55 Edouard Gomez
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.