* [PATCH] dccp: remove never used macros
@ 2010-12-10 10:06 Shan Wei
0 siblings, 0 replies; 9+ messages in thread
From: Shan Wei @ 2010-12-10 10:06 UTC (permalink / raw)
To: dccp
Since 2005, the initial dccp implementation introduced these marcos,
but never be used. So remove them.
commit 7c657876b63cb1d8a2ec06f8fc6c37bb8412e66c
Author: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Date: Tue Aug 9 20:14:34 2005 -0700
[DCCP]: Initial implementation
Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
---
net/dccp/dccp.h | 8 --------
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/net/dccp/dccp.h b/net/dccp/dccp.h
index 48ad5d9..4508705 100644
--- a/net/dccp/dccp.h
+++ b/net/dccp/dccp.h
@@ -93,9 +93,6 @@ extern void dccp_time_wait(struct sock *sk, int state, int timeo);
#define DCCP_FALLBACK_RTT (USEC_PER_SEC / 5)
#define DCCP_SANE_RTT_MAX (3 * USEC_PER_SEC)
-/* Maximal interval between probes for local resources. */
-#define DCCP_RESOURCE_PROBE_INTERVAL ((unsigned)(HZ / 2U))
-
/* sysctl variables for DCCP */
extern int sysctl_dccp_request_retries;
extern int sysctl_dccp_retries1;
@@ -203,12 +200,7 @@ struct dccp_mib {
DECLARE_SNMP_STAT(struct dccp_mib, dccp_statistics);
#define DCCP_INC_STATS(field) SNMP_INC_STATS(dccp_statistics, field)
#define DCCP_INC_STATS_BH(field) SNMP_INC_STATS_BH(dccp_statistics, field)
-#define DCCP_INC_STATS_USER(field) SNMP_INC_STATS_USER(dccp_statistics, field)
#define DCCP_DEC_STATS(field) SNMP_DEC_STATS(dccp_statistics, field)
-#define DCCP_ADD_STATS_BH(field, val) \
- SNMP_ADD_STATS_BH(dccp_statistics, field, val)
-#define DCCP_ADD_STATS_USER(field, val) \
- SNMP_ADD_STATS_USER(dccp_statistics, field, val)
/*
* Checksumming routines
--
1.6.3.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* net-next-2.6 [Patch 1/1] dccp: dead code elimination
2010-12-10 10:06 [PATCH] dccp: remove never used macros Shan Wei
@ 2010-12-10 11:59 ` Gerrit Renker
-1 siblings, 0 replies; 9+ messages in thread
From: Gerrit Renker @ 2010-12-10 11:59 UTC (permalink / raw)
To: dccp
Dave,
can you please consider the attached patch - it removes indeed dead code.
I have also placed this in into a fresh (today's) copy of net-next-2.6, on
git://eden-feed.erg.abdn.ac.uk/net-next-2.6 [subtree 'dccp']
Shan,
I have edited the commit message (s/marcos/macros/). In future, please
can you cc: your patches to netdev@vger also. Thank you.
Gerrit
^ permalink raw reply [flat|nested] 9+ messages in thread
* net-next-2.6 [Patch 1/1] dccp: dead code elimination
@ 2010-12-10 11:59 ` Gerrit Renker
0 siblings, 0 replies; 9+ messages in thread
From: Gerrit Renker @ 2010-12-10 11:59 UTC (permalink / raw)
To: davem; +Cc: dccp, netdev
Dave,
can you please consider the attached patch - it removes indeed dead code.
I have also placed this in into a fresh (today's) copy of net-next-2.6, on
git://eden-feed.erg.abdn.ac.uk/net-next-2.6 [subtree 'dccp']
Shan,
I have edited the commit message (s/marcos/macros/). In future, please
can you cc: your patches to netdev@vger also. Thank you.
Gerrit
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/1] dccp: remove unused macros
2010-12-10 11:59 ` Gerrit Renker
@ 2010-12-10 11:59 ` Gerrit Renker
-1 siblings, 0 replies; 9+ messages in thread
From: Gerrit Renker @ 2010-12-10 11:59 UTC (permalink / raw)
To: dccp
From: Shan Wei <shanwei@cn.fujitsu.com>
Remove macros which have been unused since the initial implementation
(commit 7c657876b63cb1d8a2ec06f8fc6c37bb8412e66c, [DCCP]: Initial
implementation from Tue Aug 9 20:14:34 2005 -0700).
Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
Acked-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
---
net/dccp/dccp.h | 8 --------
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/net/dccp/dccp.h b/net/dccp/dccp.h
index 48ad5d9..4508705 100644
--- a/net/dccp/dccp.h
+++ b/net/dccp/dccp.h
@@ -93,9 +93,6 @@ extern void dccp_time_wait(struct sock *sk, int state, int timeo);
#define DCCP_FALLBACK_RTT (USEC_PER_SEC / 5)
#define DCCP_SANE_RTT_MAX (3 * USEC_PER_SEC)
-/* Maximal interval between probes for local resources. */
-#define DCCP_RESOURCE_PROBE_INTERVAL ((unsigned)(HZ / 2U))
-
/* sysctl variables for DCCP */
extern int sysctl_dccp_request_retries;
extern int sysctl_dccp_retries1;
@@ -203,12 +200,7 @@ struct dccp_mib {
DECLARE_SNMP_STAT(struct dccp_mib, dccp_statistics);
#define DCCP_INC_STATS(field) SNMP_INC_STATS(dccp_statistics, field)
#define DCCP_INC_STATS_BH(field) SNMP_INC_STATS_BH(dccp_statistics, field)
-#define DCCP_INC_STATS_USER(field) SNMP_INC_STATS_USER(dccp_statistics, field)
#define DCCP_DEC_STATS(field) SNMP_DEC_STATS(dccp_statistics, field)
-#define DCCP_ADD_STATS_BH(field, val) \
- SNMP_ADD_STATS_BH(dccp_statistics, field, val)
-#define DCCP_ADD_STATS_USER(field, val) \
- SNMP_ADD_STATS_USER(dccp_statistics, field, val)
/*
* Checksumming routines
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 1/1] dccp: remove unused macros
@ 2010-12-10 11:59 ` Gerrit Renker
0 siblings, 0 replies; 9+ messages in thread
From: Gerrit Renker @ 2010-12-10 11:59 UTC (permalink / raw)
To: davem; +Cc: dccp, netdev, Shan Wei
From: Shan Wei <shanwei@cn.fujitsu.com>
Remove macros which have been unused since the initial implementation
(commit 7c657876b63cb1d8a2ec06f8fc6c37bb8412e66c, [DCCP]: Initial
implementation from Tue Aug 9 20:14:34 2005 -0700).
Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
Acked-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
---
net/dccp/dccp.h | 8 --------
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/net/dccp/dccp.h b/net/dccp/dccp.h
index 48ad5d9..4508705 100644
--- a/net/dccp/dccp.h
+++ b/net/dccp/dccp.h
@@ -93,9 +93,6 @@ extern void dccp_time_wait(struct sock *sk, int state, int timeo);
#define DCCP_FALLBACK_RTT (USEC_PER_SEC / 5)
#define DCCP_SANE_RTT_MAX (3 * USEC_PER_SEC)
-/* Maximal interval between probes for local resources. */
-#define DCCP_RESOURCE_PROBE_INTERVAL ((unsigned)(HZ / 2U))
-
/* sysctl variables for DCCP */
extern int sysctl_dccp_request_retries;
extern int sysctl_dccp_retries1;
@@ -203,12 +200,7 @@ struct dccp_mib {
DECLARE_SNMP_STAT(struct dccp_mib, dccp_statistics);
#define DCCP_INC_STATS(field) SNMP_INC_STATS(dccp_statistics, field)
#define DCCP_INC_STATS_BH(field) SNMP_INC_STATS_BH(dccp_statistics, field)
-#define DCCP_INC_STATS_USER(field) SNMP_INC_STATS_USER(dccp_statistics, field)
#define DCCP_DEC_STATS(field) SNMP_DEC_STATS(dccp_statistics, field)
-#define DCCP_ADD_STATS_BH(field, val) \
- SNMP_ADD_STATS_BH(dccp_statistics, field, val)
-#define DCCP_ADD_STATS_USER(field, val) \
- SNMP_ADD_STATS_USER(dccp_statistics, field, val)
/*
* Checksumming routines
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: net-next-2.6 [Patch 1/1] dccp: dead code elimination
2010-12-10 11:59 ` Gerrit Renker
@ 2010-12-10 19:23 ` David Miller
-1 siblings, 0 replies; 9+ messages in thread
From: David Miller @ 2010-12-10 19:23 UTC (permalink / raw)
To: dccp
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Date: Fri, 10 Dec 2010 12:59:30 +0100
> Dave,
>
> can you please consider the attached patch - it removes indeed dead code.
> I have also placed this in into a fresh (today's) copy of net-next-2.6, on
>
> git://eden-feed.erg.abdn.ac.uk/net-next-2.6 [subtree 'dccp']
Pulled, thanks!
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: net-next-2.6 [Patch 1/1] dccp: dead code elimination
@ 2010-12-10 19:23 ` David Miller
0 siblings, 0 replies; 9+ messages in thread
From: David Miller @ 2010-12-10 19:23 UTC (permalink / raw)
To: gerrit; +Cc: dccp, netdev
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Date: Fri, 10 Dec 2010 12:59:30 +0100
> Dave,
>
> can you please consider the attached patch - it removes indeed dead code.
> I have also placed this in into a fresh (today's) copy of net-next-2.6, on
>
> git://eden-feed.erg.abdn.ac.uk/net-next-2.6 [subtree 'dccp']
Pulled, thanks!
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: net-next-2.6 [Patch 1/1] dccp: dead code elimination
2010-12-10 11:59 ` Gerrit Renker
@ 2010-12-13 1:13 ` Shan Wei
-1 siblings, 0 replies; 9+ messages in thread
From: Shan Wei @ 2010-12-13 1:13 UTC (permalink / raw)
To: dccp
Gerrit Renker wrote, at 12/10/2010 07:59 PM:
>
> Shan,
> I have edited the commit message (s/marcos/macros/). In future, please
> can you cc: your patches to netdev@vger also. Thank you.
Thanks for your suggesting.
I'll do that next time.
--
Best Regards
-----
Shan Wei
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: net-next-2.6 [Patch 1/1] dccp: dead code elimination
@ 2010-12-13 1:13 ` Shan Wei
0 siblings, 0 replies; 9+ messages in thread
From: Shan Wei @ 2010-12-13 1:13 UTC (permalink / raw)
To: Gerrit Renker; +Cc: davem, dccp, netdev
Gerrit Renker wrote, at 12/10/2010 07:59 PM:
>
> Shan,
> I have edited the commit message (s/marcos/macros/). In future, please
> can you cc: your patches to netdev@vger also. Thank you.
Thanks for your suggesting.
I'll do that next time.
--
Best Regards
-----
Shan Wei
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2010-12-13 1:15 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-10 11:59 net-next-2.6 [Patch 1/1] dccp: dead code elimination Gerrit Renker
2010-12-10 11:59 ` Gerrit Renker
2010-12-10 19:23 ` David Miller
2010-12-10 19:23 ` David Miller
2010-12-13 1:13 ` Shan Wei
2010-12-13 1:13 ` Shan Wei
-- strict thread matches above, loose matches on Subject: below --
2010-12-10 11:59 [PATCH 1/1] dccp: remove unused macros Gerrit Renker
2010-12-10 11:59 ` Gerrit Renker
2010-12-10 10:06 [PATCH] dccp: remove never used macros Shan Wei
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.