From: Jan Kiszka <jan.kiszka@web.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
linux-kernel@vger.kernel.org, kvm <kvm@vger.kernel.org>,
Tom Lyon <pugs@cisco.com>,
Alex Williamson <alex.williamson@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH v3 1/4] genirq: Introduce driver-readable IRQ status word
Date: Wed, 15 Dec 2010 00:10:05 +0100 [thread overview]
Message-ID: <4D07F94D.8050807@web.de> (raw)
In-Reply-To: <alpine.LFD.2.00.1012142145480.12146@localhost6.localdomain6>
[-- Attachment #1: Type: text/plain, Size: 838 bytes --]
Am 14.12.2010 21:47, Thomas Gleixner wrote:
> On Mon, 13 Dec 2010, Jan Kiszka wrote:
>> +/**
>> + * get_irq_status - read interrupt line status word
>> + * @irq: Interrupt line of the status word
>> + *
>> + * This returns the current content of the status word associated with
>> + * the given interrupt line. See IRQS_* flags for details.
>> + */
>> +unsigned long get_irq_status(unsigned int irq)
>> +{
>> + struct irq_desc *desc = irq_to_desc(irq);
>> +
>> + return desc ? desc->irq_data.drv_status : 0;
>> +}
>> +EXPORT_SYMBOL_GPL(get_irq_status);
>
> We should document that this is a snapshot and in no way serialized
> against modifications of drv_status. I'll fix up the kernel doc.
Yeah, I think I had some hint on this in the previous version but
apparently dropped it for this round.
Thanks,
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2010-12-14 23:10 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 22:59 [PATCH v3 0/4] KVM & genirq: Enable adaptive IRQ sharing for passed-through devices Jan Kiszka
2010-12-13 22:59 ` [PATCH v3 1/4] genirq: Introduce driver-readable IRQ status word Jan Kiszka
2010-12-14 20:47 ` Thomas Gleixner
2010-12-14 23:10 ` Jan Kiszka [this message]
2010-12-13 22:59 ` [PATCH v3 2/4] genirq: Inform handler about line sharing state Jan Kiszka
2010-12-14 20:54 ` Thomas Gleixner
2010-12-14 23:00 ` Jan Kiszka
2010-12-15 13:04 ` Thomas Gleixner
2010-12-15 14:18 ` Jan Kiszka
2010-12-15 14:49 ` Thomas Gleixner
2010-12-15 15:41 ` Thomas Gleixner
2010-12-15 15:49 ` Jan Kiszka
2010-12-15 16:02 ` Thomas Gleixner
2010-12-14 21:46 ` Thomas Gleixner
2010-12-14 23:01 ` Jan Kiszka
2010-12-15 8:05 ` Thomas Gleixner
2010-12-15 9:37 ` Jan Kiszka
2010-12-15 9:48 ` Thomas Gleixner
2010-12-16 13:13 ` Thomas Gleixner
2010-12-16 20:26 ` Jan Kiszka
2010-12-16 21:28 ` change of email address: pugs@cisco.com -> pugs@ieee.org Tom Lyon
2010-12-17 8:18 ` [PATCH v3 2/4] genirq: Inform handler about line sharing state Jan Kiszka
2010-12-17 10:23 ` Thomas Gleixner
2010-12-17 10:31 ` Jan Kiszka
2010-12-17 10:41 ` Thomas Gleixner
2010-12-17 10:48 ` Jan Kiszka
2010-12-17 15:25 ` Thomas Gleixner
2010-12-17 16:06 ` Jan Kiszka
2010-12-17 16:32 ` Thomas Gleixner
2010-12-18 18:11 ` Michael S. Tsirkin
2010-12-13 22:59 ` [PATCH v3 3/4] genirq: Add support for IRQF_COND_ONESHOT Jan Kiszka
2010-12-13 22:59 ` [PATCH v3 4/4] KVM: Allow host IRQ sharing for passed-through PCI 2.3 devices Jan Kiszka
2010-12-14 8:53 ` [PATCH v3 0/4] KVM & genirq: Enable adaptive IRQ sharing for passed-through devices Avi Kivity
2010-12-14 22:01 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D07F94D.8050807@web.de \
--to=jan.kiszka@web.de \
--cc=alex.williamson@redhat.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pugs@cisco.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.