From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: linux-mtd@lists.infradead.org, dwmw2@infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] MTD: m25p80: add debugging trace in sst_write()
Date: Wed, 15 Dec 2010 16:25:28 +0300 [thread overview]
Message-ID: <4D08C1C8.3090100@ru.mvista.com> (raw)
In-Reply-To: <1292414372-17085-1-git-send-email-nicolas.ferre@atmel.com>
Hello.
On 15-12-2010 14:59, Nicolas Ferre wrote:
> Add a DEBUG(MTD_DEBUG_LEVEL2, ..) trace at beginning of sst_write() function as
> it is done in m25p80_write() function.
> Signed-off-by: Nicolas Ferre<nicolas.ferre@atmel.com>
[...]
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index bf5a002..e6b5707 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -482,6 +482,10 @@ static int sst_write(struct mtd_info *mtd, loff_t to, size_t len,
> size_t actual;
> int cmd_sz, ret;
>
> + DEBUG(MTD_DEBUG_LEVEL2, "%s: %s %s 0x%08x, len %zd\n",
> + dev_name(&flash->spi->dev), __func__, "to",
What's the point of printing "to" as variable? :-)
> + (u32)to, len);
> +
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] MTD: m25p80: add debugging trace in sst_write()
Date: Wed, 15 Dec 2010 16:25:28 +0300 [thread overview]
Message-ID: <4D08C1C8.3090100@ru.mvista.com> (raw)
In-Reply-To: <1292414372-17085-1-git-send-email-nicolas.ferre@atmel.com>
Hello.
On 15-12-2010 14:59, Nicolas Ferre wrote:
> Add a DEBUG(MTD_DEBUG_LEVEL2, ..) trace at beginning of sst_write() function as
> it is done in m25p80_write() function.
> Signed-off-by: Nicolas Ferre<nicolas.ferre@atmel.com>
[...]
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index bf5a002..e6b5707 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -482,6 +482,10 @@ static int sst_write(struct mtd_info *mtd, loff_t to, size_t len,
> size_t actual;
> int cmd_sz, ret;
>
> + DEBUG(MTD_DEBUG_LEVEL2, "%s: %s %s 0x%08x, len %zd\n",
> + dev_name(&flash->spi->dev), __func__, "to",
What's the point of printing "to" as variable? :-)
> + (u32)to, len);
> +
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] MTD: m25p80: add debugging trace in sst_write()
Date: Wed, 15 Dec 2010 16:25:28 +0300 [thread overview]
Message-ID: <4D08C1C8.3090100@ru.mvista.com> (raw)
In-Reply-To: <1292414372-17085-1-git-send-email-nicolas.ferre@atmel.com>
Hello.
On 15-12-2010 14:59, Nicolas Ferre wrote:
> Add a DEBUG(MTD_DEBUG_LEVEL2, ..) trace at beginning of sst_write() function as
> it is done in m25p80_write() function.
> Signed-off-by: Nicolas Ferre<nicolas.ferre@atmel.com>
[...]
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index bf5a002..e6b5707 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -482,6 +482,10 @@ static int sst_write(struct mtd_info *mtd, loff_t to, size_t len,
> size_t actual;
> int cmd_sz, ret;
>
> + DEBUG(MTD_DEBUG_LEVEL2, "%s: %s %s 0x%08x, len %zd\n",
> + dev_name(&flash->spi->dev), __func__, "to",
What's the point of printing "to" as variable? :-)
> + (u32)to, len);
> +
WBR, Sergei
next prev parent reply other threads:[~2010-12-15 13:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 11:59 [PATCH] MTD: m25p80: add debugging trace in sst_write() Nicolas Ferre
2010-12-15 11:59 ` Nicolas Ferre
2010-12-15 11:59 ` Nicolas Ferre
2010-12-15 13:25 ` Sergei Shtylyov [this message]
2010-12-15 13:25 ` Sergei Shtylyov
2010-12-15 13:25 ` Sergei Shtylyov
2010-12-15 13:43 ` Nicolas Ferre
2011-07-08 16:43 ` Nicolas Ferre
2010-12-15 13:43 ` Nicolas Ferre
2010-12-15 16:12 ` Russell King - ARM Linux
2010-12-15 16:12 ` Russell King - ARM Linux
2010-12-15 16:12 ` Russell King - ARM Linux
2010-12-19 17:00 ` Artem Bityutskiy
2010-12-19 17:00 ` Artem Bityutskiy
2010-12-19 17:00 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D08C1C8.3090100@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.