From: "Cousson, Benoit" <b-cousson@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: "khilman@deeprootsystems.com" <khilman@deeprootsystems.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Nayak, Rajendra" <rnayak@ti.com>,
"Raja, Govindraj" <govindraj.raja@ti.com>,
"Varadarajan, Charulatha" <charu@ti.com>
Subject: Re: [PATCH 1/5] OMAP4: hwmod data: Fix hwmod entries order
Date: Wed, 15 Dec 2010 14:44:44 +0100 [thread overview]
Message-ID: <4D08C64C.1040809@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1012141807380.15971@utopia.booyaka.com>
Hi Paul,
On 12/15/2010 2:09 AM, Paul Walmsley wrote:
>
> I had to modify this patch in order to apply it. Following is the updated
> patch. Please let me know if this patch doesn't result in the correct
> file.
>
>
> - Paul
>
> From: Benoit Cousson<b-cousson@ti.com>
> Date: Tue, 14 Dec 2010 17:37:24 -0700
> Subject: [PATCH] OMAP4: hwmod data: Fix hwmod entries order
>
> The original OMAP4 hwmod data files is fully generated from HW
> database. But since the file is introduced incrementaly along
> with driver that uses the data, it has to be splitted by the driver
> owner and then re-merged by the maintainer.
> Because of the similarity of the data, git is completely lost
> during such merge and thus the data does not look like the original one
> at the end.
>
> Re-order properly the structures to stay in sync with original data set.
> This makes it much easier to diff the autogenerated script output with
> what's in mainline, see differences, and generate patches for those
> diffs. The goal is to stay in sync with the autogenerated data from now
> on.
>
> Add a comment that does contain all the IPs that can have a hwmod, but
> do not have it in the file for the moment. It gives a good indication
> of the progress.
>
> Signed-off-by: Benoit Cousson<b-cousson@ti.com>
> [paul@pwsan.com: updated to apply against current core integration branch,
> commit message slightly amplified; fixed opt_clks_cnt whitespace]
It looks like this fix is not in the integration branch.
The commit id does have the new changelog but not the opt_clks_cnt fix:
e4912451c076b082b5a427fc2541c29fdc93e715.
Maybe I didn't use the right branch.
Since I have a new hwmod_data patch, I will re-send my series with this
fix included just in case.
Thanks,
Benoit
WARNING: multiple messages have this Message-ID (diff)
From: b-cousson@ti.com (Cousson, Benoit)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] OMAP4: hwmod data: Fix hwmod entries order
Date: Wed, 15 Dec 2010 14:44:44 +0100 [thread overview]
Message-ID: <4D08C64C.1040809@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1012141807380.15971@utopia.booyaka.com>
Hi Paul,
On 12/15/2010 2:09 AM, Paul Walmsley wrote:
>
> I had to modify this patch in order to apply it. Following is the updated
> patch. Please let me know if this patch doesn't result in the correct
> file.
>
>
> - Paul
>
> From: Benoit Cousson<b-cousson@ti.com>
> Date: Tue, 14 Dec 2010 17:37:24 -0700
> Subject: [PATCH] OMAP4: hwmod data: Fix hwmod entries order
>
> The original OMAP4 hwmod data files is fully generated from HW
> database. But since the file is introduced incrementaly along
> with driver that uses the data, it has to be splitted by the driver
> owner and then re-merged by the maintainer.
> Because of the similarity of the data, git is completely lost
> during such merge and thus the data does not look like the original one
> at the end.
>
> Re-order properly the structures to stay in sync with original data set.
> This makes it much easier to diff the autogenerated script output with
> what's in mainline, see differences, and generate patches for those
> diffs. The goal is to stay in sync with the autogenerated data from now
> on.
>
> Add a comment that does contain all the IPs that can have a hwmod, but
> do not have it in the file for the moment. It gives a good indication
> of the progress.
>
> Signed-off-by: Benoit Cousson<b-cousson@ti.com>
> [paul at pwsan.com: updated to apply against current core integration branch,
> commit message slightly amplified; fixed opt_clks_cnt whitespace]
It looks like this fix is not in the integration branch.
The commit id does have the new changelog but not the opt_clks_cnt fix:
e4912451c076b082b5a427fc2541c29fdc93e715.
Maybe I didn't use the right branch.
Since I have a new hwmod_data patch, I will re-send my series with this
fix included just in case.
Thanks,
Benoit
next prev parent reply other threads:[~2010-12-15 13:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 23:33 [PATCH 0/5] OMAP4: hwmod data fixes and update Benoit Cousson
2010-12-09 23:33 ` Benoit Cousson
2010-12-09 23:33 ` [PATCH 1/5] OMAP4: hwmod data: Fix hwmod entries order Benoit Cousson
2010-12-09 23:33 ` Benoit Cousson
2010-12-14 3:07 ` Kevin Hilman
2010-12-14 3:07 ` Kevin Hilman
2010-12-15 1:09 ` Paul Walmsley
2010-12-15 1:09 ` Paul Walmsley
2010-12-15 13:44 ` Cousson, Benoit [this message]
2010-12-15 13:44 ` Cousson, Benoit
2010-12-09 23:33 ` [PATCH 2/5] OMAP4: hwmod data: Add SYSS_HAS_RESET_STATUS flag Benoit Cousson
2010-12-09 23:33 ` Benoit Cousson
2010-12-09 23:33 ` [PATCH 3/5] OMAP4: hwmod data: Fix missing address in DMM and EMIF_FW Benoit Cousson
2010-12-09 23:33 ` Benoit Cousson
2010-12-09 23:33 ` [PATCH 4/5] OMAP4: hwmod data: Add IVA and DSP Benoit Cousson
2010-12-09 23:33 ` Benoit Cousson
2010-12-09 23:33 ` [PATCH 5/5] OMAP4: hwmod & clock data: Fix GPIO opt_clks and ocp_if iclk Benoit Cousson
2010-12-09 23:33 ` Benoit Cousson
2010-12-15 1:10 ` Paul Walmsley
2010-12-15 1:10 ` Paul Walmsley
2010-12-10 0:36 ` [PATCH 0/5] OMAP4: hwmod data fixes and update Kevin Hilman
2010-12-10 0:36 ` Kevin Hilman
2010-12-10 7:51 ` Cousson, Benoit
2010-12-10 7:51 ` Cousson, Benoit
2010-12-10 15:54 ` Cousson, Benoit
2010-12-10 15:54 ` Cousson, Benoit
2010-12-15 1:07 ` Paul Walmsley
2010-12-15 1:07 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D08C64C.1040809@ti.com \
--to=b-cousson@ti.com \
--cc=charu@ti.com \
--cc=govindraj.raja@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.