From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Jan Engelhardt <jengelh@medozas.de>,
Netfilter Developer Mailing List
<netfilter-devel@vger.kernel.org>
Subject: Re: [patch] xtables: use guarded types
Date: Wed, 15 Dec 2010 22:59:37 +0100 [thread overview]
Message-ID: <4D093A49.2060500@trash.net> (raw)
In-Reply-To: <4D01FFC5.90808@netfilter.org>
Am 10.12.2010 11:24, schrieb Pablo Neira Ayuso:
> On 09/12/10 20:25, Jan Engelhardt wrote:
>> On Thursday 2010-12-09 11:43, Pablo Neira Ayuso wrote:
>>
>>> On 03/12/10 20:13, Jan Engelhardt wrote:
>>>> parent b880c1f077000956b9f475d5f3b6c5e45ff2e342 (v2.6.37-rc1-241-gb880c1f)
>>>> commit 4826151aedbe6e364b7b801f026fbe7383904b6a
>>>> Author: Jan Engelhardt <jengelh@medozas.de>
>>>> Date: Thu Dec 2 21:01:17 2010 +0100
>>>>
>>>> netfilter: xtables: use guarded types
>>>>
>>>> We are supposed to use the kernel's own types in userspace exports.
>>>
>>> What's the point to have different headers in the kernel source code
>>> tree and iptables?
>>
>> Because iptables needs to know more structs than the kernel provides.
>>
>> But... what does that have to do with the patch?
>
> I mean that, after this patch, iptables headers and Linux kernel headers
> will be out of sync, right?
>
Well, we can resync userspace, but the __ types specifically exist
to avoid namespace polution.
Applied, thanks.
I'll also gladly apply a patch to get rid of the u_int_XX crap.
next prev parent reply other threads:[~2010-12-15 21:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 19:13 [patch] xtables: use guarded types Jan Engelhardt
2010-12-09 10:43 ` Pablo Neira Ayuso
2010-12-09 19:25 ` Jan Engelhardt
2010-12-10 10:24 ` Pablo Neira Ayuso
2010-12-15 21:59 ` Patrick McHardy [this message]
2010-12-15 22:20 ` Jan Engelhardt
2010-12-15 22:47 ` Patrick McHardy
2010-12-16 0:27 ` Jan Engelhardt
2010-12-16 7:28 ` Patrick McHardy
2010-12-17 23:04 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D093A49.2060500@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.