From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Netfilter Developer Mailing List
<netfilter-devel@vger.kernel.org>
Subject: Re: [patch] xtables: use guarded types
Date: Thu, 16 Dec 2010 08:28:50 +0100 [thread overview]
Message-ID: <4D09BFB2.7040504@trash.net> (raw)
In-Reply-To: <alpine.LNX.2.01.1012160120480.2669@obet.zrqbmnf.qr>
On 16.12.2010 01:27, Jan Engelhardt wrote:
>
> On Wednesday 2010-12-15 23:47, Patrick McHardy wrote:
>>>>
>>>> I'll also gladly apply a patch to get rid of the u_int_XX crap.
>>>
>>> To be found where? (Choose: kernel/userspace/both)
>>
>> Both I guess, but I was previously referring to the kernel.
>
> I do not see the issue with using POSIX types outside of operating
> system interface specifications.
> So I guess this is in order:
>
> parent 3a84b3d5de492e40aff7bae5038b06dd6b6041c4 (v1.4.10-17-g3a84b3d)
> commit a069355b7933c9afe38b5cb7b251b2ece4fe8456
> Author: Jan Engelhardt <jengelh@medozas.de>
> Date: Thu Dec 16 00:59:27 2010 +0100
>
> src: use C99/POSIX types
>
> "u_int" was a non-standardized extension predating C99 on some platforms.
While I don't have a real personal preference, most of the remaining
networking stack uses uXX types and I know code has been actively
converted from C99 types to those. So for consistency we should also
use uXX. Sorry for not being clearer about that before.
next prev parent reply other threads:[~2010-12-16 7:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 19:13 [patch] xtables: use guarded types Jan Engelhardt
2010-12-09 10:43 ` Pablo Neira Ayuso
2010-12-09 19:25 ` Jan Engelhardt
2010-12-10 10:24 ` Pablo Neira Ayuso
2010-12-15 21:59 ` Patrick McHardy
2010-12-15 22:20 ` Jan Engelhardt
2010-12-15 22:47 ` Patrick McHardy
2010-12-16 0:27 ` Jan Engelhardt
2010-12-16 7:28 ` Patrick McHardy [this message]
2010-12-17 23:04 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D09BFB2.7040504@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.