Re: [RFC v2 4/4] USB: Eliminate delays involved in root hub initialization during HNP

[Sergei Shtylyov <sshtylyov@mvista.com>]

On 16-12-2010 16:07, Felipe Balbi wrote:

>>> Some USB controllers have common resources (IRQ, register address
>>> space) for Host, Peripheral and OTG. So HCD is added only before
>>> entering into Host mode. Root hub initialization is done in
>>> different steps to decrease boot up time. But this makes B-device
>>> difficult to meet HNP timings. Hence eliminate delays involved in
>>> root hub initialization for B-host.

>>> This patch also marks hnp_supported flag TRUE for B-host while
>>> registering the bus.

>>> Change-Id: I821775e8c90bd71a7abbe17176f189664a1841e1
>>> Signed-off-by: Pavankumar Kondeti<pkondeti@codeaurora.org>
>> [...]

>>> index ac79fd5..2df61ba 100644
>>> --- a/drivers/usb/core/hub.c
>>> +++ b/drivers/usb/core/hub.c
>>> @@ -680,6 +680,7 @@ static void hub_activate(struct usb_hub *hub, enum
>>> hub_activation_type type)
>>> int status;
>>> bool need_debounce_delay = false;
>>> unsigned delay;
>>> + bool hnp_in_progress = hdev->bus->is_b_host&& (type == HUB_INIT);

>> Parens here are not necessary.

> there's also a missing space before &&

    That's my Thunderbird eating spaces before &. :-)

WBR, Sergei