From: Jeff Ohlstein <johlstei@codeaurora.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: "David Brown" <davidb@codeaurora.org>,
"Daniel Walker" <dwalker@codeaurora.org>,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Brian Swetland" <swetland@google.com>,
"Dima Zavin" <dima@android.com>,
"Arve Hjønnevåg" <arve@android.com>,
"Bryan Huntsman" <bryanh@codeaurora.org>,
"Russell King" <linux@arm.linux.org.uk>
Subject: Re: [PATCH v5 4/5] msm: hotplug: support cpu hotplug on msm
Date: Thu, 16 Dec 2010 13:40:37 -0800 [thread overview]
Message-ID: <4D0A8755.9080408@codeaurora.org> (raw)
In-Reply-To: <AANLkTinzVP4rjOZM0PZQGYBNm+z-O=S0h6vo1QVoh+ps@mail.gmail.com>
Catalin Marinas wrote:
> On 16 December 2010 06:54, Jeff Ohlstein <johlstei@codeaurora.org> wrote:
>> --- /dev/null
>> +++ b/arch/arm/mach-msm/hotplug.c
> [...]
>> +static inline void platform_do_lowpower(unsigned int cpu)
>> +{
>> + /* Just enter wfi for now. TODO: Properly shut off the cpu. */
>> + for (;;) {
>> + /*
>> + * here's the WFI
>> + */
>> + asm(".word 0xe320f003\n"
>> + :
>> + :
>> + : "memory", "cc");
>
> Is this for an ARMv7 platform? If yes, you could just use the WFI
> instruction directly (and it would also work if compiling the kernel
> to Thumb-2 mode).
>
I was trying to make the code as similar to the realview code as I
reasonably could. There are several instances of that, we could fix all
of them in one go.
-Jeff
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: johlstei@codeaurora.org (Jeff Ohlstein)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 4/5] msm: hotplug: support cpu hotplug on msm
Date: Thu, 16 Dec 2010 13:40:37 -0800 [thread overview]
Message-ID: <4D0A8755.9080408@codeaurora.org> (raw)
In-Reply-To: <AANLkTinzVP4rjOZM0PZQGYBNm+z-O=S0h6vo1QVoh+ps@mail.gmail.com>
Catalin Marinas wrote:
> On 16 December 2010 06:54, Jeff Ohlstein <johlstei@codeaurora.org> wrote:
>> --- /dev/null
>> +++ b/arch/arm/mach-msm/hotplug.c
> [...]
>> +static inline void platform_do_lowpower(unsigned int cpu)
>> +{
>> + /* Just enter wfi for now. TODO: Properly shut off the cpu. */
>> + for (;;) {
>> + /*
>> + * here's the WFI
>> + */
>> + asm(".word 0xe320f003\n"
>> + :
>> + :
>> + : "memory", "cc");
>
> Is this for an ARMv7 platform? If yes, you could just use the WFI
> instruction directly (and it would also work if compiling the kernel
> to Thumb-2 mode).
>
I was trying to make the code as similar to the realview code as I
reasonably could. There are several instances of that, we could fix all
of them in one go.
-Jeff
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2010-12-16 21:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 6:54 [PATCH v5 0/5] SMP support for msm Jeff Ohlstein
2010-12-16 6:54 ` Jeff Ohlstein
2010-12-16 6:54 ` [PATCH v5 1/5] msm: Secure Channel Manager (SCM) support Jeff Ohlstein
2010-12-16 6:54 ` Jeff Ohlstein
2010-12-16 6:54 ` Jeff Ohlstein
2010-12-16 6:54 ` [PATCH v5 2/5] msm: scm-boot: Support for setting cold/warm boot addresses Jeff Ohlstein
2010-12-16 6:54 ` Jeff Ohlstein
2010-12-16 6:54 ` Jeff Ohlstein
2010-12-16 6:54 ` [PATCH v5 3/5] msm: timer: SMP timer support for msm Jeff Ohlstein
2010-12-16 6:54 ` Jeff Ohlstein
2010-12-16 6:54 ` Jeff Ohlstein
2010-12-16 6:54 ` [PATCH v5 4/5] msm: hotplug: support cpu hotplug on msm Jeff Ohlstein
2010-12-16 6:54 ` Jeff Ohlstein
2010-12-16 6:54 ` Jeff Ohlstein
2010-12-16 12:55 ` Catalin Marinas
2010-12-16 12:55 ` Catalin Marinas
2010-12-16 21:40 ` Jeff Ohlstein [this message]
2010-12-16 21:40 ` Jeff Ohlstein
2010-12-16 6:54 ` [PATCH v5 5/5] msm: add SMP support for msm Jeff Ohlstein
2010-12-16 6:54 ` Jeff Ohlstein
2010-12-16 6:54 ` Jeff Ohlstein
2010-12-16 21:44 ` Russell King - ARM Linux
2010-12-16 21:44 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0A8755.9080408@codeaurora.org \
--to=johlstei@codeaurora.org \
--cc=arve@android.com \
--cc=bryanh@codeaurora.org \
--cc=catalin.marinas@arm.com \
--cc=davidb@codeaurora.org \
--cc=dima@android.com \
--cc=dwalker@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.