[PATCH] test/list-modems : print Strength as an integer

[PATCH] test/list-modems : print Strength as an integer

[=?unknown-8bit?q?Beno=C3=AEt?= Monin]

[-- Attachment #1: Type: text/plain, Size: 627 bytes --]

org.ofono.NetworkRegistration property Strength is an integer,
so print it as such.
---
 test/list-modems     3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/test/list-modems b/test/list-modems
index 557efd5..8c075ac 100755
--- a/test/list-modems
+++ b/test/list-modems
@@ -51,7 +51,8 @@ for path, properties in modems:
 elif key in ["MobileNetworkCodeLength",
 "VoicemailMessageCount",
 "MicrophoneVolume",
- "SpeakerVolume"]:
+ "SpeakerVolume",
+ "Strength"]:
 val = int(properties[key])
 elif key in ["MainMenu"]:
 val = ", ".join([ text + " (" + str(int(icon)) +
-- 
1.7.0.3

Re: [PATCH] test/list-modems : print Strength as an integer

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 595 bytes --]

Hi Benoit,

On 12/15/2010 09:07 AM, "Benoît Monin" wrote:
> org.ofono.NetworkRegistration property Strength is an integer,
> so print it as such.
> ---
>  test/list-modems     3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 

Patch looks fine, however it does not apply:

Applying: test/list-modems : print Strength as an integer
error: patch failed: test/list-modems:51
error: test/list-modems: patch does not apply
Patch failed at 0001 test/list-modems : print Strength as an integer

Can you make sure to configure your MTA agent correctly?

Regards,
-Denis

Re: [PATCH] test/list-modems : print Strength as an integer

[=?unknown-8bit?q?Beno=C3=AEt?= Monin]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

Hi Denis,

Le vendredi 17 décembre 2010 01:56:48 Denis Kenzior, vous avez écrit :
[snip]
> Can you make sure to configure your MTA agent correctly?
> 
Duh, my dog ate my patch, again.
Sorry about that, resending now.

--
Cheers,
Benoît.

[PATCH resend] test/list-modems : print Strength as an integer

[=?unknown-8bit?q?Beno=C3=AEt?= Monin]

[-- Attachment #1: Type: text/plain, Size: 665 bytes --]

org.ofono.NetworkRegistration property Strength is an integer,
so print it as such.
---
 test/list-modems |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/test/list-modems b/test/list-modems
index 557efd5..8c075ac 100755
--- a/test/list-modems
+++ b/test/list-modems
@@ -51,7 +51,8 @@ for path, properties in modems:
 			elif key in ["MobileNetworkCodeLength",
 						"VoicemailMessageCount",
 						"MicrophoneVolume",
-						"SpeakerVolume"]:
+						"SpeakerVolume",
+						"Strength"]:
 				val = int(properties[key])
 			elif key in ["MainMenu"]:
 				val = ", ".join([ text + " (" + str(int(icon)) +
-- 
1.7.1

Re: [PATCH resend] test/list-modems : print Strength as an integer

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

Hi Benoît,

On 12/17/2010 02:33 PM, Benoît Monin wrote:
> org.ofono.NetworkRegistration property Strength is an integer,
> so print it as such.
> ---
>  test/list-modems |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 

Patch has been applied, thanks.

Regards,
-Denis