From: Jan Kiszka <jan.kiszka@web.de>
To: Glauber Costa <glommer@redhat.com>
Cc: Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org, qemu-devel@nongnu.org,
Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH v2 14/17] kvm: x86: Introduce kvmclock device to save/restore its state
Date: Mon, 03 Jan 2011 17:48:11 +0100 [thread overview]
Message-ID: <4D21FDCB.70504@web.de> (raw)
In-Reply-To: <1294072661.5370.22.camel@mothafucka.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]
Am 03.01.2011 17:37, Glauber Costa wrote:
> On Mon, 2011-01-03 at 09:33 +0100, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> If kvmclock is used, which implies the kernel supports it, register a
>> kvmclock device with the sysbus. Its main purpose is to save and restore
>> the kernel state on migration, but this will also allow to visualize it
>> one day.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> CC: Glauber Costa <glommer@redhat.com>
>
> Hi Jan.
>
> I've just recently posted a patch (not sure what was made from it), that
> fixes a bug that you reintroduce here.
Hmm, must have missed it.
>
> The bug is: if we call KVM_GET_CLOCK ioctl in pre_save, this means that
> this value will change every time we issue savevm, even if the machine
> is not run in between.
>
> Ideally, we'd like to have two consecutive savevms returning the exact
> same thing in that situation.
>
> I like the general approach of moving it to sysbus, but please move the
> ioctl to change state notifiers.
OK, will look into this.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@web.de>
To: Glauber Costa <glommer@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Avi Kivity <avi@redhat.com>,
kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH v2 14/17] kvm: x86: Introduce kvmclock device to save/restore its state
Date: Mon, 03 Jan 2011 17:48:11 +0100 [thread overview]
Message-ID: <4D21FDCB.70504@web.de> (raw)
In-Reply-To: <1294072661.5370.22.camel@mothafucka.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]
Am 03.01.2011 17:37, Glauber Costa wrote:
> On Mon, 2011-01-03 at 09:33 +0100, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> If kvmclock is used, which implies the kernel supports it, register a
>> kvmclock device with the sysbus. Its main purpose is to save and restore
>> the kernel state on migration, but this will also allow to visualize it
>> one day.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> CC: Glauber Costa <glommer@redhat.com>
>
> Hi Jan.
>
> I've just recently posted a patch (not sure what was made from it), that
> fixes a bug that you reintroduce here.
Hmm, must have missed it.
>
> The bug is: if we call KVM_GET_CLOCK ioctl in pre_save, this means that
> this value will change every time we issue savevm, even if the machine
> is not run in between.
>
> Ideally, we'd like to have two consecutive savevms returning the exact
> same thing in that situation.
>
> I like the general approach of moving it to sysbus, but please move the
> ioctl to change state notifiers.
OK, will look into this.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2011-01-03 16:48 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 8:32 [PATCH v2 00/17] [uq/master] Prepare for more qemu-kvm merging Jan Kiszka
2011-01-03 8:32 ` [Qemu-devel] " Jan Kiszka
2011-01-03 8:32 ` [PATCH v2 01/17] kvm: Fix coding style violations Jan Kiszka
2011-01-03 8:32 ` [Qemu-devel] " Jan Kiszka
2011-01-03 8:32 ` [PATCH v2 02/17] kvm: Drop return value of kvm_cpu_exec Jan Kiszka
2011-01-03 8:32 ` [Qemu-devel] " Jan Kiszka
2011-01-03 8:32 ` [PATCH v2 03/17] kvm: Stop on all fatal exit reasons Jan Kiszka
2011-01-03 8:32 ` [Qemu-devel] " Jan Kiszka
2011-01-03 8:32 ` [PATCH v2 04/17] kvm: Improve reporting of fatal errors Jan Kiszka
2011-01-03 8:32 ` [Qemu-devel] " Jan Kiszka
2011-01-03 8:32 ` [PATCH v2 05/17] x86: Optionally dump code bytes on cpu_dump_state Jan Kiszka
2011-01-03 8:32 ` [Qemu-devel] " Jan Kiszka
2011-01-03 13:13 ` [PATCH v3 " Jan Kiszka
2011-01-03 13:13 ` [Qemu-devel] " Jan Kiszka
2011-01-03 8:32 ` [PATCH v2 06/17] kvm: x86: Align kvm_arch_put_registers code with comment Jan Kiszka
2011-01-03 8:32 ` [Qemu-devel] " Jan Kiszka
2011-01-03 8:32 ` [PATCH v2 07/17] kvm: x86: Prepare kvm_get_mp_state for in-kernel irqchip Jan Kiszka
2011-01-03 8:32 ` [Qemu-devel] " Jan Kiszka
2011-01-03 8:32 ` [PATCH v2 08/17] kvm: x86: Remove redundant mp_state initialization Jan Kiszka
2011-01-03 8:32 ` [Qemu-devel] " Jan Kiszka
2011-01-03 8:32 ` [PATCH v2 09/17] kvm: x86: Fix xcr0 reset mismerge Jan Kiszka
2011-01-03 8:32 ` [Qemu-devel] " Jan Kiszka
2011-01-03 8:33 ` [PATCH v2 10/17] kvm: x86: Refactor msr_star/hsave_pa setup and checks Jan Kiszka
2011-01-03 8:33 ` [Qemu-devel] " Jan Kiszka
2011-01-03 8:33 ` [PATCH v2 11/17] kvm: x86: Reset paravirtual MSRs Jan Kiszka
2011-01-03 8:33 ` [Qemu-devel] " Jan Kiszka
2011-01-03 16:40 ` Glauber Costa
2011-01-03 16:40 ` [Qemu-devel] " Glauber Costa
2011-01-03 16:46 ` Jan Kiszka
2011-01-03 16:46 ` [Qemu-devel] " Jan Kiszka
2011-01-03 16:51 ` Glauber Costa
2011-01-03 16:51 ` [Qemu-devel] " Glauber Costa
2011-01-03 8:33 ` [PATCH v2 12/17] kvm: x86: Drop MCE MSRs write back restrictions Jan Kiszka
2011-01-03 8:33 ` [Qemu-devel] " Jan Kiszka
2011-01-03 8:33 ` [PATCH v2 13/17] kvm: Eliminate KVMState arguments Jan Kiszka
2011-01-03 8:33 ` [Qemu-devel] " Jan Kiszka
2011-01-03 11:13 ` Alexander Graf
2011-01-03 11:13 ` [Qemu-devel] " Alexander Graf
2011-01-03 8:33 ` [PATCH v2 14/17] kvm: x86: Introduce kvmclock device to save/restore its state Jan Kiszka
2011-01-03 8:33 ` [Qemu-devel] " Jan Kiszka
2011-01-03 16:04 ` Avi Kivity
2011-01-03 16:04 ` [Qemu-devel] " Avi Kivity
2011-01-03 16:30 ` Jan Kiszka
2011-01-03 16:30 ` [Qemu-devel] " Jan Kiszka
2011-01-03 16:39 ` Glauber Costa
2011-01-03 16:39 ` [Qemu-devel] " Glauber Costa
2011-01-03 16:41 ` Avi Kivity
2011-01-03 16:41 ` [Qemu-devel] " Avi Kivity
2011-01-03 16:38 ` Glauber Costa
2011-01-03 16:38 ` [Qemu-devel] " Glauber Costa
2011-01-03 16:37 ` Glauber Costa
2011-01-03 16:37 ` [Qemu-devel] " Glauber Costa
2011-01-03 16:48 ` Jan Kiszka [this message]
2011-01-03 16:48 ` Jan Kiszka
2011-01-03 8:33 ` [PATCH v2 15/17] kvm: Drop smp_cpus argument from init functions Jan Kiszka
2011-01-03 8:33 ` [Qemu-devel] " Jan Kiszka
2011-01-03 8:33 ` [PATCH v2 16/17] kvm: x86: Rework identity map and TSS setup for larger BIOS sizes Jan Kiszka
2011-01-03 8:33 ` [Qemu-devel] " Jan Kiszka
2011-01-03 16:06 ` Avi Kivity
2011-01-03 16:06 ` [Qemu-devel] " Avi Kivity
2011-01-03 16:52 ` Jan Kiszka
2011-01-03 16:52 ` [Qemu-devel] " Jan Kiszka
2011-01-03 16:59 ` Avi Kivity
2011-01-03 16:59 ` [Qemu-devel] " Avi Kivity
2011-01-03 17:19 ` Jan Kiszka
2011-01-03 17:19 ` [Qemu-devel] " Jan Kiszka
2011-01-03 8:33 ` [PATCH v2 17/17] kvm: Drop dependencies on very old capabilities Jan Kiszka
2011-01-03 8:33 ` [Qemu-devel] " Jan Kiszka
2011-01-03 16:08 ` Avi Kivity
2011-01-03 16:08 ` [Qemu-devel] " Avi Kivity
2011-01-03 16:54 ` Jan Kiszka
2011-01-03 16:54 ` [Qemu-devel] " Jan Kiszka
2011-01-03 17:01 ` Avi Kivity
2011-01-03 17:01 ` [Qemu-devel] " Avi Kivity
2011-01-03 17:24 ` Jan Kiszka
2011-01-03 17:24 ` [Qemu-devel] " Jan Kiszka
2011-01-03 12:44 ` [PATCH 18/17] kvm: Flush coalesced mmio buffer on IO window exits Jan Kiszka
2011-01-03 12:44 ` [Qemu-devel] " Jan Kiszka
2011-01-03 16:09 ` [PATCH v2 00/17] [uq/master] Prepare for more qemu-kvm merging Avi Kivity
2011-01-03 16:09 ` [Qemu-devel] " Avi Kivity
2011-01-04 8:42 ` Jan Kiszka
2011-01-04 8:42 ` [Qemu-devel] " Jan Kiszka
2011-01-04 9:02 ` Avi Kivity
2011-01-04 9:02 ` [Qemu-devel] " Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D21FDCB.70504@web.de \
--to=jan.kiszka@web.de \
--cc=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.