* [PATCH] ALSA: HDA: Add internal mic for IDT 92HD88B
@ 2011-01-04 5:57 David Henningsson
2011-01-10 10:19 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: David Henningsson @ 2011-01-04 5:57 UTC (permalink / raw)
To: ALSA Development Mailing List, Takashi Iwai
[-- Attachment #1: Type: text/plain, Size: 317 bytes --]
BugLink: http://bugs.launchpad.net/bugs/696493
According to datasheet (and real-world testing), IDT 92HD88B can
have internal mics at NID 0x11 and 0x20, so enable them accordingly.
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
--
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
[-- Attachment #2: 0001-ALSA-HDA-Add-internal-mic-for-IDT-92HD88B.patch --]
[-- Type: text/x-patch, Size: 1758 bytes --]
>From 4fdc8bb0ab1e786821003cb448559efea9d5081a Mon Sep 17 00:00:00 2001
From: David Henningsson <david.henningsson@canonical.com>
Date: Tue, 4 Jan 2011 06:30:53 +0100
Subject: [PATCH] ALSA: HDA: Add internal mic for IDT 92HD88B
BugLink: http://bugs.launchpad.net/bugs/696493
According to datasheet (and real-world testing), IDT 92HD88B can
have internal mics at NID 0x11 and 0x20, so enable them accordingly.
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
---
sound/pci/hda/patch_sigmatel.c | 12 +++++++++++-
1 files changed, 11 insertions(+), 1 deletions(-)
diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
index 6131a92..c8d812e 100644
--- a/sound/pci/hda/patch_sigmatel.c
+++ b/sound/pci/hda/patch_sigmatel.c
@@ -389,6 +389,9 @@ static hda_nid_t stac92hd83xxx_dmic_nids[STAC92HD83XXX_NUM_DMICS + 1] = {
0x11, 0x20, 0
};
+#define STAC92HD88XXX_NUM_DMICS STAC92HD83XXX_NUM_DMICS
+#define stac92hd88xxx_dmic_nids stac92hd83xxx_dmic_nids
+
#define STAC92HD87B_NUM_DMICS 1
static hda_nid_t stac92hd87b_dmic_nids[STAC92HD87B_NUM_DMICS + 1] = {
0x11, 0
@@ -5462,11 +5465,18 @@ again:
spec->num_dmics = stac92xx_connected_ports(codec,
stac92hd87b_dmic_nids,
STAC92HD87B_NUM_DMICS);
- /* Fall through */
+ spec->num_pins = ARRAY_SIZE(stac92hd88xxx_pin_nids);
+ spec->pin_nids = stac92hd88xxx_pin_nids;
+ spec->mono_nid = 0;
+ spec->num_pwrs = 0;
+ break;
case 0x111d7666:
case 0x111d7667:
case 0x111d7668:
case 0x111d7669:
+ spec->num_dmics = stac92xx_connected_ports(codec,
+ stac92hd88xxx_dmic_nids,
+ STAC92HD88XXX_NUM_DMICS);
spec->num_pins = ARRAY_SIZE(stac92hd88xxx_pin_nids);
spec->pin_nids = stac92hd88xxx_pin_nids;
spec->mono_nid = 0;
--
1.7.1
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ALSA: HDA: Add internal mic for IDT 92HD88B
2011-01-04 5:57 [PATCH] ALSA: HDA: Add internal mic for IDT 92HD88B David Henningsson
@ 2011-01-10 10:19 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2011-01-10 10:19 UTC (permalink / raw)
To: David Henningsson; +Cc: ALSA Development Mailing List
At Tue, 04 Jan 2011 06:57:27 +0100,
David Henningsson wrote:
>
> BugLink: http://bugs.launchpad.net/bugs/696493
>
> According to datasheet (and real-world testing), IDT 92HD88B can
> have internal mics at NID 0x11 and 0x20, so enable them accordingly.
>
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
Thanks, applied.
Takashi
>
> --
> David Henningsson, Canonical Ltd.
> http://launchpad.net/~diwic
> [2 0001-ALSA-HDA-Add-internal-mic-for-IDT-92HD88B.patch <text/x-patch (7bit)>]
> >From 4fdc8bb0ab1e786821003cb448559efea9d5081a Mon Sep 17 00:00:00 2001
> From: David Henningsson <david.henningsson@canonical.com>
> Date: Tue, 4 Jan 2011 06:30:53 +0100
> Subject: [PATCH] ALSA: HDA: Add internal mic for IDT 92HD88B
>
> BugLink: http://bugs.launchpad.net/bugs/696493
>
> According to datasheet (and real-world testing), IDT 92HD88B can
> have internal mics at NID 0x11 and 0x20, so enable them accordingly.
>
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
> ---
> sound/pci/hda/patch_sigmatel.c | 12 +++++++++++-
> 1 files changed, 11 insertions(+), 1 deletions(-)
>
> diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
> index 6131a92..c8d812e 100644
> --- a/sound/pci/hda/patch_sigmatel.c
> +++ b/sound/pci/hda/patch_sigmatel.c
> @@ -389,6 +389,9 @@ static hda_nid_t stac92hd83xxx_dmic_nids[STAC92HD83XXX_NUM_DMICS + 1] = {
> 0x11, 0x20, 0
> };
>
> +#define STAC92HD88XXX_NUM_DMICS STAC92HD83XXX_NUM_DMICS
> +#define stac92hd88xxx_dmic_nids stac92hd83xxx_dmic_nids
> +
> #define STAC92HD87B_NUM_DMICS 1
> static hda_nid_t stac92hd87b_dmic_nids[STAC92HD87B_NUM_DMICS + 1] = {
> 0x11, 0
> @@ -5462,11 +5465,18 @@ again:
> spec->num_dmics = stac92xx_connected_ports(codec,
> stac92hd87b_dmic_nids,
> STAC92HD87B_NUM_DMICS);
> - /* Fall through */
> + spec->num_pins = ARRAY_SIZE(stac92hd88xxx_pin_nids);
> + spec->pin_nids = stac92hd88xxx_pin_nids;
> + spec->mono_nid = 0;
> + spec->num_pwrs = 0;
> + break;
> case 0x111d7666:
> case 0x111d7667:
> case 0x111d7668:
> case 0x111d7669:
> + spec->num_dmics = stac92xx_connected_ports(codec,
> + stac92hd88xxx_dmic_nids,
> + STAC92HD88XXX_NUM_DMICS);
> spec->num_pins = ARRAY_SIZE(stac92hd88xxx_pin_nids);
> spec->pin_nids = stac92hd88xxx_pin_nids;
> spec->mono_nid = 0;
> --
> 1.7.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-10 10:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-04 5:57 [PATCH] ALSA: HDA: Add internal mic for IDT 92HD88B David Henningsson
2011-01-10 10:19 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.