From: Peter Jones <pjones@redhat.com>
To: James Bottomley <James.Bottomley@suse.de>
Cc: Tejun Heo <tj@kernel.org>, Linux SCSI <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] Use a better comparitor for scsi vendor/model table matching.
Date: Wed, 05 Jan 2011 11:50:09 -0500 [thread overview]
Message-ID: <4D24A141.70105@redhat.com> (raw)
In-Reply-To: <1294245387.15356.11.camel@mulgrave.site>
On 01/05/2011 11:36 AM, James Bottomley wrote:
> On Wed, 2011-01-05 at 10:39 -0500, Peter Jones wrote:
>> Previously we were using strncmp in order to avoid having to include
>> whitespace in the devlist, but this means "HSV1000" matches a device
>> list entry that says "HSV100", which is wrong. This patch adds
>> scsi_dh_strcmp(), which checks that any trailing characters in string 2
>> are the pad character 0x20.
>
> Hmm, the cockup comes from dh rolling its own comparators. Could you
> just convert it to use the standard ones in scsi_devinfo.c? There's an
> example of how to do this in scsi_transport_spi.c
Oh, sure. Thanks for the pointer.
--
Peter
THE MAGIC WORDS ARE SQUEAMISH OSSIFRAGE
prev parent reply other threads:[~2011-01-05 16:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 15:39 [PATCH] Use a better comparitor for scsi vendor/model table matching Peter Jones
2011-01-05 16:36 ` James Bottomley
2011-01-05 16:50 ` Peter Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D24A141.70105@redhat.com \
--to=pjones@redhat.com \
--cc=James.Bottomley@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.