From: Sebastian Andrzej Siewior <bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
To: Florian Fainelli <ffainelli-MmRyKUhfbQ9GWvitb5QawA@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
sodaville-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org,
Dirk Brandewie
<dirk.brandewie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org
Subject: Re: [PATCH 3/6] i2c/pxa2xx: Add PCI support for PXA I2C controller
Date: Wed, 05 Jan 2011 18:26:21 +0100 [thread overview]
Message-ID: <4D24A9BD.6010200@linutronix.de> (raw)
In-Reply-To: <201012141535.30589.ffainelli-MmRyKUhfbQ9GWvitb5QawA@public.gmane.org>
Florian Fainelli wrote:
>> diff --git a/drivers/i2c/busses/i2c-pxa-pci.c
>> b/drivers/i2c/busses/i2c-pxa-pci.c new file mode 100644
>> index 0000000..f7b74b9
>> --- /dev/null
>> +++ b/drivers/i2c/busses/i2c-pxa-pci.c
>> +
>> +/*
>> + * the number of bars is hardcoded because pci_select_bars() reports the
>> + * wrong thing.
>> + */
>> +#define CE4100_PCI_I2C_DEVS 3
>
> I am surprised of your comment about pci_select_bars, it works fine here on a
> CE4100 device, beware that it will report a bitmask of valid resources (7).
>
> Changing it later would be quite simple anyway.
yep, my bad. I removed the comment and we can make it fully dynamic once
it is required.
Sebastian
WARNING: multiple messages have this Message-ID (diff)
From: bigeasy@linutronix.de (Sebastian Andrzej Siewior)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] i2c/pxa2xx: Add PCI support for PXA I2C controller
Date: Wed, 05 Jan 2011 18:26:21 +0100 [thread overview]
Message-ID: <4D24A9BD.6010200@linutronix.de> (raw)
In-Reply-To: <201012141535.30589.ffainelli@freebox.fr>
Florian Fainelli wrote:
>> diff --git a/drivers/i2c/busses/i2c-pxa-pci.c
>> b/drivers/i2c/busses/i2c-pxa-pci.c new file mode 100644
>> index 0000000..f7b74b9
>> --- /dev/null
>> +++ b/drivers/i2c/busses/i2c-pxa-pci.c
>> +
>> +/*
>> + * the number of bars is hardcoded because pci_select_bars() reports the
>> + * wrong thing.
>> + */
>> +#define CE4100_PCI_I2C_DEVS 3
>
> I am surprised of your comment about pci_select_bars, it works fine here on a
> CE4100 device, beware that it will report a bitmask of valid resources (7).
>
> Changing it later would be quite simple anyway.
yep, my bad. I removed the comment and we can make it fully dynamic once
it is required.
Sebastian
next prev parent reply other threads:[~2011-01-05 17:26 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 20:09 I2C support for CE4100, v2 Sebastian Andrzej Siewior
2010-12-02 20:09 ` Sebastian Andrzej Siewior
[not found] ` <1291320589-31570-1-git-send-email-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2010-12-02 20:09 ` [PATCH 1/6] i2c/pxa2xx: Don't touch ISAR on X86 Sebastian Andrzej Siewior
2010-12-02 20:09 ` Sebastian Andrzej Siewior
[not found] ` <1291320589-31570-2-git-send-email-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2010-12-03 1:44 ` Ben Dooks
2010-12-03 1:44 ` Ben Dooks
[not found] ` <20101203014424.GG24979-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2010-12-03 18:17 ` Sebastian Andrzej Siewior
2010-12-03 18:17 ` Sebastian Andrzej Siewior
[not found] ` <4CF93420.9010006-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2010-12-04 18:22 ` [sodaville] " Sebastian Andrzej Siewior
2010-12-04 18:22 ` Sebastian Andrzej Siewior
[not found] ` <20101204182209.GA23352-Hfxr4Dq0UpYb1SvskN2V4Q@public.gmane.org>
2010-12-06 4:40 ` Ben Dooks
2010-12-06 4:40 ` Ben Dooks
2010-12-02 20:09 ` [PATCH 2/6] arm/pxa2xx: reorganize I2C files Sebastian Andrzej Siewior
2010-12-02 20:09 ` Sebastian Andrzej Siewior
2010-12-02 20:09 ` [PATCH 3/6] i2c/pxa2xx: Add PCI support for PXA I2C controller Sebastian Andrzej Siewior
2010-12-02 20:09 ` Sebastian Andrzej Siewior
[not found] ` <1291320589-31570-4-git-send-email-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2010-12-14 14:35 ` Florian Fainelli
2010-12-14 14:35 ` Florian Fainelli
[not found] ` <201012141535.30589.ffainelli-MmRyKUhfbQ9GWvitb5QawA@public.gmane.org>
2011-01-05 17:26 ` Sebastian Andrzej Siewior [this message]
2011-01-05 17:26 ` Sebastian Andrzej Siewior
2010-12-02 20:09 ` [PATCH 4/6] i2c/pxa2xx: add support for shared IRQ handler Sebastian Andrzej Siewior
2010-12-02 20:09 ` Sebastian Andrzej Siewior
2010-12-02 20:09 ` [PATCH 5/6] i2c/pxa2xx: check timeout correctly Sebastian Andrzej Siewior
2010-12-02 20:09 ` Sebastian Andrzej Siewior
2010-12-02 20:09 ` [PATCH 6/6] i2c/pxa2xx: pass of_node from platform driver to adapter and publish Sebastian Andrzej Siewior
2010-12-02 20:09 ` Sebastian Andrzej Siewior
-- strict thread matches above, loose matches on Subject: below --
2011-01-05 16:50 I2C support for CE4100, v3 Sebastian Andrzej Siewior
[not found] ` <1294246263-31960-1-git-send-email-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2011-01-05 16:51 ` [PATCH 3/6] i2c/pxa2xx: Add PCI support for PXA I2C controller Sebastian Andrzej Siewior
2011-01-05 16:51 ` Sebastian Andrzej Siewior
[not found] ` <1294246263-31960-4-git-send-email-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2011-01-05 20:21 ` Ben Dooks
2011-01-05 20:21 ` Ben Dooks
[not found] ` <20110105202136.GI817-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2011-01-05 22:18 ` Sebastian Andrzej Siewior
2011-01-05 22:18 ` Sebastian Andrzej Siewior
2011-01-14 14:31 ` Sebastian Andrzej Siewior
2011-01-14 14:31 ` Sebastian Andrzej Siewior
2011-02-07 17:56 ` Sebastian Andrzej Siewior
2011-02-07 17:56 ` Sebastian Andrzej Siewior
[not found] ` <20110207175604.GA24850-Hfxr4Dq0UpYb1SvskN2V4Q@public.gmane.org>
2011-02-23 1:14 ` Ben Dooks
2011-02-23 1:14 ` Ben Dooks
2011-01-05 23:03 ` Russell King - ARM Linux
2011-01-05 23:03 ` Russell King - ARM Linux
[not found] ` <20110105230342.GO8638-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2011-01-05 23:08 ` Greg KH
2011-01-05 23:08 ` Greg KH
[not found] ` <20110105230834.GA26399-l3A5Bk7waGM@public.gmane.org>
2011-01-06 9:20 ` Russell King - ARM Linux
2011-01-06 9:20 ` Russell King - ARM Linux
[not found] ` <20110106092044.GT8638-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2011-01-06 21:57 ` Greg KH
2011-01-06 21:57 ` Greg KH
2011-01-06 10:50 ` Sebastian Andrzej Siewior
2011-01-06 10:50 ` Sebastian Andrzej Siewior
[not found] ` <20110106105051.GA12146-Hfxr4Dq0UpYb1SvskN2V4Q@public.gmane.org>
2011-01-06 11:12 ` Russell King - ARM Linux
2011-01-06 11:12 ` Russell King - ARM Linux
[not found] ` <20110106111231.GD31708-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2011-01-06 11:50 ` Sebastian Andrzej Siewior
2011-01-06 11:50 ` Sebastian Andrzej Siewior
[not found] ` <20110106115026.GA18081-Hfxr4Dq0UpYb1SvskN2V4Q@public.gmane.org>
2011-01-07 15:57 ` Grant Likely
2011-01-07 15:57 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D24A9BD.6010200@linutronix.de \
--to=bigeasy-hfztesqfncyowbw4kg4ksq@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=dirk.brandewie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ffainelli-MmRyKUhfbQ9GWvitb5QawA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=sodaville-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.