From: Jeff Garzik <jgarzik@pobox.com>
To: mkl0301@gmail.com
Cc: cbouatmailru@gmail.com, htejun@gmail.com,
linux-arm-kernel@lists.infradead.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH v2 0/3] add CNS3xxx AHCI support
Date: Wed, 05 Jan 2011 13:15:24 -0500 [thread overview]
Message-ID: <4D24B53C.4020009@pobox.com> (raw)
In-Reply-To: <1294206187-11487-1-git-send-email-mkl0301@gmail.com>
On 01/05/2011 12:43 AM, mkl0301@gmail.com wrote:
> From: Mac Lin<mkl0301@gmail.com>
>
> v2:
> - Switch ahci_platform to module device table matching to add SoC specific support
>
> v1: http://www.spinics.net/lists/arm-kernel/msg106236.html
> - Add CNS3xxx SoC specific AHCI support
>
> This patchset is based on linux-2.6.37-rc2
>
> Mac Lin (3):
> ahci_platform: rename to ahci_pltfm, but keep the original module name
> ahci_pltfm: switch to module device table matching
> ahci_platform: add support for CNS3xxx SoC devices
>
> arch/arm/mach-cns3xxx/devices.c | 2 +-
> drivers/ata/Kconfig | 11 ++
> drivers/ata/Makefile | 5 +-
> drivers/ata/ahci_cns3xxx.c | 62 +++++++++++
> drivers/ata/ahci_platform.c | 197 ------------------------------------
> drivers/ata/ahci_pltfm.c | 212 +++++++++++++++++++++++++++++++++++++++
> drivers/ata/ahci_pltfm.h | 19 ++++
> 7 files changed, 309 insertions(+), 199 deletions(-)
> create mode 100644 drivers/ata/ahci_cns3xxx.c
> delete mode 100644 drivers/ata/ahci_platform.c
> create mode 100644 drivers/ata/ahci_pltfm.c
> create mode 100644 drivers/ata/ahci_pltfm.h
It is overkill to rename the entirety of ahci_platform just for one
override function.
This sort of thing I would have expected to be added directly to
ahci_platform.c.
Jeff
WARNING: multiple messages have this Message-ID (diff)
From: jgarzik@pobox.com (Jeff Garzik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/3] add CNS3xxx AHCI support
Date: Wed, 05 Jan 2011 13:15:24 -0500 [thread overview]
Message-ID: <4D24B53C.4020009@pobox.com> (raw)
In-Reply-To: <1294206187-11487-1-git-send-email-mkl0301@gmail.com>
On 01/05/2011 12:43 AM, mkl0301 at gmail.com wrote:
> From: Mac Lin<mkl0301@gmail.com>
>
> v2:
> - Switch ahci_platform to module device table matching to add SoC specific support
>
> v1: http://www.spinics.net/lists/arm-kernel/msg106236.html
> - Add CNS3xxx SoC specific AHCI support
>
> This patchset is based on linux-2.6.37-rc2
>
> Mac Lin (3):
> ahci_platform: rename to ahci_pltfm, but keep the original module name
> ahci_pltfm: switch to module device table matching
> ahci_platform: add support for CNS3xxx SoC devices
>
> arch/arm/mach-cns3xxx/devices.c | 2 +-
> drivers/ata/Kconfig | 11 ++
> drivers/ata/Makefile | 5 +-
> drivers/ata/ahci_cns3xxx.c | 62 +++++++++++
> drivers/ata/ahci_platform.c | 197 ------------------------------------
> drivers/ata/ahci_pltfm.c | 212 +++++++++++++++++++++++++++++++++++++++
> drivers/ata/ahci_pltfm.h | 19 ++++
> 7 files changed, 309 insertions(+), 199 deletions(-)
> create mode 100644 drivers/ata/ahci_cns3xxx.c
> delete mode 100644 drivers/ata/ahci_platform.c
> create mode 100644 drivers/ata/ahci_pltfm.c
> create mode 100644 drivers/ata/ahci_pltfm.h
It is overkill to rename the entirety of ahci_platform just for one
override function.
This sort of thing I would have expected to be added directly to
ahci_platform.c.
Jeff
next prev parent reply other threads:[~2011-01-05 18:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 5:43 [PATCH v2 0/3] add CNS3xxx AHCI support mkl0301
2011-01-05 5:43 ` mkl0301 at gmail.com
2011-01-05 5:43 ` [PATCH v2 1/3] ahci_platform: rename to ahci_pltfm, but keep the original module name mkl0301
2011-01-05 5:43 ` mkl0301 at gmail.com
2011-01-05 5:43 ` [PATCH v2 2/3] ahci_pltfm: switch to module device table matching mkl0301
2011-01-05 5:43 ` mkl0301 at gmail.com
2011-01-06 10:53 ` Anton Vorontsov
2011-01-06 10:53 ` Anton Vorontsov
2011-01-05 5:43 ` [PATCH v2 3/3] ahci_platform: add support for CNS3xxx SoC devices mkl0301
2011-01-05 5:43 ` mkl0301 at gmail.com
2011-01-06 11:02 ` Anton Vorontsov
2011-01-06 11:02 ` Anton Vorontsov
2011-01-05 18:15 ` Jeff Garzik [this message]
2011-01-05 18:15 ` [PATCH v2 0/3] add CNS3xxx AHCI support Jeff Garzik
2011-01-06 6:43 ` Lin Mac
2011-01-06 6:43 ` Lin Mac
2011-01-06 10:51 ` Anton Vorontsov
2011-01-06 10:51 ` Anton Vorontsov
2011-01-06 16:18 ` Lin Mac
2011-01-06 16:18 ` Lin Mac
2011-01-06 23:17 ` Jeff Garzik
2011-01-06 23:17 ` Jeff Garzik
2011-01-07 15:47 ` Anton Vorontsov
2011-01-07 15:47 ` Anton Vorontsov
2011-01-07 23:44 ` Lin Mac
2011-01-07 23:44 ` Lin Mac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D24B53C.4020009@pobox.com \
--to=jgarzik@pobox.com \
--cc=cbouatmailru@gmail.com \
--cc=htejun@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=mkl0301@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.