From: Jan Kiszka <jan.kiszka@domain.hid>
To: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
Cc: Wolfgang Grandegger <wg@domain.hid>,
Xenomai core <Xenomai-core@domain.hid>
Subject: Re: [Xenomai-core] Build issue with rtcan and I-pipe for linux 2.6.36 on powerpc.
Date: Wed, 05 Jan 2011 21:30:06 +0100 [thread overview]
Message-ID: <4D24D4CE.6030600@domain.hid> (raw)
In-Reply-To: <4D24D3C0.8080205@domain.hid>
[-- Attachment #1: Type: text/plain, Size: 815 bytes --]
Am 05.01.2011 21:25, Gilles Chanteperdrix wrote:
> Jan Kiszka wrote:
>> Am 03.01.2011 11:32, Wolfgang Grandegger wrote:
>>> Hi Gilles,
>>>
>>> the attached patch fixes the issue.
>>>
>>
>> Nothing critical, but I think we should consistently wrap the other way
>> around
>>
>> #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,36)
>> #define platform_device of_device
>> #endif
>>
>> and update the users to the new style.
>
> Err... Am I missing the obvious here? If you include
> <linux/platform_device.h> on powerpc you then get a massive mess prior
> to 2.6.36.
Maybe this is an exception, don't know the powerpc details, but
generally our drivers should be written according to latest (supported)
kernel APIs and then extended/wrapped/etc. to compile with older
versions as well.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2011-01-05 20:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-02 19:53 [Xenomai-core] Build issue with rtcan and I-pipe for linux 2.6.36 on powerpc Gilles Chanteperdrix
2011-01-03 10:32 ` Wolfgang Grandegger
2011-01-03 21:11 ` Gilles Chanteperdrix
2011-01-05 20:22 ` Jan Kiszka
2011-01-05 20:25 ` Gilles Chanteperdrix
2011-01-05 20:30 ` Jan Kiszka [this message]
2011-01-05 20:39 ` Gilles Chanteperdrix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D24D4CE.6030600@domain.hid \
--to=jan.kiszka@domain.hid \
--cc=Xenomai-core@domain.hid \
--cc=gilles.chanteperdrix@xenomai.org \
--cc=wg@domain.hid \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.