All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Jin <joe.jin@oracle.com>
To: Ian Campbell <Ian.Campbell@eu.citrix.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	"jeremy@goop.org" <jeremy@goop.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"gurudas.pai@oracle.com" <gurudas.pai@oracle.com>,
	"greg.marsden@oracle.com" <greg.marsden@oracle.com>,
	"guru.anbalagane@oracle.com" <guru.anbalagane@oracle.com>
Subject: Re: [patch] xenfb: fix xenfb suspend/resume race
Date: Thu, 06 Jan 2011 08:14:41 +0000	[thread overview]
Message-ID: <4D2579F1.50900@oracle.com> (raw)
In-Reply-To: <1294300924.13733.42.camel@localhost.localdomain>


> 
> No, it papers over the issue, the code should never have been allowed to
> get this far if the connection to the backend is not yet fully resumed
> (i.e. when irq = -1).
> 
> The call to xenfb_send_event should have been gated further up the call
> chain, AFAICT by the check of info->update_wanted in xenfb_refresh. This
> suggests that the correct fix is to set info->update_wanted = 0 in
> xenfb_resume.
> 
> I said all this in my previous mail and you ignored it. Did you try this
> approach?

Will try this then update you.

Thanks,
Joe

WARNING: multiple messages have this Message-ID (diff)
From: Joe Jin <joe.jin@oracle.com>
To: Ian Campbell <Ian.Campbell@eu.citrix.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	"jeremy@goop.org" <jeremy@goop.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"gurudas.pai@oracle.com" <gurudas.pai@oracle.com>,
	"greg.marsden@oracle.com" <greg.marsden@oracle.com>,
	"guru.anbalagane@oracle.com" <guru.anbalagane@oracle.com>
Subject: Re: [patch] xenfb: fix xenfb suspend/resume race
Date: Thu, 06 Jan 2011 16:14:41 +0800	[thread overview]
Message-ID: <4D2579F1.50900@oracle.com> (raw)
In-Reply-To: <1294300924.13733.42.camel@localhost.localdomain>


> 
> No, it papers over the issue, the code should never have been allowed to
> get this far if the connection to the backend is not yet fully resumed
> (i.e. when irq == -1).
> 
> The call to xenfb_send_event should have been gated further up the call
> chain, AFAICT by the check of info->update_wanted in xenfb_refresh. This
> suggests that the correct fix is to set info->update_wanted = 0 in
> xenfb_resume.
> 
> I said all this in my previous mail and you ignored it. Did you try this
> approach?

Will try this then update you.

Thanks,
Joe

  reply	other threads:[~2011-01-06  8:14 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-30 12:56 [patch] xenfb: fix xenfb suspend/resume race Joe Jin
2010-12-30 12:56 ` Joe Jin
2010-12-30 16:40 ` Konrad Rzeszutek Wilk
2010-12-30 16:40   ` Konrad Rzeszutek Wilk
2010-12-30 16:40   ` Konrad Rzeszutek Wilk
2010-12-31  0:56   ` Joe Jin
2010-12-31  0:56     ` Joe Jin
2011-01-03 16:34     ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-01-03 16:34       ` Konrad Rzeszutek Wilk
2011-01-04  0:34       ` Joe Jin
2011-01-04  0:34         ` Joe Jin
2011-01-04 11:15   ` Ian Campbell
2011-01-04 11:15     ` Ian Campbell
2011-01-06  7:14     ` Joe Jin
2011-01-06  7:14       ` Joe Jin
2011-01-06  8:02       ` Ian Campbell
2011-01-06  8:02         ` Ian Campbell
2011-01-06  8:14         ` Joe Jin [this message]
2011-01-06  8:14           ` Joe Jin
2011-01-07  6:43           ` [Xen-devel] " Joe Jin
2011-01-07  6:43             ` Joe Jin
2011-01-06  8:47         ` Ian Campbell
2011-01-06  8:47           ` Ian Campbell
  -- strict thread matches above, loose matches on Subject: below --
2011-01-07  6:40 Joe Jin
2011-01-07  6:40 ` Joe Jin
2011-01-07  9:17 ` Ian Campbell
2011-01-07  9:17   ` Ian Campbell
2011-01-07  9:17   ` Ian Campbell
2011-01-07 10:17 ` Joe Jin
2011-01-07 10:17   ` Joe Jin
2011-01-07 10:17   ` Joe Jin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D2579F1.50900@oracle.com \
    --to=joe.jin@oracle.com \
    --cc=Ian.Campbell@eu.citrix.com \
    --cc=akpm@linux-foundation.org \
    --cc=greg.marsden@oracle.com \
    --cc=guru.anbalagane@oracle.com \
    --cc=gurudas.pai@oracle.com \
    --cc=jeremy@goop.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.