All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Fix ep93xx-fb init/exit annotations
@ 2011-01-09 23:55 Ryan Mallon
  2011-01-10 17:34 ` H Hartley Sweeten
  0 siblings, 1 reply; 2+ messages in thread
From: Ryan Mallon @ 2011-01-09 23:55 UTC (permalink / raw)
  To: linux-arm-kernel

Fix section mismatch errors in the ep93xx-fb driver resulting from
incorrect init/exit annotations.

Reported-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Ryan Mallon <ryan@bluewatersys.com>

---

diff --git a/drivers/video/ep93xx-fb.c b/drivers/video/ep93xx-fb.c
index 0c99de0..b358d04 100644
--- a/drivers/video/ep93xx-fb.c
+++ b/drivers/video/ep93xx-fb.c
@@ -483,7 +483,7 @@ static void ep93xxfb_dealloc_videomem(struct fb_info *info)
 				  info->screen_base, info->fix.smem_start);
 }
 
-static int __init ep93xxfb_probe(struct platform_device *pdev)
+static int __devinit ep93xxfb_probe(struct platform_device *pdev)
 {
 	struct ep93xxfb_mach_info *mach_info = pdev->dev.platform_data;
 	struct fb_info *info;
@@ -598,7 +598,7 @@ failed:
 	return err;
 }
 
-static int ep93xxfb_remove(struct platform_device *pdev)
+static int __devexit ep93xxfb_remove(struct platform_device *pdev)
 {
 	struct fb_info *info = platform_get_drvdata(pdev);
 	struct ep93xx_fbi *fbi = info->par;
@@ -622,7 +622,7 @@ static int ep93xxfb_remove(struct platform_device *pdev)
 
 static struct platform_driver ep93xxfb_driver = {
 	.probe		= ep93xxfb_probe,
-	.remove		= ep93xxfb_remove,
+	.remove		= __devexit_p(ep93xxfb_remove),
 	.driver = {
 		.name	= "ep93xx-fb",
 		.owner	= THIS_MODULE,

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] Fix ep93xx-fb init/exit annotations
  2011-01-09 23:55 [PATCH] Fix ep93xx-fb init/exit annotations Ryan Mallon
@ 2011-01-10 17:34 ` H Hartley Sweeten
  0 siblings, 0 replies; 2+ messages in thread
From: H Hartley Sweeten @ 2011-01-10 17:34 UTC (permalink / raw)
  To: linux-arm-kernel

Sunday, January 09, 2011 4:56 PM, Ryan Mallon wrote:
>
> Fix section mismatch errors in the ep93xx-fb driver resulting from
> incorrect init/exit annotations.
>
> Reported-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Signed-off-by: Ryan Mallon <ryan@bluewatersys.com>

That fixed it.

Tested-by: H Hartley Sweeten <hsweeten@visionengravers.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-01-10 17:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-09 23:55 [PATCH] Fix ep93xx-fb init/exit annotations Ryan Mallon
2011-01-10 17:34 ` H Hartley Sweeten

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.