From: Nishanth Menon <nm@ti.com>
To: Aaro Koskinen <aaro.koskinen@nokia.com>
Cc: l-o <linux-omap@vger.kernel.org>,
l-a <linux-arm-kernel@lists.infradead.org>,
Kevin <khilman@ti.com>, Tony <tony@atomide.com>,
Koen Kooi <koen@beagleboard.org>
Subject: Re: [PATCH v4 3/3] omap3: beaglexm: fix power on of DVI
Date: Mon, 10 Jan 2011 08:34:50 -0600 [thread overview]
Message-ID: <4D2B190A.4020504@ti.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1101101445080.18906@esdhcp041196.research.nokia.com>
Aaro Koskinen had written, on 01/10/2011 06:51 AM, the following:
[..]
>> + if (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XM) {
>> + gpio_request(gpio + 1, "nDVI_PWR_EN");
>> + gpio_direction_output(gpio + 1, 0);
>> + gpio_request(gpio + 2, "DVI_LDO_EN");
>> + gpio_direction_output(gpio + 2, 1);
>
> FYI, gpiolib provides gpio_request_one() and gpio_request_array() calls
> which make code simpler. I think any new code should use those _and_
> do proper error checking.
Thanks for pointing this out. Funny why it is in
include/asm-generic/gpio.h instead of in include/linux/gpio.h
considering it implemented in drivers/gpio/gpiolib.c :(
Am I right in understanding that you are mentioning about DVI gpios
alone? in that case, the LDO gpio is used for other functions as well in
addition to driving DVI. I suppose we dont want to loose that function
because dvi pwr_en gpio failed.
--
Regards,
Nishanth Menon
WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/3] omap3: beaglexm: fix power on of DVI
Date: Mon, 10 Jan 2011 08:34:50 -0600 [thread overview]
Message-ID: <4D2B190A.4020504@ti.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1101101445080.18906@esdhcp041196.research.nokia.com>
Aaro Koskinen had written, on 01/10/2011 06:51 AM, the following:
[..]
>> + if (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XM) {
>> + gpio_request(gpio + 1, "nDVI_PWR_EN");
>> + gpio_direction_output(gpio + 1, 0);
>> + gpio_request(gpio + 2, "DVI_LDO_EN");
>> + gpio_direction_output(gpio + 2, 1);
>
> FYI, gpiolib provides gpio_request_one() and gpio_request_array() calls
> which make code simpler. I think any new code should use those _and_
> do proper error checking.
Thanks for pointing this out. Funny why it is in
include/asm-generic/gpio.h instead of in include/linux/gpio.h
considering it implemented in drivers/gpio/gpiolib.c :(
Am I right in understanding that you are mentioning about DVI gpios
alone? in that case, the LDO gpio is used for other functions as well in
addition to driving DVI. I suppose we dont want to loose that function
because dvi pwr_en gpio failed.
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2011-01-10 14:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH v3 0/3] OMAP3: beaglexm: GPIO fixes>
2011-01-07 23:01 ` [PATCH v4 0/3] OMAP3: beaglexm: GPIO fixes Nishanth Menon
2011-01-07 23:01 ` Nishanth Menon
2011-01-07 23:17 ` Kevin Hilman
2011-01-07 23:17 ` Kevin Hilman
2011-01-10 19:04 ` Tony Lindgren
2011-01-10 19:04 ` Tony Lindgren
2011-01-10 19:13 ` Nishanth Menon
2011-01-10 19:13 ` Nishanth Menon
2011-01-07 23:01 ` [PATCH v4 1/3] omap3: beaglexm: fix EHCI power up GPIO dir Nishanth Menon
2011-01-07 23:01 ` Nishanth Menon
2011-01-10 12:44 ` Aaro Koskinen
2011-01-10 12:44 ` Aaro Koskinen
2011-01-10 14:23 ` Nishanth Menon
2011-01-10 14:23 ` Nishanth Menon
2011-01-07 23:01 ` [PATCH v4 2/3] omap3: beaglexm: fix DVI reset GPIO Nishanth Menon
2011-01-07 23:01 ` Nishanth Menon
2011-01-07 23:01 ` [PATCH v4 3/3] omap3: beaglexm: fix power on of DVI Nishanth Menon
2011-01-07 23:01 ` Nishanth Menon
2011-01-10 12:51 ` Aaro Koskinen
2011-01-10 12:51 ` Aaro Koskinen
2011-01-10 14:34 ` Nishanth Menon [this message]
2011-01-10 14:34 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2B190A.4020504@ti.com \
--to=nm@ti.com \
--cc=aaro.koskinen@nokia.com \
--cc=khilman@ti.com \
--cc=koen@beagleboard.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.