[PATCH v4, 5/5] udev: Add nokiacdma device

[PATCH v4, 5/5] udev: Add nokiacdma device

[Dara Spieker-Doyle]

[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]

---
 plugins/udev.c |   16 ++++++++++++++++
 1 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/plugins/udev.c b/plugins/udev.c
index 6a59b06..12402eb 100644
--- a/plugins/udev.c
+++ b/plugins/udev.c
@@ -462,6 +462,20 @@ static void add_calypso(struct ofono_modem *modem,
 	ofono_modem_register(modem);
 }
 
+static void add_nokiacdma(struct ofono_modem *modem,
+					struct udev_device *udev_device)
+{
+	const char *devnode;
+
+	DBG("modem %p", modem);
+
+	devnode = udev_device_get_devnode(udev_device);
+
+	ofono_modem_set_string(modem, "Device", devnode);
+	ofono_modem_set_integer(modem, "Registered", 1);
+	ofono_modem_register(modem);
+}
+
 static void add_modem(struct udev_device *udev_device)
 {
 	struct ofono_modem *modem;
@@ -548,6 +562,8 @@ done:
 		add_isi(modem, udev_device);
 	else if (g_strcmp0(driver, "calypso") == 0)
 		add_calypso(modem, udev_device);
+	else if (g_strcmp0(driver, "nokiacdma") == 0)
+		add_nokiacdma(modem, udev_device);
 }
 
 static gboolean devpath_remove(gpointer key, gpointer value, gpointer user_data)
-- 
1.7.0.4

Re: [PATCH v4, 5/5] udev: Add nokiacdma device

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 1453 bytes --]

Hi Dara,

On 01/03/2011 07:50 PM, Dara Spieker-Doyle wrote:
> ---
>  plugins/udev.c |   16 ++++++++++++++++
>  1 files changed, 16 insertions(+), 0 deletions(-)
> 
> diff --git a/plugins/udev.c b/plugins/udev.c
> index 6a59b06..12402eb 100644
> --- a/plugins/udev.c
> +++ b/plugins/udev.c
> @@ -462,6 +462,20 @@ static void add_calypso(struct ofono_modem *modem,
>  	ofono_modem_register(modem);
>  }
>  
> +static void add_nokiacdma(struct ofono_modem *modem,
> +					struct udev_device *udev_device)
> +{
> +	const char *devnode;
> +
> +	DBG("modem %p", modem);
> +
> +	devnode = udev_device_get_devnode(udev_device);
> +
> +	ofono_modem_set_string(modem, "Device", devnode);
> +	ofono_modem_set_integer(modem, "Registered", 1);

Since you told me that your modem only has a single AT command port, you
don't really need this Registered part here.  Does this device support
high speed USB network access or PPP only?

> +	ofono_modem_register(modem);
> +}
> +
>  static void add_modem(struct udev_device *udev_device)
>  {
>  	struct ofono_modem *modem;
> @@ -548,6 +562,8 @@ done:
>  		add_isi(modem, udev_device);
>  	else if (g_strcmp0(driver, "calypso") == 0)
>  		add_calypso(modem, udev_device);
> +	else if (g_strcmp0(driver, "nokiacdma") == 0)
> +		add_nokiacdma(modem, udev_device);
>  }
>  
>  static gboolean devpath_remove(gpointer key, gpointer value, gpointer user_data)

Regards,
-Denis

Re: [PATCH v4, 5/5] udev: Add nokiacdma device

[Dara Spieker-Doyle]

[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]

Hi Denis

On 01/10/2011 02:35 PM, ext Denis Kenzior wrote:
> Hi Dara,
>
> On 01/03/2011 07:50 PM, Dara Spieker-Doyle wrote:
>> ---
>>   plugins/udev.c |   16 ++++++++++++++++
>>   1 files changed, 16 insertions(+), 0 deletions(-)
>>
>> diff --git a/plugins/udev.c b/plugins/udev.c
>> index 6a59b06..12402eb 100644
>> --- a/plugins/udev.c
>> +++ b/plugins/udev.c
>> @@ -462,6 +462,20 @@ static void add_calypso(struct ofono_modem *modem,
>>   	ofono_modem_register(modem);
>>   }
>>
>> +static void add_nokiacdma(struct ofono_modem *modem,
>> +					struct udev_device *udev_device)
>> +{
>> +	const char *devnode;
>> +
>> +	DBG("modem %p", modem);
>> +
>> +	devnode = udev_device_get_devnode(udev_device);
>> +
>> +	ofono_modem_set_string(modem, "Device", devnode);
>> +	ofono_modem_set_integer(modem, "Registered", 1);
>
> Since you told me that your modem only has a single AT command port, you
> don't really need this Registered part here.  Does this device support
> high speed USB network access or PPP only?
>

Ergh sorry, yes this is an oversight and should have been cleaned out 
with the other integration relics. I'll remove it with the patch rebase.
This device is PPP only.

Thanks
Dara