linux-cr: v23-rc1 pushed

linux-cr: v23-rc1 pushed

[Oren Laadan]

Folks,

I just pushed out a new v23-rc1 branch of linux-cr. This one is
rebased to 2.6.37, and contains nearly all the patches pulled
on v22-dev. I only gave it a brief test drive... feel free to 
throw all your ammo it.

Rebasing was fairly straightforward, but I'd feel more comfortable 
with more eyes looking at some code, specifically:

userns [Serge ?]
sockets [Dan ?]
cgroup_freezer [Matt ?]

I skipped PowerPC patches and ARM patches. Nathan, Christoffer -
can you take a look at those, respectively, and re-post to list ?

For the "final" v23, I'm hoping to add at least the logic for
unlinked files and inotify-and-friends; so now is probably a
good time to start circulating them ... (hint!)

There are some updates and fixes to user-cr too, mainly pulling
(and reworking) suka's old cleanup patches, and updating the
include files.

I also pulled and reworked Suka's patches for file-locks, and 
Nathan's patches for hugetlb - will post those seperately.

Happy New Year,

Oren.

Re: linux-cr: v23-rc1 pushed

[Sukadev Bhattiprolu]

Oren Laadan [orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org] wrote:
| Folks,
| 
| I just pushed out a new v23-rc1 branch of linux-cr. This one is
| rebased to 2.6.37, and contains nearly all the patches pulled
| on v22-dev. I only gave it a brief test drive... feel free to 
| throw all your ammo it.

Oren,

We need the file_tty() helper to get the tty object from the file pointer
(otherwise we will be off by 4 bytes and fail tty_paranoia_check() in
tty_file_checkpoint()).

Thanks,

Sukadev

diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index c89f055..6aa458e 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -2781,7 +2784,7 @@ static int tty_file_checkpoint(struct ckpt_ctx *ctx, struc
        int master_objref, slave_objref;
        int ret;
 
-       tty = (struct tty_struct *)file->private_data;
+       tty = file_tty(file);
        inode = file->f_path.dentry->d_inode;
        if (tty_paranoia_check(tty, inode, "tty_file_checkpoint"))
                return -EIO;

Re: linux-cr: v23-rc1 pushed

[Oren Laadan]

On 01/14/2011 01:59 AM, Sukadev Bhattiprolu wrote:
> Oren Laadan [orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org] wrote:
> | Folks,
> | 
> | I just pushed out a new v23-rc1 branch of linux-cr. This one is
> | rebased to 2.6.37, and contains nearly all the patches pulled
> | on v22-dev. I only gave it a brief test drive... feel free to 
> | throw all your ammo it.
> 
> Oren,
> 
> We need the file_tty() helper to get the tty object from the file pointer
> (otherwise we will be off by 4 bytes and fail tty_paranoia_check() in
> tty_file_checkpoint()).

Ok, applied. Thanks,

Oren.

> 
> Thanks,
> 
> Sukadev
> 
> diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
> index c89f055..6aa458e 100644
> --- a/drivers/tty/tty_io.c
> +++ b/drivers/tty/tty_io.c
> @@ -2781,7 +2784,7 @@ static int tty_file_checkpoint(struct ckpt_ctx *ctx, struc
>         int master_objref, slave_objref;
>         int ret;
>  
> -       tty = (struct tty_struct *)file->private_data;
> +       tty = file_tty(file);
>         inode = file->f_path.dentry->d_inode;
>         if (tty_paranoia_check(tty, inode, "tty_file_checkpoint"))
>                 return -EIO;
> 

Re: linux-cr: v23-rc1 pushed

[Matt Helsley]

On Mon, Jan 10, 2011 at 08:18:12PM -0500, Oren Laadan wrote:
> Folks,
> 
> I just pushed out a new v23-rc1 branch of linux-cr. This one is
> rebased to 2.6.37, and contains nearly all the patches pulled
> on v22-dev. I only gave it a brief test drive... feel free to 
> throw all your ammo it.
> 
> Rebasing was fairly straightforward, but I'd feel more comfortable 
> with more eyes looking at some code, specifically:
> 
> userns [Serge ?]
> sockets [Dan ?]
> cgroup_freezer [Matt ?]

Other than the nit I just sent a patch for it looks fine.

> 
> I skipped PowerPC patches and ARM patches. Nathan, Christoffer -
> can you take a look at those, respectively, and re-post to list ?

I looked at the powerpc patches. The only "difficult" part to
forward-port is the debug register checkpoint/restart code. 
It's more difficult because additional debug register support has
since been added to the kernel and those ought to be supported
by c/r too.

I think we'd be better off splitting that out the debug register
c/r code into a separate patch. We can just error ou if it's obvious
that debug registers have been setup. An untested patch for erroring
out is forthcoming. For now I'll let Nathan look into adding the new
debug register support.

Cheers,
	-Matt Helsley