From: walter harms <wharms@bfs.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch v3] [media] av7110: check for negative array offset
Date: Wed, 12 Jan 2011 15:49:01 +0000 [thread overview]
Message-ID: <4D2DCD6D.8030900@bfs.de> (raw)
In-Reply-To: <20110107194153.GA1959@bicker>
Am 12.01.2011 14:30, schrieb Jorge Merlino:
> El 12/01/11 10:44, walter harms escribió:
>>> diff --git a/drivers/media/dvb/ttpci/av7110_ca.c b/drivers/media/dvb/ttpci/av7110_ca.c
>>> index 122c728..923a8e2 100644
>>> --- a/drivers/media/dvb/ttpci/av7110_ca.c
>>> +++ b/drivers/media/dvb/ttpci/av7110_ca.c
>>> @@ -277,7 +277,7 @@ static int dvb_ca_ioctl(struct file *file, unsigned int cmd, void *parg)
>>> {
>>> ca_slot_info_t *info=(ca_slot_info_t *)parg;
>>>
>>> - if (info->num > 1)
>>> + if (info->num < 0 || info->num > 1)
>>> return -EINVAL;
>>
>> maybe i miss the point but anything else than 0 will cause -EINVAL ?
>> Is that intended ?
>
> Anything else than 0 or 1.
mmmh, yes my bad,
ntl can the "1" be replaced with array_size(av7110->ci_slot)-1 ?
re,
wh
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-01-12 15:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 19:41 [patch] [media] av7110: make array offset unsigned Dan Carpenter
2011-01-06 19:41 ` Dan Carpenter
2011-01-07 12:44 ` Andreas Oberritter
2011-01-07 12:44 ` Andreas Oberritter
2011-01-07 13:46 ` [patch v2] [media] av7110: check for negative array offset Dan Carpenter
2011-01-07 13:46 ` Dan Carpenter
2011-01-07 19:01 ` Oliver Endriss
2011-01-07 19:01 ` Oliver Endriss
2011-01-07 19:41 ` [patch v3] " Dan Carpenter
2011-01-07 19:41 ` Dan Carpenter
2011-01-12 12:44 ` walter harms
2011-01-12 13:30 ` Jorge Merlino
2011-01-12 15:49 ` walter harms [this message]
2011-01-07 13:51 ` [patch] [media] av7110: make array offset unsigned Dan Carpenter
2011-01-07 13:51 ` Dan Carpenter
2011-01-07 14:02 ` Vasiliy Kulikov
2011-01-07 14:02 ` Vasiliy Kulikov
2011-01-07 14:05 ` Andreas Oberritter
2011-01-07 14:05 ` Andreas Oberritter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2DCD6D.8030900@bfs.de \
--to=wharms@bfs.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.