From: Dan Carpenter <error27@gmail.com>
To: Andreas Oberritter <obi@linuxtv.org>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] [media] av7110: make array offset unsigned
Date: Fri, 07 Jan 2011 13:51:22 +0000 [thread overview]
Message-ID: <20110107135122.GI1717@bicker> (raw)
In-Reply-To: <4D270A9F.7080104@linuxtv.org>
On Fri, Jan 07, 2011 at 01:44:15PM +0100, Andreas Oberritter wrote:
> Nack. You're changing an interface to userspace. Please add a check to
> av7110_ca.c instead.
>
Ok. I've done that and resent the patch.
But just for my own understanding, why is it wrong to change an int to
an unsigned int in the userspace API? Who would notice? (I'm still
quite a newbie at system programming).
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Andreas Oberritter <obi@linuxtv.org>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] [media] av7110: make array offset unsigned
Date: Fri, 7 Jan 2011 16:51:22 +0300 [thread overview]
Message-ID: <20110107135122.GI1717@bicker> (raw)
In-Reply-To: <4D270A9F.7080104@linuxtv.org>
On Fri, Jan 07, 2011 at 01:44:15PM +0100, Andreas Oberritter wrote:
> Nack. You're changing an interface to userspace. Please add a check to
> av7110_ca.c instead.
>
Ok. I've done that and resent the patch.
But just for my own understanding, why is it wrong to change an int to
an unsigned int in the userspace API? Who would notice? (I'm still
quite a newbie at system programming).
regards,
dan carpenter
next prev parent reply other threads:[~2011-01-07 13:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 19:41 [patch] [media] av7110: make array offset unsigned Dan Carpenter
2011-01-06 19:41 ` Dan Carpenter
2011-01-07 12:44 ` Andreas Oberritter
2011-01-07 12:44 ` Andreas Oberritter
2011-01-07 13:46 ` [patch v2] [media] av7110: check for negative array offset Dan Carpenter
2011-01-07 13:46 ` Dan Carpenter
2011-01-07 19:01 ` Oliver Endriss
2011-01-07 19:01 ` Oliver Endriss
2011-01-07 19:41 ` [patch v3] " Dan Carpenter
2011-01-07 19:41 ` Dan Carpenter
2011-01-12 12:44 ` walter harms
2011-01-12 13:30 ` Jorge Merlino
2011-01-12 15:49 ` walter harms
2011-01-07 13:51 ` Dan Carpenter [this message]
2011-01-07 13:51 ` [patch] [media] av7110: make array offset unsigned Dan Carpenter
2011-01-07 14:02 ` Vasiliy Kulikov
2011-01-07 14:02 ` Vasiliy Kulikov
2011-01-07 14:05 ` Andreas Oberritter
2011-01-07 14:05 ` Andreas Oberritter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110107135122.GI1717@bicker \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=obi@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.