From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, ben-linux@fluff.org,
m.szyprowski@samsung.com, kyungmin.park@samsung.com,
inki.dae@samsung.com
Subject: Re: [PATCH/RFC 1/3] ARM: S5P: Add a platform callback for MIPI CSIS PHY control
Date: Thu, 13 Jan 2011 11:12:59 +0900 [thread overview]
Message-ID: <4D2E5FAB.6010106@samsung.com> (raw)
In-Reply-To: <020301cbb2c1$5ed9dec0$1c8d9c40$%kim@samsung.com>
Hi Kukjin,
thank you for the update.
On 01/13/2011 10:29 AM, Kukjin Kim wrote:
> Sylwester Nawrocki wrote:
>>
>> The phy_enable callback in struct s5p_platform_mipi_csis is added
>> to allow the CSIS driver to control its PHY enable and reset signals.
>> This allows to use same MIPI CSIS driver across various SoCs.
>>
>> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> arch/arm/plat-s5p/dev-csis0.c | 2 +-
>> arch/arm/plat-s5p/dev-csis1.c | 2 +-
>> arch/arm/plat-s5p/include/plat/csis.h | 28 --------------------
>> arch/arm/plat-s5p/include/plat/mipi_csis.h | 39
>> ++++++++++++++++++++++++++++
>> 4 files changed, 41 insertions(+), 30 deletions(-)
>> delete mode 100644 arch/arm/plat-s5p/include/plat/csis.h
>> create mode 100644 arch/arm/plat-s5p/include/plat/mipi_csis.h
>>
...
>
> I think should be separated like following.
>
> If required, ...
>
> 1. change copyright
> 2. rename csis.h to mipi_csis.h
I don't want to bother with a separate patches for that, just prefer
to drop the above changes.
> 3. add phy enable feature
OK, I would reduce the patch to that change only.
Regards,
--
Sylwester Nawrocki
Samsung Poland R&D Center
WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH/RFC 1/3] ARM: S5P: Add a platform callback for MIPI CSIS PHY control
Date: Thu, 13 Jan 2011 11:12:59 +0900 [thread overview]
Message-ID: <4D2E5FAB.6010106@samsung.com> (raw)
In-Reply-To: <020301cbb2c1$5ed9dec0$1c8d9c40$%kim@samsung.com>
Hi Kukjin,
thank you for the update.
On 01/13/2011 10:29 AM, Kukjin Kim wrote:
> Sylwester Nawrocki wrote:
>>
>> The phy_enable callback in struct s5p_platform_mipi_csis is added
>> to allow the CSIS driver to control its PHY enable and reset signals.
>> This allows to use same MIPI CSIS driver across various SoCs.
>>
>> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> arch/arm/plat-s5p/dev-csis0.c | 2 +-
>> arch/arm/plat-s5p/dev-csis1.c | 2 +-
>> arch/arm/plat-s5p/include/plat/csis.h | 28 --------------------
>> arch/arm/plat-s5p/include/plat/mipi_csis.h | 39
>> ++++++++++++++++++++++++++++
>> 4 files changed, 41 insertions(+), 30 deletions(-)
>> delete mode 100644 arch/arm/plat-s5p/include/plat/csis.h
>> create mode 100644 arch/arm/plat-s5p/include/plat/mipi_csis.h
>>
...
>
> I think should be separated like following.
>
> If required, ...
>
> 1. change copyright
> 2. rename csis.h to mipi_csis.h
I don't want to bother with a separate patches for that, just prefer
to drop the above changes.
> 3. add phy enable feature
OK, I would reduce the patch to that change only.
Regards,
--
Sylwester Nawrocki
Samsung Poland R&D Center
next prev parent reply other threads:[~2011-01-13 2:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 15:09 [PATCH/RFC 0/3] ARM: S5P: Add a common platform setup code for MIPI CSIS/DSIM Sylwester Nawrocki
2011-01-04 15:09 ` Sylwester Nawrocki
2011-01-04 15:09 ` [PATCH/RFC 1/3] ARM: S5P: Add a platform callback for MIPI CSIS PHY control Sylwester Nawrocki
2011-01-04 15:09 ` Sylwester Nawrocki
2011-01-13 1:29 ` Kukjin Kim
2011-01-13 1:29 ` Kukjin Kim
2011-01-13 2:12 ` Sylwester Nawrocki [this message]
2011-01-13 2:12 ` Sylwester Nawrocki
2011-01-04 15:09 ` [PATCH/RFC 2/3] ARM: S5PV310: Add a platform helper for MIPI DSIM/CSIS setup Sylwester Nawrocki
2011-01-04 15:09 ` Sylwester Nawrocki
2011-01-13 1:33 ` Kukjin Kim
2011-01-13 1:33 ` Kukjin Kim
2011-01-13 2:36 ` Sylwester Nawrocki
2011-01-13 2:36 ` Sylwester Nawrocki
2011-02-07 16:20 ` Sylwester Nawrocki
2011-02-07 16:20 ` Sylwester Nawrocki
2011-01-04 15:09 ` [PATCH/RFC 3/3] ARM: S5PV210: " Sylwester Nawrocki
2011-01-04 15:09 ` Sylwester Nawrocki
2011-01-12 11:39 ` [PATCH/RFC 0/3] ARM: S5P: Add a common platform setup code for MIPI CSIS/DSIM Sylwester Nawrocki
2011-01-12 11:39 ` Sylwester Nawrocki
2011-01-12 22:34 ` Kukjin Kim
2011-01-12 22:34 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2E5FAB.6010106@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=ben-linux@fluff.org \
--cc=inki.dae@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.