From: Jim Fehlig <jfehlig@novell.com>
To: Chun Yan Liu <CYLiu@novell.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: Last call for forgotten tools patches for Xen 4.1
Date: Thu, 13 Jan 2011 08:48:54 -0700 [thread overview]
Message-ID: <4D2F1EE6.8040109@novell.com> (raw)
In-Reply-To: <19758.58723.681181.302589@mariner.uk.xensource.com>
Ian Jackson wrote:
> Jim Fehlig writes ("Re: [Xen-devel] Last call for forgotten tools patches for Xen 4.1"):
>
>> Sorry for the delay, but I just noticed this tools patch submitted by
>> Chun Yan back in November
>>
>> http://lists.xensource.com/archives/html/xen-devel/2010-11/msg01559.html
>>
>
> Thanks. I replied to that but there was no updated patch.
>
Opps, I thought Chunyan had sent an updated patch but perhaps have
confused this with her qemu keysym patches.
> Now that I look at the patch again I see some other problems:
> * It closes the fd onto the file after locking it with flock (!)
> * On success it unlinks the lock file after locking it (!!)
> * The error return value is wrong (or perhaps it was wrong before).
>
Err, right. And there was no follow-up as I assumed. Chunyan, can you
address Ian's comments and submit an updated patch?
Thanks,
Jim
prev parent reply other threads:[~2011-01-13 15:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 17:53 Last call for forgotten tools patches for Xen 4.1 Ian Jackson
2011-01-12 23:07 ` Jim Fehlig
2011-01-13 11:43 ` Ian Jackson
2011-01-13 15:48 ` Jim Fehlig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2F1EE6.8040109@novell.com \
--to=jfehlig@novell.com \
--cc=CYLiu@novell.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.